[Bug target/98671] gcc/config/i386/i386-options.c:787:redundantAssignment

2021-01-14 Thread ubizjak at gmail dot com via Gcc-bugs 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98671

--- Comment #6 from Uroš Bizjak  ---
(In reply to David Binderman from comment #5)
> (In reply to Uroš Bizjak from comment #4)
> > I'm not sure if solving this would bring us anything.
> 
> For clarity, at very most a 4% reduction in the size of the stack frame
> for function ix86_parse_stringop_strategy_string.

Unfortunately, patched and unpatched compiler results in the same frame size:

011dc690 <_ZL35ix86_parse_stringop_strategy_stringPcb>:
 11dc690:   41 57   push   %r15
 11dc692:   41 56   push   %r14
 11dc694:   41 55   push   %r13
 11dc696:   41 54   push   %r12
 11dc698:   55  push   %rbp
 11dc699:   53  push   %rbx
 11dc69a:   48 89 fbmov%rdi,%rbx
 11dc69d:   48 81 ec 08 01 00 00sub$0x108,%rsp
 ...

[Bug target/98671] gcc/config/i386/i386-options.c:787:redundantAssignment

2021-01-14 Thread dcb314 at hotmail dot com via Gcc-bugs 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98671

--- Comment #5 from David Binderman  ---
(In reply to Uroš Bizjak from comment #4)
> I'm not sure if solving this would bring us anything.

For clarity, at very most a 4% reduction in the size of the stack frame
for function ix86_parse_stringop_strategy_string.

[Bug target/98671] gcc/config/i386/i386-options.c:787:redundantAssignment

2021-01-14 Thread ubizjak at gmail dot com via Gcc-bugs 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98671

Uroš Bizjak  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Uroš Bizjak  ---
Fixed all but:

> trunk.git/gcc/config/i386/i386-options.c:1520:11: warning:inconclusive: Width 
> 10
> given in format string (no. 3) is smaller than destination buffer 'align[16]'.
> [invalidScanfFormatWidth_smaller]

I'm not sure if solving this would bring us anything.

[Bug target/98671] gcc/config/i386/i386-options.c:787:redundantAssignment

2021-01-14 Thread dcb314 at hotmail dot com via Gcc-bugs 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98671

--- Comment #3 from David Binderman  ---
For the same source code file, cppcheck finds these other very minor problems:

1.

trunk.git/gcc/config/i386/i386-options.c:1520:11: warning:inconclusive: Width
10 given in format string (no. 3) is smaller than destination buffer
'align[16]'. [invalidScanfFormatWidth_smaller]

The buffer size could probably be reduced. It won't make much difference,
since there are much larger variables nearby.

2.

trunk.git/gcc/config/i386/i386-options.c:1092:12: style: Local variable 'ret'
shadows outer variable [shadowVariable]
trunk.git/gcc/config/i386/i386-options.c:918:8: note: Shadowed declaration
trunk.git/gcc/config/i386/i386-options.c:1092:12: note: Shadow variable

3.

trunk.git/gcc/config/i386/i386-options.c:2856:26: style: Local variable 'i'
shadows outer variable [shadowVariable]
trunk.git/gcc/config/i386/i386-options.c:1786:7: note: Shadowed declaration
trunk.git/gcc/config/i386/i386-options.c:2856:26: note: Shadow variable

[Bug target/98671] gcc/config/i386/i386-options.c:787:redundantAssignment

2021-01-14 Thread ubizjak at gmail dot com via Gcc-bugs 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98671

Uroš Bizjak  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1
   Last reconfirmed||2021-01-14
   Assignee|unassigned at gcc dot gnu.org  |ubizjak at gmail dot com
   Target Milestone|--- |11.0

--- Comment #2 from Uroš Bizjak  ---
Let me fix this.

[Bug target/98671] gcc/config/i386/i386-options.c:787:redundantAssignment

2021-01-14 Thread crazylht at gmail dot com via Gcc-bugs 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98671

--- Comment #1 from Hongtao.liu  ---
Seems so.