https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108160
Bug ID: 108160
Summary: gcc.dg/format/ms_attr-3.c testsuite failure, missed
update from r9-4163-g1d24950977c730
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: testsuite
Assignee: unassigned at gcc dot gnu.org
Reporter: nightstrike at gmail dot com
Target Milestone: ---
Created attachment 54120
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54120&action=edit
Suggested changes
r9-4163-g1d24950977c730 changed the output of certain messages and adjusted the
non-ms-printf cases, but missed the windows version of attr-3.c.
FAIL: gcc.dg/format/ms_attr-3.c bad number (test for errors, line 44)
FAIL: gcc.dg/format/ms_attr-3.c bad number (test for errors, line 45)
FAIL: gcc.dg/format/ms_attr-3.c bad format_arg number (test for errors, line
47)
FAIL: gcc.dg/format/ms_attr-3.c format int string (test for errors, line 59)
FAIL: gcc.dg/format/ms_attr-3.c signed char string (test for errors, line
60)
FAIL: gcc.dg/format/ms_attr-3.c unsigned char string (test for errors, line
61)
FAIL: gcc.dg/format/ms_attr-3.c not ... (test for errors, line 63)
FAIL: gcc.dg/format/ms_attr-3.c format_arg int string (test for errors, line
66)
FAIL: gcc.dg/format/ms_attr-3.c format_arg signed char string (test for
errors, line 67)
FAIL: gcc.dg/format/ms_attr-3.c format_arg unsigned char string (test for
errors, line 68)
FAIL: gcc.dg/format/ms_attr-3.c (test for excess errors)
Excess errors:
gcc.dg/format/ms_attr-3.c:44:1: warning: 'format' attribute argument 2 value
'foo' is not an integer constant [-Wattributes]
gcc.dg/format/ms_attr-3.c:45:1: warning: 'format' attribute argument 3 value
'foo' is not an integer constant [-Wattributes]
gcc.dg/format/ms_attr-3.c:47:1: warning: 'format_arg' attribute argument value
'foo' is not an integer constant [-Wattributes]
gcc.dg/format/ms_attr-3.c:59:1: error: 'format' attribute argument 2 value '1'
refers to parameter type 'int'
gcc.dg/format/ms_attr-3.c:60:1: error: 'format' attribute argument 2 value '1'
refers to parameter type 'signed char *'
gcc.dg/format/ms_attr-3.c:61:1: error: 'format' attribute argument 2 value '1'
refers to parameter type 'unsigned char *'
gcc.dg/format/ms_attr-3.c:63:1: error: 'format' attribute argument 3 value '2'
does not refer to a variable argument list
gcc.dg/format/ms_attr-3.c:66:1: error: 'format_arg' attribute argument value
'1' refers to parameter type 'int'
gcc.dg/format/ms_attr-3.c:67:1: error: 'format_arg' attribute argument value
'1' refers to parameter type 'signed char *'
gcc.dg/format/ms_attr-3.c:68:1: error: 'format_arg' attribute argument value
'1' refers to parameter type 'unsigned char *'
Applying the changes to attr-3.c directly to ms_attr-3.c isn't exactly right,
though. First, gnu_attr_printf needs to change to ms_printf. Second, there
are followup changes from r9-5404-g23db6ced33c245 to fix the remaining issues.
The resulting diff is a bit big, so I uploaded suggested changes as an
attachment.
