[Bug translation/90164] wrong tense in ABI change diagnostic

2021-10-27 Thread egallager at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90164

Eric Gallager  changed:

   What|Removed |Added

   Severity|normal  |trivial
   Keywords||easyhack
 Blocks||40883
 CC||egallager at gcc dot gnu.org


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=40883
[Bug 40883] [meta-bug] Translation breakage with trivial fixes

[Bug translation/90164] wrong tense in ABI change diagnostic

2019-04-19 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90164

--- Comment #3 from Martin Sebor  ---
Agreed.

[Bug translation/90164] wrong tense in ABI change diagnostic

2019-04-19 Thread roland.illig at gmx dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90164

--- Comment #2 from Roland Illig  ---
(In reply to Martin Sebor from comment #1)
> Confirmed.  There seems to be little consistency between "changes" and "has
> changed" -- it's 11 vs 6.

To me it looks completely consistent.

If something changed in the GCC history, it's "changed".

If something is changing in the current GCC major version (which GCC 8 was last
year), it's "changes". It's just that whoever wrote that code didn't remember
to update the word to "changed" after the release.

The other diagnostics refer to options that the GCC user can actively influence
at any time, therefore "changes" is appropriate.

In summary, it's really only this one "GCC 8 changed" that is inconsistent.

[Bug translation/90164] wrong tense in ABI change diagnostic

2019-04-18 Thread msebor at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90164

Martin Sebor  changed:

   What|Removed |Added

   Keywords||diagnostic
 Status|UNCONFIRMED |NEW
   Last reconfirmed||2019-04-19
 CC||msebor at gcc dot gnu.org
 Ever confirmed|0   |1

--- Comment #1 from Martin Sebor  ---
Confirmed.  There seems to be little consistency between "changes" and "has
changed" -- it's 11 vs 6.  But "has changed" seems more appropriate here
since/when it's still in effect in the current version.

$ grep " change[ds] " gcc/po/gcc.pot | grep ABI
msgid "AVX512F vector argument without AVX512F enabled changes the ABI"
msgid "AVX512F vector return without AVX512F enabled changes the ABI"
msgid "AVX vector argument without AVX enabled changes the ABI"
msgid "AVX vector return without AVX enabled changes the ABI"
msgid "SSE vector argument without SSE enabled changes the ABI"
msgid "SSE vector return without SSE enabled changes the ABI"
msgid "MMX vector argument without MMX enabled changes the ABI"
msgid "MMX vector return without MMX enabled changes the ABI"
"the ABI of passing struct with a flexible array member has changed in GCC 4.4"
msgid "the ABI of passing union with long double has changed in GCC 4.4"
"the ABI of passing structure with complex float member has changed in GCC 4.4"
"the ABI for passing parameters with %d-byte alignment has changed in GCC 4.6"
"empty class %qT parameter passing ABI changes in %<-fabi-version=12%> (GCC 8)"
msgid "target attribute or pragma changes AltiVec ABI"
msgid "target attribute or pragma changes darwin64 ABI"
"the ABI of passing aggregates with %d-byte alignment has changed in GCC 5"
msgid "the ABI of passing homogeneous float aggregates has changed in GCC 5"