[Bug tree-optimization/110420] [12/13 Regression] internal compiler error: in gimple_redirect_edge_and_branch due to simple_dce_from_worklist removing `asm goto`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 Andrew Pinski changed: What|Removed |Added Target Milestone|13.2|12.4 Resolution|--- |FIXED Status|ASSIGNED|RESOLVED Known to work||12.3.1, 13.1.1 --- Comment #12 from Andrew Pinski --- Fixed.
[Bug tree-optimization/110420] [12/13 Regression] internal compiler error: in gimple_redirect_edge_and_branch due to simple_dce_from_worklist removing `asm goto`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 --- Comment #11 from CVS Commits --- The releases/gcc-12 branch has been updated by Andrew Pinski : https://gcc.gnu.org/g:ee3bb7cb5d2ecfc64adcfd61afb390e72cc08661 commit r12-9732-gee3bb7cb5d2ecfc64adcfd61afb390e72cc08661 Author: Andrew Pinski Date: Mon Jun 26 17:14:06 2023 -0700 Mark asm goto with outputs as volatile The manual references asm goto as being implicitly volatile already and that was done when asm goto could not have outputs. When outputs were added to `asm goto`, only asm goto without outputs were still being marked as volatile. Now some parts of GCC decide, removing the `asm goto` is ok if the output is not used, though not updating the CFG (this happens on both the RTL level and the gimple level). Since the biggest user of `asm goto` is the Linux kernel and they expect them to be volatile (they use them to copy to/from userspace), we should just mark the inline-asm as volatile. OK? Bootstrapped and tested on x86_64-linux-gnu. PR middle-end/110420 PR middle-end/103979 PR middle-end/98619 gcc/ChangeLog: * gimplify.cc (gimplify_asm_expr): Mark asm with labels as volatile. gcc/testsuite/ChangeLog: * gcc.c-torture/compile/asmgoto-6.c: New test. (cherry picked from commit 478840a2ca491fbff44371caee4983d1e7b7b7cf)
[Bug tree-optimization/110420] [12/13 Regression] internal compiler error: in gimple_redirect_edge_and_branch due to simple_dce_from_worklist removing `asm goto`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 --- Comment #10 from CVS Commits --- The releases/gcc-13 branch has been updated by Andrew Pinski : https://gcc.gnu.org/g:81fa6dfe1691e93664ef3b4fa66c1e057acea281 commit r13-7484-g81fa6dfe1691e93664ef3b4fa66c1e057acea281 Author: Andrew Pinski Date: Mon Jun 26 17:14:06 2023 -0700 Mark asm goto with outputs as volatile The manual references asm goto as being implicitly volatile already and that was done when asm goto could not have outputs. When outputs were added to `asm goto`, only asm goto without outputs were still being marked as volatile. Now some parts of GCC decide, removing the `asm goto` is ok if the output is not used, though not updating the CFG (this happens on both the RTL level and the gimple level). Since the biggest user of `asm goto` is the Linux kernel and they expect them to be volatile (they use them to copy to/from userspace), we should just mark the inline-asm as volatile. OK? Bootstrapped and tested on x86_64-linux-gnu. PR middle-end/110420 PR middle-end/103979 PR middle-end/98619 gcc/ChangeLog: * gimplify.cc (gimplify_asm_expr): Mark asm with labels as volatile. gcc/testsuite/ChangeLog: * gcc.c-torture/compile/asmgoto-6.c: New test. (cherry picked from commit 478840a2ca491fbff44371caee4983d1e7b7b7cf)
[Bug tree-optimization/110420] [12/13 Regression] internal compiler error: in gimple_redirect_edge_and_branch due to simple_dce_from_worklist removing `asm goto`
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110420 Andrew Pinski changed: What|Removed |Added Summary|[12/13/14 Regression] |[12/13 Regression] internal |internal compiler error: in |compiler error: in |gimple_redirect_edge_and_br |gimple_redirect_edge_and_br |anch due to |anch due to |simple_dce_from_worklist|simple_dce_from_worklist |removing `asm goto` |removing `asm goto` Known to work||14.0 --- Comment #9 from Andrew Pinski --- Fixed in GCC 14 and will be backporting to GCC 12.x and 13.x.
