[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-02 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Richard Biener  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #14 from Richard Biener  ---
Fixed.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-02 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #13 from CVS Commits  ---
The master branch has been updated by Richard Biener :

https://gcc.gnu.org/g:c05f748218a0d556972212d6aecfce0eb4c8a31c

commit r14-5075-gc05f748218a0d556972212d6aecfce0eb4c8a31c
Author: Richard Biener 
Date:   Thu Nov 2 10:39:03 2023 +0100

tree-optimization/112320 - bougs debug IL after SCCP

The following addresses wrong debug IL created by SCCP rewriting stmts
to defined overflow.  I addressed another inefficiency there but
needed to adjust the API of rewrite_to_defined_overflow for this
which is now taking a stmt iterator for in-place operation and a
stmt for sequence producing because gsi_for_stmt doesn't work for
stmts not in the IL.

PR tree-optimization/112320
* gimple-fold.h (rewrite_to_defined_overflow): New overload
for in-place operation.
* gimple-fold.cc (rewrite_to_defined_overflow): Add stmt
iterator argument to worker, define separate API for
in-place and not in-place operation.
* tree-if-conv.cc (predicate_statements): Simplify.
* tree-scalar-evolution.cc (final_value_replacement_loop):
Likewise.
* tree-ssa-ifcombine.cc (pass_tree_ifcombine::execute): Adjust.
* tree-ssa-reassoc.cc (update_range_test): Likewise.

* gcc.dg/pr112320.c: New testcase.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-02 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #12 from Andrew Pinski  ---
*** Bug 112328 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-02 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #11 from Andrew Pinski  ---
*** Bug 112345 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-02 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Richard Biener  changed:

   What|Removed |Added

   Assignee|unassigned at gcc dot gnu.org  |rguenth at gcc dot 
gnu.org
 Status|NEW |ASSIGNED
Version|unknown |14.0
   Priority|P3  |P1

--- Comment #10 from Richard Biener  ---
Mine.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-01 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski  changed:

   What|Removed |Added

 CC||gerald at pfeifer dot com

--- Comment #9 from Andrew Pinski  ---
*** Bug 112343 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-01 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski  changed:

   What|Removed |Added

 CC||zhendong.su at inf dot ethz.ch

--- Comment #8 from Andrew Pinski  ---
*** Bug 112333 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-11-01 Thread dcb314 at hotmail dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #7 from David Binderman  ---
(In reply to Hans-Peter Nilsson from comment #4)
> What target?

Sorry, I should have mentioned x86_64. 

In my opinion, bugs in the middle end tend to occur on all targets.

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-10-31 Thread law at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

--- Comment #6 from Jeffrey A. Law  ---
Created attachment 56480
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56480=edit
Testcase for fr30-elf -Os -g

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-10-31 Thread law at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Jeffrey A. Law  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||law at gcc dot gnu.org
   Last reconfirmed||2023-11-01
 Ever confirmed|0   |1

--- Comment #5 from Jeffrey A. Law  ---
I've bisected a failure on fr30-elf to the same commit.  The failure mode is
different, but given it's the same commit, I'm attaching the testcase to this
BZ.

0xba6a67 phi_nodes_ptr(basic_block_def*)
/home/jlaw/test/gcc/gcc/gimple.h:4700
0xba6a67 gsi_start_phis(basic_block_def*)
/home/jlaw/test/gcc/gcc/gimple-iterator.cc:935
0xba6a67 gsi_for_stmt(gimple*)
/home/jlaw/test/gcc/gcc/gimple-iterator.cc:620
0xf477c1 replace_uses_by(tree_node*, tree_node*)
/home/jlaw/test/gcc/gcc/tree-cfg.cc:2055
0x111b731 clean_up_loop_closed_phi(function*)
/home/jlaw/test/gcc/gcc/tree-ssa-propagate.cc:1296
0xd23348 loop_optimizer_finalize(function*, bool)
/home/jlaw/test/gcc/gcc/loop-init.cc:146
0x10e1448 tree_ssa_loop_done
/home/jlaw/test/gcc/gcc/tree-ssa-loop.cc:478
0x10e1498 execute
/home/jlaw/test/gcc/gcc/tree-ssa-loop.cc:507

Compile with -Os -g

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-10-31 Thread hp at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Hans-Peter Nilsson  changed:

   What|Removed |Added

   Keywords||build
 CC||hp at gcc dot gnu.org
 Target||cris-elf

--- Comment #4 from Hans-Peter Nilsson  ---
What target?

Anyway, cris-elf too, where build of newlib fails.  (Same revision pin-pointed,
and the apparently-minimal posted test-case exposes the bug there too.  It
could theoretically be a different bug from the same commit, but I think
horses.)

[Bug tree-optimization/112320] [14 Regression] crash from insert_debug_temp_for_var_def since r14-5032-ge3da1d7bb288c8

2023-10-31 Thread pinskia at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112320

Andrew Pinski  changed:

   What|Removed |Added

 CC||slyfox at gcc dot gnu.org

--- Comment #3 from Andrew Pinski  ---
*** Bug 112321 has been marked as a duplicate of this bug. ***