[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #12 from spop at gcc dot gnu dot org 2010-02-11 19:42 --- Subject: Bug 42771 Author: spop Date: Thu Feb 11 19:42:38 2010 New Revision: 156711 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=156711 Log: Fix PR42771. 2010-02-10 Sebastian Pop s...@napoca PR middle-end/42771 * graphite-clast-to-gimple.c (gloog): Call rename_sese_parameters. * graphite-clast-to-gimple.h (gloog): Update declaration. * graphite-poly.c (new_scop): Clear POLY_SCOP_P. * graphite-poly.h (struct poly_bb): Add missing comments. (struct scop): Add poly_scop_p field. (POLY_SCOP_P): New. * graphite-sese-to-poly.c (build_poly_scop): Set POLY_SCOP_P. * graphite.c (graphite_transform_loops): Build the polyhedral representation for each scop before code generation. * sese.c (rename_variables_in_operand): Removed. (rename_variables_in_expr): Return the renamed expression. (rename_sese_parameters): New. * sese.h (rename_sese_parameters): Declared. * gcc.dg/graphite/pr42771.c: New. Added: trunk/gcc/testsuite/gcc.dg/graphite/pr42771.c Modified: trunk/gcc/ChangeLog.graphite trunk/gcc/graphite-clast-to-gimple.c trunk/gcc/graphite-clast-to-gimple.h trunk/gcc/graphite-poly.c trunk/gcc/graphite-poly.h trunk/gcc/graphite-sese-to-poly.c trunk/gcc/graphite.c trunk/gcc/sese.c trunk/gcc/sese.h -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #13 from spop at gcc dot gnu dot org 2010-02-11 19:46 --- Fixed. -- spop at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #8 from spop at gcc dot gnu dot org 2010-02-10 16:47 --- Subject: Bug 42771 Author: spop Date: Wed Feb 10 16:47:04 2010 New Revision: 156664 URL: http://gcc.gnu.org/viewcvs?root=gccview=revrev=156664 Log: Fix PR42771. 2010-02-10 Sebastian Pop s...@napoca PR middle-end/42771 * graphite-clast-to-gimple.c (gloog): Call rename_sese_parameters. * graphite-clast-to-gimple.h (gloog): Update declaration. * graphite-poly.c (new_scop): Clear POLY_SCOP_P. * graphite-poly.h (struct poly_bb): Add missing comments. (struct scop): Add poly_scop_p field. (POLY_SCOP_P): New. * graphite-sese-to-poly.c (build_poly_scop): Set POLY_SCOP_P. * graphite.c (graphite_transform_loops): Build the polyhedral representation for each scop before code generation. * sese.c (rename_variables_in_operand): Removed. (rename_variables_in_expr): Return the renamed expression. (rename_sese_parameters): New. * sese.h (rename_sese_parameters): Declared. * gcc.dg/graphite/pr42771.c: New. Added: branches/graphite/gcc/testsuite/gcc.dg/graphite/pr42771.c Modified: branches/graphite/gcc/ChangeLog.graphite branches/graphite/gcc/graphite-clast-to-gimple.c branches/graphite/gcc/graphite-clast-to-gimple.h branches/graphite/gcc/graphite-poly.c branches/graphite/gcc/graphite-poly.h branches/graphite/gcc/graphite-sese-to-poly.c branches/graphite/gcc/graphite.c branches/graphite/gcc/sese.c branches/graphite/gcc/sese.h -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #9 from spop at gcc dot gnu dot org 2010-02-10 17:03 --- Fixed as described in http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00436.html -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #10 from amonakov at gcc dot gnu dot org 2010-02-10 18:26 --- (In reply to comment #9) Fixed as described in http://gcc.gnu.org/ml/gcc-patches/2010-02/msg00436.html I don't see how this patch makes simple_iv call from number_of_iterations_exit return true for j_20. Could you please kindly explain? -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
Re: [Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
On Wed, Feb 10, 2010 at 12:26, amonakov at gcc dot gnu dot org gcc-bugzi...@gcc.gnu.org wrote: I don't see how this patch makes simple_iv call from number_of_iterations_exit return true for j_20. Could you please kindly explain? We used to analyze the second scop after the code generation of the first one. In that context, the scalar evolution analysis failed to analyze the code containing scalar computations stored and read from arrays with 1 element (introduced by the code generation and analysis part). We now analyze all the scops before code generating them: thus, we don't have to invalidate the scalar evolution hash tables between the analysis of two scops.
[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #11 from sebpop at gmail dot com 2010-02-11 00:29 --- Subject: Re: [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2) On Wed, Feb 10, 2010 at 12:26, amonakov at gcc dot gnu dot org gcc-bugzi...@gcc.gnu.org wrote: I don't see how this patch makes simple_iv call from number_of_iterations_exit return true for j_20. Could you please kindly explain? We used to analyze the second scop after the code generation of the first one. In that context, the scalar evolution analysis failed to analyze the code containing scalar computations stored and read from arrays with 1 element (introduced by the code generation and analysis part). We now analyze all the scops before code generating them: thus, we don't have to invalidate the scalar evolution hash tables between the analysis of two scops. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
[Bug tree-optimization/42771] [4.5 Regression][graphite] ICE: in graphite_loop_normal_form, at graphite-sese-to-poly.c (2)
--- Comment #7 from spop at gcc dot gnu dot org 2010-02-07 07:52 --- Mine. -- spop at gcc dot gnu dot org changed: What|Removed |Added AssignedTo|unassigned at gcc dot gnu |spop at gcc dot gnu dot org |dot org | Status|NEW |ASSIGNED Last reconfirmed|2010-01-16 22:36:03 |2010-02-07 07:52:02 date|| http://gcc.gnu.org/bugzilla/show_bug.cgi?id=42771
