[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-24 Thread sje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

--- Comment #21 from Steve Ellcey  ---
(In reply to Richard Biener from comment #20)
> (In reply to Steve Ellcey from comment #19)
> It should have been fixed by r273732 (checked with a cc1 cross to aarch64,
> albeit on a not clean tree...)

OK, I rested with top-of-tree that includes this patch and the tests
are not failing for me now.  My earlier testing did not have this patch
in it.

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-24 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

--- Comment #20 from Richard Biener  ---
(In reply to Steve Ellcey from comment #19)
> Should this defect be reopened?  One of the tests that was added is failing
> for me on aarch64.
> 
> FAIL: g++.dg/tree-ssa/pr83518.C  -std=gnu++98  scan-tree-dump optimized
> "return 15;"
> FAIL: g++.dg/tree-ssa/pr83518.C  -std=gnu++14  scan-tree-dump optimized
> "return 15;"
> FAIL: g++.dg/tree-ssa/pr83518.C  -std=gnu++17  scan-tree-dump optimized
> "return 15;"

It should have been fixed by r273732 (checked with a cc1 cross to aarch64,
albeit on a not clean tree...)

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-23 Thread sje at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

Steve Ellcey  changed:

   What|Removed |Added

 CC||sje at gcc dot gnu.org

--- Comment #19 from Steve Ellcey  ---
Should this defect be reopened?  One of the tests that was added is failing for
me on aarch64.

FAIL: g++.dg/tree-ssa/pr83518.C  -std=gnu++98  scan-tree-dump optimized "return
15;"
FAIL: g++.dg/tree-ssa/pr83518.C  -std=gnu++14  scan-tree-dump optimized "return
15;"
FAIL: g++.dg/tree-ssa/pr83518.C  -std=gnu++17  scan-tree-dump optimized "return
15;"

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-23 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

Richard Biener  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Richard Biener  ---
Fixed.

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-23 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

--- Comment #18 from Richard Biener  ---
Author: rguenth
Date: Tue Jul 23 10:00:24 2019
New Revision: 273732

URL: https://gcc.gnu.org/viewcvs?rev=273732=gcc=rev
Log:
2019-07-23  Richard Biener  

PR tree-optimization/83518
* tree-ssa-sccvn.c (vn_reference_lookup_3): Handle aggregate
init from a constant even when partial defs are already recorded.

c/
* gimple-parser.c (c_parser_parse_gimple_body): When we have
a CFG also rebuild cgraph edges.

* gcc.dg/tree-ssa/ssa-fre-79.c: New testcase.

Added:
trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-79.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/c/ChangeLog
trunk/gcc/c/gimple-parser.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-ssa-sccvn.c

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-16 Thread wilco at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

Wilco  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #16 from Wilco  ---
Reopen since it still fails on AArch64.

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-09 Thread wilco at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

--- Comment #15 from Wilco  ---
(In reply to Richard Biener from comment #14)
> Yeah.  It is
> 
>[local count: 178992762]:
>   arr = *.LC0;
>   arr[0] = 5;
>   vect__56.15_75 = MEM  [(int *)];
> 
> I'll fix that (well, I'll try).

Right, it's fine with -fno-tree-vectorize on AArch64.

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-09 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

--- Comment #14 from Richard Biener  ---
Yeah.  It is

   [local count: 178992762]:
  arr = *.LC0;
  arr[0] = 5;
  vect__56.15_75 = MEM  [(int *)];

I'll fix that (well, I'll try).

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-09 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

--- Comment #13 from rguenther at suse dot de  ---
On Tue, 9 Jul 2019, wilco at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518
> 
> Wilco  changed:
> 
>What|Removed |Added
> 
>  CC||wilco at gcc dot gnu.org
> 
> --- Comment #12 from Wilco  ---
> (In reply to Richard Biener from comment #11)
> > Fixed on trunk, not something for backporting.
> 
> The pr83518.C test fails on AArch64 and Arm (and presumably more targets). Are
> you missing options or relying on specific vector widths?

I'm not relying on vectorization (it passes for me with 
-fno-tree-vectorize).  But I'm relying on unrolling.  And also on
constant folding - maybe this is the usual

 arr[0] = 5;
 arr[1] = 4;
...

vs.

 arr = .LC0;

thing?

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-09 Thread wilco at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

Wilco  changed:

   What|Removed |Added

 CC||wilco at gcc dot gnu.org

--- Comment #12 from Wilco  ---
(In reply to Richard Biener from comment #11)
> Fixed on trunk, not something for backporting.

The pr83518.C test fails on AArch64 and Arm (and presumably more targets). Are
you missing options or relying on specific vector widths?

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-07-08 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

Richard Biener  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Known to work||10.0
 Resolution|--- |FIXED
Summary|[8/9/10 Regression] Missing |[8/9 Regression] Missing
   |optimization: useless   |optimization: useless
   |instructions should be  |instructions should be
   |dropped |dropped
  Known to fail||8.3.0, 9.1.0

--- Comment #11 from Richard Biener  ---
Fixed on trunk, not something for backporting.

[Bug tree-optimization/83518] [8/9 Regression] Missing optimization: useless instructions should be dropped

2019-02-05 Thread law at redhat dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83518

Jeffrey A. Law  changed:

   What|Removed |Added

 CC||law at redhat dot com
   Target Milestone|9.0 |10.0