Re: [PATCH] nvptx: Fix up nvptx build against latest libstdc++ [PR100375]

[tdevries]

On 2021-05-02 10:52, Jakub Jelinek wrote:

Hi!

The r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac change
deprecated some non-standard std::pair constructors and that apparently
broke nvptx.c build, where pseudo_node_t is std::pair
and so nullptr (or NULL) needs to be used for the first argument of the
ctors instead of 0.

Tested in x86_64-linux -> nvptx-none cross with CC/CXX latest trunk 
gcc,

ok for trunk?



Hi Jakub,

thanks for taking care of this, LGTM, please apply.

Thanks,
- Tom


2021-05-02  Jakub Jelinek  

PR target/100375
* config/nvptx/nvptx.c (nvptx_sese_pseudo): Use nullptr instead of 0
as first argument of pseudo_node_t constructors.

--- gcc/config/nvptx/nvptx.c.jj 2021-02-10 23:08:50.487460416 +0100
+++ gcc/config/nvptx/nvptx.c2021-05-02 10:39:45.803670287 +0200
@@ -3682,9 +3682,9 @@ nvptx_sese_pseudo (basic_block me, bb_se
   edge e;
   edge_iterator ei;
   int hi_back = depth;
-  pseudo_node_t node_back (0, depth);
+  pseudo_node_t node_back (nullptr, depth);
   int hi_child = depth;
-  pseudo_node_t node_child (0, depth);
+  pseudo_node_t node_child (nullptr, depth);
   basic_block child = NULL;
   unsigned num_children = 0;
   int usd = -dir * sese->dir;
@@ -3751,7 +3751,7 @@ nvptx_sese_pseudo (basic_block me, bb_se
   else
{ /* Fallen off graph, backlink to entry node.  */
  hi_back = 0;
- node_back = pseudo_node_t (0, 0);
+ node_back = pseudo_node_t (nullptr, 0);
}
 }

@@ -3772,7 +3772,7 @@ nvptx_sese_pseudo (basic_block me, bb_se
   else
{
  /* back edge to entry node */
- sese->push (pseudo_node_t (0, 0));
+ sese->push (pseudo_node_t (nullptr, 0));
}
 }

@@ -3781,7 +3781,7 @@ nvptx_sese_pseudo (basic_block me, bb_se
   if (!sese->brackets.length () || !edges || !edges->length ())
 {
   hi_back = 0;
-  node_back = pseudo_node_t (0, 0);
+  node_back = pseudo_node_t (nullptr, 0);
   sese->push (node_back);
 }


Jakub

Re: [RFC][nvptx, libgomp] Add 128-bit atomic support

[tdevries]

On 2020-09-11 16:48, Andrew Stubbs wrote:

On 11/09/2020 15:25, Tom de Vries wrote:

--- a/libgomp/testsuite/libgomp.c-c++-common/reduction-16.c
+++ b/libgomp/testsuite/libgomp.c-c++-common/reduction-16.c

@@ -1,4 +1,5 @@

/*·{·dg-do·run·}·*/
+/*·{·dg-additional-options·"-foffload=-latomic"·}·*/


This will probably break amdgcn, where libatomic does not exist.



It looks like the customary way to handle that is to use 
offload_target_nvptx.


Thanks,
- Tom

[MAINTAINERS, committed] Update email address

[tdevries]

Hi,

I've updated my email address in the MAINTAINERS file.

Thanks,
- Tom

[MAINTAINERS] Update email address

2018-06-01  Tom de Vries  

* MAINTAINERS: Update my email address.

---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5ffbbdf..c72b200 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -88,7 +88,7 @@ nds32 portChung-Ju Wu 

 nds32 port Shiva Chen  
 nios2 port Chung-Lin Tang  
 nios2 port Sandra Loosemore
-nvptx port Tom de Vries
+nvptx port Tom de Vries
 pdp11 port Paul Koning 
 powerpcspe portAndrew Jenner   

 riscv port Kito Cheng  
@@ -623,7 +623,7 @@ Ilya Verbin 

 Andre Vieira   
 Kugan Vivekanandarajah 
 Ville Voutilainen  
-Tom de Vries   
+Tom de Vries   
 Nenad Vukicevic
 Feng Wang  
 Jiong Wang