Re: [ARM/FDPIC v5 17/21] [ARM][testsuite] FDPIC: Handle *-*-uclinux*
On Jul 19, 2019, at 1:56 AM, Kyrill Tkachov wrote: > > On 5/15/19 1:39 PM, Christophe Lyon wrote: >> Add *-*-uclinux* to tests that work on this target. >> >> 2019-XX-XX Christophe Lyon >> >> gcc/testsuite/ >> * g++.dg/abi/forced.C: Add *-*-uclinux*. >> * g++.dg/abi/guard2.C: Likewise. >> * g++.dg/ext/cleanup-10.C: Likewise. >> * g++.dg/ext/cleanup-11.C: Likewise. >> * g++.dg/ext/cleanup-8.C: Likewise. >> * g++.dg/ext/cleanup-9.C: Likewise. >> * g++.dg/ext/sync-4.C: Likewise. >> * g++.dg/ipa/comdat.C: Likewise. >> * gcc.dg/20041106-1.c: Likewise. >> * gcc.dg/cleanup-10.c: Likewise. >> * gcc.dg/cleanup-11.c: Likewise. >> * gcc.dg/cleanup-8.c: Likewise. >> * gcc.dg/cleanup-9.c: Likewise. >> * gcc.dg/fdata-sections-1.c: Likewise. >> * gcc.dg/fdata-sections-2.c: Likewise. >> * gcc.dg/pr39323-1.c: Likewise. >> * gcc.dg/pr39323-2.c: Likewise. >> * gcc.dg/pr39323-3.c: Likewise. >> * gcc.dg/pr65780-1.c: Likewise. >> * gcc.dg/pr65780-2.c: Likewise. >> * gcc.dg/pr67338.c: Likewise. >> * gcc.dg/pr78185.c: Likewise. >> * gcc.dg/pr83100-1.c: Likewise. >> * gcc.dg/pr83100-4.c: Likewise. >> * gcc.dg/strlenopt-12g.c: Likewise. >> * gcc.dg/strlenopt-14g.c: Likewise. >> * gcc.dg/strlenopt-14gf.c: Likewise. >> * gcc.dg/strlenopt-16g.c: Likewise. >> * gcc.dg/strlenopt-17g.c: Likewise. >> * gcc.dg/strlenopt-18g.c: Likewise. >> * gcc.dg/strlenopt-1f.c: Likewise. >> * gcc.dg/strlenopt-22g.c: Likewise. >> * gcc.dg/strlenopt-2f.c: Likewise. >> * gcc.dg/strlenopt-31g.c: Likewise. >> * gcc.dg/strlenopt-33g.c: Likewise. >> * gcc.dg/strlenopt-4g.c: Likewise. >> * gcc.dg/strlenopt-4gf.c: Likewise. >> * gcc.dg/strncmp-2.c: Likewise. >> * gcc.dg/struct-ret-3.c: Likewise. >> * gcc.dg/torture/pr69760.c: Likewise. >> * gcc.target/arm/div64-unwinding.c: Likewise. >> * gcc.target/arm/stack-checking.c: Likewise. >> * gcc.target/arm/synchronize.c: Likewise. >> * gcc.target/arm/pr66912.c: Add arm*-*-uclinuxfdpiceabi. >> * lib/target-supports.exp (check_effective_target_pie): Likewise. >> (check_effective_target_sync_long_long_runtime): Likewise. >> (check_effective_target_sync_int_long): Likewise. >> (check_effective_target_sync_char_short): Likewise. >> > I think these are ok, but you're changing many generic test targets. > > Are the testsuite maintainers ok with this change? Yes. The patch is approved. I looked them all over, they look fine. For these sorts of target changes, the target maintainers can just approve the usual and customary changes to the test suite. People can always ask for review for any reason they want, but as people skill up on usual and customary, the target maintains usually do a good job in this area. This patch to me seems usual and customary. >> Change-Id: I89bfea79d4490c5df0b6470def5a31d7f31ac2cc >> >> diff --git a/gcc/testsuite/g++.dg/abi/forced.C >> b/gcc/testsuite/g++.dg/abi/forced.C >> index 0e6be28..2d1ec53 100644 >> --- a/gcc/testsuite/g++.dg/abi/forced.C >> +++ b/gcc/testsuite/g++.dg/abi/forced.C >> @@ -1,4 +1,4 @@ >> -// { dg-do run { target *-*-linux* *-*-gnu* } } >> +// { dg-do run { target *-*-linux* *-*-gnu* *-*-uclinux* } } >> // { dg-options "-pthread" } >> >> #include >> diff --git a/gcc/testsuite/g++.dg/abi/guard2.C >> b/gcc/testsuite/g++.dg/abi/guard2.C >> index c35fa7e..74139a8 100644 >> --- a/gcc/testsuite/g++.dg/abi/guard2.C >> +++ b/gcc/testsuite/g++.dg/abi/guard2.C >> @@ -1,6 +1,6 @@ >> // PR c++/41611 >> // Test that the guard gets its own COMDAT group. >> -// { dg-final { scan-assembler "_ZGVZN1A1fEvE1i,comdat" { target *-*-linux* >> *-*-gnu* } } } >> +// { dg-final { scan-assembler "_ZGVZN1A1fEvE1i,comdat" { target *-*-linux* >> *-*-gnu* *-*-uclinux* } } } >> >> struct A { >>static int f() >> diff --git a/gcc/testsuite/g++.dg/ext/cleanup-10.C >> b/gcc/testsuite/g++.dg/ext/cleanup-10.C >> index 66c7b76..56aeb66 100644 >> --- a/gcc/testsuite/g++.dg/ext/cleanup-10.C >> +++ b/gcc/testsuite/g++.dg/ext/cleanup-10.C >> @@ -1,4 +1,4 @@ >> -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* >> powerpc*-*-darwin* *-*-darwin[912]* } } */ >> +/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* >> powerpc*-*-darwin* *-*-darwin[912]* *-*-uclinux* } } */ >> /* { dg-options "-fexceptions -fnon-call-exceptions -O2" } */ >> /* Verify that cleanups work with exception handling through signal frames >> on alternate stack. */ >> diff --git a/gcc/testsuite/g++.dg/ext/cleanup-11.C >> b/gcc/testsuite/g++.dg/ext/cleanup-11.C >> index 6e96521..c6d3560 100644 >> --- a/gcc/testsuite/g++.dg/ext/cleanup-11.C >> +++ b/gcc/testsuite/g++.dg/ext/cleanup-11.C >> @@ -1,4 +1,4 @@
Re: [ARM/FDPIC v5 17/21] [ARM][testsuite] FDPIC: Handle *-*-uclinux*
On 5/15/19 1:39 PM, Christophe Lyon wrote: Add *-*-uclinux* to tests that work on this target. 2019-XX-XX Christophe Lyon gcc/testsuite/ * g++.dg/abi/forced.C: Add *-*-uclinux*. * g++.dg/abi/guard2.C: Likewise. * g++.dg/ext/cleanup-10.C: Likewise. * g++.dg/ext/cleanup-11.C: Likewise. * g++.dg/ext/cleanup-8.C: Likewise. * g++.dg/ext/cleanup-9.C: Likewise. * g++.dg/ext/sync-4.C: Likewise. * g++.dg/ipa/comdat.C: Likewise. * gcc.dg/20041106-1.c: Likewise. * gcc.dg/cleanup-10.c: Likewise. * gcc.dg/cleanup-11.c: Likewise. * gcc.dg/cleanup-8.c: Likewise. * gcc.dg/cleanup-9.c: Likewise. * gcc.dg/fdata-sections-1.c: Likewise. * gcc.dg/fdata-sections-2.c: Likewise. * gcc.dg/pr39323-1.c: Likewise. * gcc.dg/pr39323-2.c: Likewise. * gcc.dg/pr39323-3.c: Likewise. * gcc.dg/pr65780-1.c: Likewise. * gcc.dg/pr65780-2.c: Likewise. * gcc.dg/pr67338.c: Likewise. * gcc.dg/pr78185.c: Likewise. * gcc.dg/pr83100-1.c: Likewise. * gcc.dg/pr83100-4.c: Likewise. * gcc.dg/strlenopt-12g.c: Likewise. * gcc.dg/strlenopt-14g.c: Likewise. * gcc.dg/strlenopt-14gf.c: Likewise. * gcc.dg/strlenopt-16g.c: Likewise. * gcc.dg/strlenopt-17g.c: Likewise. * gcc.dg/strlenopt-18g.c: Likewise. * gcc.dg/strlenopt-1f.c: Likewise. * gcc.dg/strlenopt-22g.c: Likewise. * gcc.dg/strlenopt-2f.c: Likewise. * gcc.dg/strlenopt-31g.c: Likewise. * gcc.dg/strlenopt-33g.c: Likewise. * gcc.dg/strlenopt-4g.c: Likewise. * gcc.dg/strlenopt-4gf.c: Likewise. * gcc.dg/strncmp-2.c: Likewise. * gcc.dg/struct-ret-3.c: Likewise. * gcc.dg/torture/pr69760.c: Likewise. * gcc.target/arm/div64-unwinding.c: Likewise. * gcc.target/arm/stack-checking.c: Likewise. * gcc.target/arm/synchronize.c: Likewise. * gcc.target/arm/pr66912.c: Add arm*-*-uclinuxfdpiceabi. * lib/target-supports.exp (check_effective_target_pie): Likewise. (check_effective_target_sync_long_long_runtime): Likewise. (check_effective_target_sync_int_long): Likewise. (check_effective_target_sync_char_short): Likewise. I think these are ok, but you're changing many generic test targets. Are the testsuite maintainers ok with this change? Thanks, Kyrill Change-Id: I89bfea79d4490c5df0b6470def5a31d7f31ac2cc diff --git a/gcc/testsuite/g++.dg/abi/forced.C b/gcc/testsuite/g++.dg/abi/forced.C index 0e6be28..2d1ec53 100644 --- a/gcc/testsuite/g++.dg/abi/forced.C +++ b/gcc/testsuite/g++.dg/abi/forced.C @@ -1,4 +1,4 @@ -// { dg-do run { target *-*-linux* *-*-gnu* } } +// { dg-do run { target *-*-linux* *-*-gnu* *-*-uclinux* } } // { dg-options "-pthread" } #include diff --git a/gcc/testsuite/g++.dg/abi/guard2.C b/gcc/testsuite/g++.dg/abi/guard2.C index c35fa7e..74139a8 100644 --- a/gcc/testsuite/g++.dg/abi/guard2.C +++ b/gcc/testsuite/g++.dg/abi/guard2.C @@ -1,6 +1,6 @@ // PR c++/41611 // Test that the guard gets its own COMDAT group. -// { dg-final { scan-assembler "_ZGVZN1A1fEvE1i,comdat" { target *-*-linux* *-*-gnu* } } } +// { dg-final { scan-assembler "_ZGVZN1A1fEvE1i,comdat" { target *-*-linux* *-*-gnu* *-*-uclinux* } } } struct A { static int f() diff --git a/gcc/testsuite/g++.dg/ext/cleanup-10.C b/gcc/testsuite/g++.dg/ext/cleanup-10.C index 66c7b76..56aeb66 100644 --- a/gcc/testsuite/g++.dg/ext/cleanup-10.C +++ b/gcc/testsuite/g++.dg/ext/cleanup-10.C @@ -1,4 +1,4 @@ -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* } } */ +/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* *-*-uclinux* } } */ /* { dg-options "-fexceptions -fnon-call-exceptions -O2" } */ /* Verify that cleanups work with exception handling through signal frames on alternate stack. */ diff --git a/gcc/testsuite/g++.dg/ext/cleanup-11.C b/gcc/testsuite/g++.dg/ext/cleanup-11.C index 6e96521..c6d3560 100644 --- a/gcc/testsuite/g++.dg/ext/cleanup-11.C +++ b/gcc/testsuite/g++.dg/ext/cleanup-11.C @@ -1,4 +1,4 @@ -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* } } */ +/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* *-*-uclinux* } } */ /* { dg-options "-fexceptions -fnon-call-exceptions -O2" } */ /* Verify that cleanups work with exception handling through realtime signal frames on alternate stack. */ diff --git a/gcc/testsuite/g++.dg/ext/cleanup-8.C b/gcc/testsuite/g++.dg/ext/cleanup-8.C index ccf9bef..e99508d 100644 --- a/gcc/testsuite/g++.dg/ext/cleanup-8.C +++ b/gcc/testsuite/g++.dg/ext/cleanup-8.C @@ -1,4 +1,4 @@ -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* } } */ +/* { dg-do run { target
[ARM/FDPIC v5 17/21] [ARM][testsuite] FDPIC: Handle *-*-uclinux*
Add *-*-uclinux* to tests that work on this target. 2019-XX-XX Christophe Lyon gcc/testsuite/ * g++.dg/abi/forced.C: Add *-*-uclinux*. * g++.dg/abi/guard2.C: Likewise. * g++.dg/ext/cleanup-10.C: Likewise. * g++.dg/ext/cleanup-11.C: Likewise. * g++.dg/ext/cleanup-8.C: Likewise. * g++.dg/ext/cleanup-9.C: Likewise. * g++.dg/ext/sync-4.C: Likewise. * g++.dg/ipa/comdat.C: Likewise. * gcc.dg/20041106-1.c: Likewise. * gcc.dg/cleanup-10.c: Likewise. * gcc.dg/cleanup-11.c: Likewise. * gcc.dg/cleanup-8.c: Likewise. * gcc.dg/cleanup-9.c: Likewise. * gcc.dg/fdata-sections-1.c: Likewise. * gcc.dg/fdata-sections-2.c: Likewise. * gcc.dg/pr39323-1.c: Likewise. * gcc.dg/pr39323-2.c: Likewise. * gcc.dg/pr39323-3.c: Likewise. * gcc.dg/pr65780-1.c: Likewise. * gcc.dg/pr65780-2.c: Likewise. * gcc.dg/pr67338.c: Likewise. * gcc.dg/pr78185.c: Likewise. * gcc.dg/pr83100-1.c: Likewise. * gcc.dg/pr83100-4.c: Likewise. * gcc.dg/strlenopt-12g.c: Likewise. * gcc.dg/strlenopt-14g.c: Likewise. * gcc.dg/strlenopt-14gf.c: Likewise. * gcc.dg/strlenopt-16g.c: Likewise. * gcc.dg/strlenopt-17g.c: Likewise. * gcc.dg/strlenopt-18g.c: Likewise. * gcc.dg/strlenopt-1f.c: Likewise. * gcc.dg/strlenopt-22g.c: Likewise. * gcc.dg/strlenopt-2f.c: Likewise. * gcc.dg/strlenopt-31g.c: Likewise. * gcc.dg/strlenopt-33g.c: Likewise. * gcc.dg/strlenopt-4g.c: Likewise. * gcc.dg/strlenopt-4gf.c: Likewise. * gcc.dg/strncmp-2.c: Likewise. * gcc.dg/struct-ret-3.c: Likewise. * gcc.dg/torture/pr69760.c: Likewise. * gcc.target/arm/div64-unwinding.c: Likewise. * gcc.target/arm/stack-checking.c: Likewise. * gcc.target/arm/synchronize.c: Likewise. * gcc.target/arm/pr66912.c: Add arm*-*-uclinuxfdpiceabi. * lib/target-supports.exp (check_effective_target_pie): Likewise. (check_effective_target_sync_long_long_runtime): Likewise. (check_effective_target_sync_int_long): Likewise. (check_effective_target_sync_char_short): Likewise. Change-Id: I89bfea79d4490c5df0b6470def5a31d7f31ac2cc diff --git a/gcc/testsuite/g++.dg/abi/forced.C b/gcc/testsuite/g++.dg/abi/forced.C index 0e6be28..2d1ec53 100644 --- a/gcc/testsuite/g++.dg/abi/forced.C +++ b/gcc/testsuite/g++.dg/abi/forced.C @@ -1,4 +1,4 @@ -// { dg-do run { target *-*-linux* *-*-gnu* } } +// { dg-do run { target *-*-linux* *-*-gnu* *-*-uclinux* } } // { dg-options "-pthread" } #include diff --git a/gcc/testsuite/g++.dg/abi/guard2.C b/gcc/testsuite/g++.dg/abi/guard2.C index c35fa7e..74139a8 100644 --- a/gcc/testsuite/g++.dg/abi/guard2.C +++ b/gcc/testsuite/g++.dg/abi/guard2.C @@ -1,6 +1,6 @@ // PR c++/41611 // Test that the guard gets its own COMDAT group. -// { dg-final { scan-assembler "_ZGVZN1A1fEvE1i,comdat" { target *-*-linux* *-*-gnu* } } } +// { dg-final { scan-assembler "_ZGVZN1A1fEvE1i,comdat" { target *-*-linux* *-*-gnu* *-*-uclinux* } } } struct A { static int f() diff --git a/gcc/testsuite/g++.dg/ext/cleanup-10.C b/gcc/testsuite/g++.dg/ext/cleanup-10.C index 66c7b76..56aeb66 100644 --- a/gcc/testsuite/g++.dg/ext/cleanup-10.C +++ b/gcc/testsuite/g++.dg/ext/cleanup-10.C @@ -1,4 +1,4 @@ -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* } } */ +/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* *-*-uclinux* } } */ /* { dg-options "-fexceptions -fnon-call-exceptions -O2" } */ /* Verify that cleanups work with exception handling through signal frames on alternate stack. */ diff --git a/gcc/testsuite/g++.dg/ext/cleanup-11.C b/gcc/testsuite/g++.dg/ext/cleanup-11.C index 6e96521..c6d3560 100644 --- a/gcc/testsuite/g++.dg/ext/cleanup-11.C +++ b/gcc/testsuite/g++.dg/ext/cleanup-11.C @@ -1,4 +1,4 @@ -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* } } */ +/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* *-*-uclinux* } } */ /* { dg-options "-fexceptions -fnon-call-exceptions -O2" } */ /* Verify that cleanups work with exception handling through realtime signal frames on alternate stack. */ diff --git a/gcc/testsuite/g++.dg/ext/cleanup-8.C b/gcc/testsuite/g++.dg/ext/cleanup-8.C index ccf9bef..e99508d 100644 --- a/gcc/testsuite/g++.dg/ext/cleanup-8.C +++ b/gcc/testsuite/g++.dg/ext/cleanup-8.C @@ -1,4 +1,4 @@ -/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* } } */ +/* { dg-do run { target hppa*-*-hpux* *-*-linux* *-*-gnu* powerpc*-*-darwin* *-*-darwin[912]* *-*-uclinux* } } */ /* { dg-options "-fexceptions -fnon-call-exceptions -O2" } */ /* Verify that cleanups work with