On 4/28/23 10:40, Jeff Law wrote:
On 4/27/23 10:22, Patrick O'Neill wrote:
This change makes atomic stores strictly stronger than table A.6 of the
ISA manual. This mapping makes the overall patchset compatible with
table A.7 as well.
2023-04-27 Patrick O'Neill <patr...@rivosinc.com>
PR 89835
Should be "PR target/89835"
gcc/ChangeLog:
* config/riscv/sync.md:
Needs some text here :-)
I'm not objecting to this patch, but I think we've got an option
question about whether or not this approach is too expensive for
existing or soon arriving implementations.
If the decision on that topic is to just pay the cost, then this patch
is fine. If we decide to make compatibility optional to avoid the
additional cost, then this will need suitable adjustments.
Jeff
Acked in Patchworks meeting:
https://inbox.sourceware.org/gcc-patches/c53ac2b2-4edf-34c6-a935-3b31644c9...@rivosinc.com/
Updated changelog and committed:
PR target/89835
gcc/ChangeLog:
* config/riscv/sync.md (atomic_store<mode>): Use simple store
instruction in combination with fence(s).
gcc/testsuite/ChangeLog:
* gcc.target/riscv/pr89835.c: New test.
Patrick
