[Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section

2013-12-02 Thread Sterling Augustine 
The enclosed patch fixes a mismerge from google/gcc-4_7 to main. When
outputting a pubtype whose type has no skeleton section, it's DIE
offset should be from the comp_unit_die, instead of zero. Zero is
actually a place-holder for the end of the pubtypes.

Sterling

gcc/ChangeLog

2013-12-02 Sterling Augustine  saugust...@google.com

* dwarf2out.c (output_pubnames): Use comp_unit_die ()-die_offset
when there
isn't a skeleton die.


pubtypes-bug.tot-patch
Description: Binary data

Re: [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section

2013-12-02 Thread Cary Coutant 
 gcc/ChangeLog

 2013-12-02 Sterling Augustine  saugust...@google.com

 * dwarf2out.c (output_pubnames): Use comp_unit_die ()-die_offset
 when there
 isn't a skeleton die.

This is OK, but your patch also has a local change to contrib/mklog.
Please be careful not to commit that.

Thanks!

-cary

Re: [Dwarf Patch] Use offset into debug_info for pubtype name referring to pubtype section

2013-12-02 Thread Sterling Augustine 
On Mon, Dec 2, 2013 at 1:59 PM, Cary Coutant ccout...@google.com wrote:
 This is OK, but your patch also has a local change to contrib/mklog.
 Please be careful not to commit that.

Committed without the contrib/mklog portion.

Also committing on google/gcc-4_8 and google/main.