Re: [PATCH, M68K] Fix ICE from scheduler improvement

2012-09-05 Thread Andreas Schwab 
Maxim Kuvyrkov ma...@codesourcery.com writes:

 No.  This hunk makes m68k scheduling support pick up the new state.

Can you reformulate the comment to clarify that?  Ok with that change.

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.

Re: [PATCH, M68K] Fix ICE from scheduler improvement

2012-09-04 Thread Andreas Schwab 
Maxim Kuvyrkov maxim_kuvyr...@mentor.com writes:

 2012-09-03  Maxim Kuvyrkov  ma...@codesourcery.com

   * config/m68k/m68k.c (m68k_sched_dfa_post_advance_cycle): Fix ICE
   caused by save scheduler state patch.

The change log entry should describe what was changed.  Save scheduler
state doesn't say anything to me.

 + {
 +   /* The instruction buffer appears to be more filled than we
 +  anticipated.  We should have inheritted the state from

s/inheritted/inherited/

 +  the previous basic block.  Adjust buffer counter.  */
 +   ++sched_ib.filled;
 + }

The comment appears to suggest that this is rather a workaround for a
deficiency elsewhere.  Is that true?

Andreas.

-- 
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
And now for something completely different.

Re: [PATCH, M68K] Fix ICE from scheduler improvement

2012-09-04 Thread Maxim Kuvyrkov 
On 4/09/2012, at 7:57 PM, Andreas Schwab wrote:

 Maxim Kuvyrkov maxim_kuvyr...@mentor.com writes:
 
 2012-09-03  Maxim Kuvyrkov  ma...@codesourcery.com
 
  * config/m68k/m68k.c (m68k_sched_dfa_post_advance_cycle): Fix ICE
  caused by save scheduler state patch.
 
 The change log entry should describe what was changed.  Save scheduler
 state doesn't say anything to me.

This should be Support starting scheduling from a pre-existing state.

 
 +{
 +  /* The instruction buffer appears to be more filled than we
 + anticipated.  We should have inheritted the state from
 
 s/inheritted/inherited/

OK.

 
 + the previous basic block.  Adjust buffer counter.  */
 +  ++sched_ib.filled;
 +}
 
 The comment appears to suggest that this is rather a workaround for a
 deficiency elsewhere.  Is that true?

No.  This hunk makes m68k scheduling support pick up the new state.

Thank you,

--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics

[PATCH, M68K] Fix ICE from scheduler improvement

2012-09-03 Thread Maxim Kuvyrkov 
Andreas,

This patch updates scheduling support for m68k to handle propagation of 
scheduler automaton states between basic blocks that Bernd checked in a couple 
of weeks ago.  Currently m68k build fails on an assert that checks that basic 
block starts with a clean scheduler state, which no longer holds true.

Tested by building a ColdFire toolchain.  OK to apply?

Thank you,

--
Maxim Kuvyrkov
Mentor Graphics




gcc-m68k-sched_ib.ChangeLog
Description: Binary data


gcc-m68k-sched_ib.patch
Description: Binary data