Re: [PATCH, rs6000] Backport Fix implementation of vec_packsu (vector unsigned long long, vector unsigned long long) built-in function

[Segher Boessenkool]

On Fri, Jun 22, 2018 at 08:30:12AM -0500, Kelvin Nilsen wrote:
> This has been committed to trunk.
> 
> Is this ok to backport to gcc6, gcc7, and gcc8?

Yes, but wait a few days please.  Thanks!


Segher

Re: [PATCH, rs6000] Backport Fix implementation of vec_packsu (vector unsigned long long, vector unsigned long long) built-in function

[Kelvin Nilsen]

This has been committed to trunk.

Is this ok to backport to gcc6, gcc7, and gcc8?

Thanks.

On 6/19/18 2:30 PM, Segher Boessenkool wrote:
> Hi!
> 
> On Mon, Jun 18, 2018 at 11:29:55AM -0500, Kelvin Nilsen wrote:
>> +/* A single vpkudus matches twice because this is compiled with -dp,
>> +   causing diagnostic comments to appear in the resulting .s file, one
>> +   of which matches vpkudus.  */
> 
> -dp prints the name of the instruction pattern, which is altivec_vpkudus.
> So if you look for the full word instead, this problem isn't there I
> think?
> 
>> +/* { dg-final { scan-assembler-times "vpkudus" 2 } } */
> 
> /* { dg-final { scan-assembler-times {\mvpkudus\M} 1 } } */
> 
> Okay with that change (and comment changes).  Thanks!
> 
> 
> Segher
> 
>