Re: [PATCH] Fix build with ISL 0.20
On 09/26/2018 07:46 AM, Jeff Law wrote: On 9/26/18 8:43 AM, Richard Biener wrote: On Wed, Sep 26, 2018 at 4:10 PM Jeff Law wrote: On 9/25/18 1:07 PM, Alexey Neyman wrote: Hi, A trivial patch that fixes the build against the latest ISL release, 0.20. In that release, and were split in two headers each. The (included from which is included by "graphite.h") now includes and ; and must be included explicitly. These headers ( and ) are present in all supported versions of ISL (0.15 and later). Bootstrapped on x86_64-pc-linux-gnu. Thanks for verifying these are in ISL 0.15 and later -- we recommend 0.18 these days, so I think this is fine. Installed on the trunk I think this was fixed already in August: 2018-08-01 Richard Biener PR bootstrap/86724 * graphite.h: Include isl/id.h and isl/space.h to allow build with ISL 0.20. and also backported to branches. You're right! I'll revert. Indeed, sorry for the noise. I noticed that the currently released versions failed to build, grepped for in trunk - which yielded nothing due to a typo. So I just applied the same patch and verified it built. Sorry again, Alexey.
Re: [PATCH] Fix build with ISL 0.20
On 9/26/18 8:43 AM, Richard Biener wrote: > On Wed, Sep 26, 2018 at 4:10 PM Jeff Law wrote: >> >> On 9/25/18 1:07 PM, Alexey Neyman wrote: >>> Hi, >>> >>> A trivial patch that fixes the build against the latest ISL release, >>> 0.20. In that release, and were split in two >>> headers each. The (included from which is >>> included by "graphite.h") now includes and >>> ; and must be included explicitly. >>> >>> These headers ( and ) are present in all >>> supported versions of ISL (0.15 and later). >>> >>> Bootstrapped on x86_64-pc-linux-gnu. >> Thanks for verifying these are in ISL 0.15 and later -- we recommend >> 0.18 these days, so I think this is fine. >> >> Installed on the trunk > > I think this was fixed already in August: > > 2018-08-01 Richard Biener > > PR bootstrap/86724 > * graphite.h: Include isl/id.h and isl/space.h to allow build > with ISL 0.20. > > and also backported to branches. You're right! I'll revert. jeff
Re: [PATCH] Fix build with ISL 0.20
On Wed, Sep 26, 2018 at 4:10 PM Jeff Law wrote: > > On 9/25/18 1:07 PM, Alexey Neyman wrote: > > Hi, > > > > A trivial patch that fixes the build against the latest ISL release, > > 0.20. In that release, and were split in two > > headers each. The (included from which is > > included by "graphite.h") now includes and > > ; and must be included explicitly. > > > > These headers ( and ) are present in all > > supported versions of ISL (0.15 and later). > > > > Bootstrapped on x86_64-pc-linux-gnu. > Thanks for verifying these are in ISL 0.15 and later -- we recommend > 0.18 these days, so I think this is fine. > > Installed on the trunk I think this was fixed already in August: 2018-08-01 Richard Biener PR bootstrap/86724 * graphite.h: Include isl/id.h and isl/space.h to allow build with ISL 0.20. and also backported to branches. Richard. > > jeff
Re: [PATCH] Fix build with ISL 0.20
On 9/25/18 1:07 PM, Alexey Neyman wrote: > Hi, > > A trivial patch that fixes the build against the latest ISL release, > 0.20. In that release, and were split in two > headers each. The (included from which is > included by "graphite.h") now includes and > ; and must be included explicitly. > > These headers ( and ) are present in all > supported versions of ISL (0.15 and later). > > Bootstrapped on x86_64-pc-linux-gnu. Thanks for verifying these are in ISL 0.15 and later -- we recommend 0.18 these days, so I think this is fine. Installed on the trunk. jeff
[PATCH] Fix build with ISL 0.20
Hi, A trivial patch that fixes the build against the latest ISL release, 0.20. In that release, and were split in two headers each. The (included from which is included by "graphite.h") now includes and ; and must be included explicitly. These headers ( and ) are present in all supported versions of ISL (0.15 and later). Bootstrapped on x86_64-pc-linux-gnu. Regards, Alexey. >From d4f0e6b43aecb4542b1fd6483874ff4cec684f6a Mon Sep 17 00:00:00 2001 From: Alexey Neyman Date: Mon, 24 Sep 2018 22:50:11 -0700 Subject: Fix build with ISL 0.20 * gcc/graphite.h: Include and ; these headers are no longer pulled in by . Signed-off-by: Alexey Neyman --- gcc/ChangeLog | 5 + gcc/graphite.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6be143e9f18..320e3731932 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2018-09-25 Alexey Neyman + + * gcc/graphite.h: Include and ; these + headers are no longer pulled in by . + 2018-09-25 Richard Biener PR debug/83941 diff --git a/gcc/graphite.h b/gcc/graphite.h index be0a22b3894..8db5700e03f 100644 --- a/gcc/graphite.h +++ b/gcc/graphite.h @@ -26,6 +26,8 @@ along with GCC; see the file COPYING3. If not see #include #include #include +#include +#include #include #include #include -- 2.14.1
Re: [PATCH] Fix build with ISL 0.20
On 01.08.2018 09:13, Richard Biener wrote: > > The following fixes build with ISL 0.20, tested by building with > ISL 0.20 and 0.15 (the oldest supported ISL). > > Applied to trunk, will commit to the branches as well. that was committed to the 7 and 8 branches, but not the 6 branch. Now done as well. Matthias > > Richard. > > 2018-08-01 Richard Biener > > PR bootstrap/86724 > * graphite.h: Include isl/id.h and isl/space.h to allow build > with ISL 0.20. > > Index: gcc/graphite.h > === > --- gcc/graphite.h(revision 263190) > +++ gcc/graphite.h(working copy) > @@ -37,6 +37,8 @@ along with GCC; see the file COPYING3. > #include > #include > #include > +#include > +#include > > typedef struct poly_dr *poly_dr_p; > >
[PATCH] Fix build with ISL 0.20
The following fixes build with ISL 0.20, tested by building with ISL 0.20 and 0.15 (the oldest supported ISL). Applied to trunk, will commit to the branches as well. Richard. 2018-08-01 Richard Biener PR bootstrap/86724 * graphite.h: Include isl/id.h and isl/space.h to allow build with ISL 0.20. Index: gcc/graphite.h === --- gcc/graphite.h (revision 263190) +++ gcc/graphite.h (working copy) @@ -37,6 +37,8 @@ along with GCC; see the file COPYING3. #include #include #include +#include +#include typedef struct poly_dr *poly_dr_p;
