Re: [PATCH] PR 84519 Handle optional QUIET specifier for STOP and ERROR STOP

2018-02-23 Thread Janne Blomqvist
On Thu, Feb 22, 2018 at 10:16 PM, Steve Kargl
 wrote:
> On Thu, Feb 22, 2018 at 09:42:02PM +0200, Janne Blomqvist wrote:
>> Fortran 2018 adds a new QUIET specifier for the STOP and ERROR STOP
>> statements, in order to suppress the printing of signaling FP
>> exceptions and the stop code. This patch adds the necessary library
>> changes, but for now the new specifier is not parsed and the frontend
>> unconditionally adds a false value for the new argument.
>>
>> Regtested on x86_64-pc-linux-gnu, Ok for trunk?
>>
>
> OK.

Thanks. Committed as r257928.

The corresponding OpenCoarrays pull request is
https://github.com/sourceryinstitute/OpenCoarrays/pull/510


-- 
Janne Blomqvist


Re: [PATCH] PR 84519 Handle optional QUIET specifier for STOP and ERROR STOP

2018-02-22 Thread Steve Kargl
On Thu, Feb 22, 2018 at 09:42:02PM +0200, Janne Blomqvist wrote:
> Fortran 2018 adds a new QUIET specifier for the STOP and ERROR STOP
> statements, in order to suppress the printing of signaling FP
> exceptions and the stop code. This patch adds the necessary library
> changes, but for now the new specifier is not parsed and the frontend
> unconditionally adds a false value for the new argument.
> 
> Regtested on x86_64-pc-linux-gnu, Ok for trunk?
> 

OK.

-- 
steve


[PATCH] PR 84519 Handle optional QUIET specifier for STOP and ERROR STOP

2018-02-22 Thread Janne Blomqvist
Fortran 2018 adds a new QUIET specifier for the STOP and ERROR STOP
statements, in order to suppress the printing of signaling FP
exceptions and the stop code. This patch adds the necessary library
changes, but for now the new specifier is not parsed and the frontend
unconditionally adds a false value for the new argument.

Regtested on x86_64-pc-linux-gnu, Ok for trunk?

(If accepted, I will handle the necessary changes to OpenCoarrays as
well).

gcc/fortran/ChangeLog:

2018-02-22  Janne Blomqvist  

PR fortran/84519
* trans-decl.c (gfc_build_builtin_function_decls): Add bool
argument to stop and error stop decls.
* trans-stmt.c (gfc_trans_stop): Add false value to argument
lists.

libgfortran/ChangeLog:

2018-02-22  Janne Blomqvist  

PR fortran/84519
* caf/libcaf.h (_gfortran_caf_stop_numeric): Add bool argument.
(_gfortran_caf_stop_str): Likewise.
(_gfortran_caf_error_stop_str): Likewise.
(_gfortran_caf_error_stop): Likewise.
* caf/mpi.c (_gfortran_caf_error_stop_str): Handle new argument.
(_gfortran_caf_error_stop): Likewise.
* caf/single.c (_gfortran_caf_stop_numeric): Likewise.
(_gfortran_caf_stop_str): Likewise.
(_gfortran_caf_error_stop_str): Likewise.
(_gfortran_caf_error_stop): Likewise.
(_gfortran_caf_lock): Likewise.
(_gfortran_caf_unlock): Likewise.
* libgfortran.h (stop_string): Add bool argument.
* runtime/pause.c (do_pause): Add false argument.
* runtime/stop.c (stop_numeric): Handle new argument.
(stop_string): Likewise.
(error_stop_string): Likewise.
(error_stop_numeric): Likewise.
---
 gcc/fortran/trans-decl.c| 10 +
 gcc/fortran/trans-stmt.c| 13 ++-
 libgfortran/caf/libcaf.h|  8 +++
 libgfortran/caf/mpi.c   | 19 +---
 libgfortran/caf/single.c| 42 ---
 libgfortran/libgfortran.h   |  2 +-
 libgfortran/runtime/pause.c |  2 +-
 libgfortran/runtime/stop.c  | 53 +++--
 8 files changed, 87 insertions(+), 62 deletions(-)

diff --git a/gcc/fortran/trans-decl.c b/gcc/fortran/trans-decl.c
index e8c10d4..c233a0e 100644
--- a/gcc/fortran/trans-decl.c
+++ b/gcc/fortran/trans-decl.c
@@ -3503,25 +3503,27 @@ gfc_build_builtin_function_decls (void)
 
   gfor_fndecl_stop_numeric = gfc_build_library_function_decl (
get_identifier (PREFIX("stop_numeric")),
-   void_type_node, 1, integer_type_node);
+   void_type_node, 2, integer_type_node, boolean_type_node);
   /* STOP doesn't return.  */
   TREE_THIS_VOLATILE (gfor_fndecl_stop_numeric) = 1;
 
   gfor_fndecl_stop_string = gfc_build_library_function_decl_with_spec (
get_identifier (PREFIX("stop_string")), ".R.",
-   void_type_node, 2, pchar_type_node, size_type_node);
+   void_type_node, 3, pchar_type_node, size_type_node,
+   boolean_type_node);
   /* STOP doesn't return.  */
   TREE_THIS_VOLATILE (gfor_fndecl_stop_string) = 1;
 
   gfor_fndecl_error_stop_numeric = gfc_build_library_function_decl (
 get_identifier (PREFIX("error_stop_numeric")),
-void_type_node, 1, integer_type_node);
+void_type_node, 2, integer_type_node, boolean_type_node);
   /* ERROR STOP doesn't return.  */
   TREE_THIS_VOLATILE (gfor_fndecl_error_stop_numeric) = 1;
 
   gfor_fndecl_error_stop_string = gfc_build_library_function_decl_with_spec (
get_identifier (PREFIX("error_stop_string")), ".R.",
-   void_type_node, 2, pchar_type_node, size_type_node);
+   void_type_node, 3, pchar_type_node, size_type_node,
+   boolean_type_node);
   /* ERROR STOP doesn't return.  */
   TREE_THIS_VOLATILE (gfor_fndecl_error_stop_string) = 1;
 
diff --git a/gcc/fortran/trans-stmt.c b/gcc/fortran/trans-stmt.c
index f1fe8a0..cf76fd0 100644
--- a/gcc/fortran/trans-stmt.c
+++ b/gcc/fortran/trans-stmt.c
@@ -642,7 +642,8 @@ gfc_trans_stop (gfc_code *code, bool error_stop)
 : (flag_coarray == GFC_FCOARRAY_LIB
? gfor_fndecl_caf_stop_str
: gfor_fndecl_stop_string),
-2, build_int_cst (pchar_type_node, 0), tmp);
+3, build_int_cst (pchar_type_node, 0), tmp,
+boolean_false_node);
 }
   else if (code->expr1->ts.type == BT_INTEGER)
 {
@@ -654,8 +655,9 @@ gfc_trans_stop (gfc_code *code, bool error_stop)
: gfor_fndecl_error_stop_numeric)
 : (flag_coarray == GFC_FCOARRAY_LIB
? gfor_fndecl_caf_stop_numeric
-   : gfor_fndecl_stop_numeric), 1,
-fold_convert (integer_type_node, se.expr));
+   : gfor_fndecl_stop_numeric), 2,
+