Re: [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float

[Maciej W. Rozycki]

On Thu, 11 Aug 2022, Kito Cheng wrote:

> LGTM, thanks :)

 I have committed this change now.  Thank you for your review.

  Maciej

Re: [PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float

[Kito Cheng via Gcc-patches]

LGTM, thanks :)

On Fri, Jul 29, 2022 at 3:52 AM Maciej W. Rozycki  wrote:
>
> Complement commit 7915f6551343 ("RISC-V/testsuite: constraint some of
> tests to hard_float") and also restrict the remaining `fmin'/`fmax'
> tests to hard-float test configurations.
>
> gcc/testsuite/
> * gcc.target/riscv/fmax-snan.c: Add `dg-require-effective-target
> hard_float'.
> * gcc.target/riscv/fmaxf-snan.c: Likewise.
> * gcc.target/riscv/fmin-snan.c: Likewise.
> * gcc.target/riscv/fminf-snan.c: Likewise.
> ---
>  gcc/testsuite/gcc.target/riscv/fmax-snan.c  |1 +
>  gcc/testsuite/gcc.target/riscv/fmaxf-snan.c |1 +
>  gcc/testsuite/gcc.target/riscv/fmin-snan.c  |1 +
>  gcc/testsuite/gcc.target/riscv/fminf-snan.c |1 +
>  4 files changed, 4 insertions(+)
>
> gcc-riscv-fmin-fmax-test-hard-float.diff
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> ===
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" 
> } */
>
>  double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> ===
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" 
> } */
>
>  float
> Index: gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> ===
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" 
> } */
>
>  double
> Index: gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> ===
> --- gcc.orig/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> +++ gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target hard_float } */
>  /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" 
> } */
>
>  float

[PATCH] RISC-V/testsuite: Restrict remaining `fmin'/`fmax' tests to hard float

[Maciej W. Rozycki]

Complement commit 7915f6551343 ("RISC-V/testsuite: constraint some of 
tests to hard_float") and also restrict the remaining `fmin'/`fmax' 
tests to hard-float test configurations.

gcc/testsuite/
* gcc.target/riscv/fmax-snan.c: Add `dg-require-effective-target 
hard_float'.
* gcc.target/riscv/fmaxf-snan.c: Likewise.
* gcc.target/riscv/fmin-snan.c: Likewise.
* gcc.target/riscv/fminf-snan.c: Likewise.
---
 gcc/testsuite/gcc.target/riscv/fmax-snan.c  |1 +
 gcc/testsuite/gcc.target/riscv/fmaxf-snan.c |1 +
 gcc/testsuite/gcc.target/riscv/fmin-snan.c  |1 +
 gcc/testsuite/gcc.target/riscv/fminf-snan.c |1 +
 4 files changed, 4 insertions(+)

gcc-riscv-fmin-fmax-test-hard-float.diff
Index: gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
===
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fmax-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fmax-snan.c
@@ -1,4 +1,5 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
 /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } 
*/
 
 double
Index: gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
===
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fmaxf-snan.c
@@ -1,4 +1,5 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
 /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } 
*/
 
 float
Index: gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
===
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fmin-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fmin-snan.c
@@ -1,4 +1,5 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
 /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } 
*/
 
 double
Index: gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
===
--- gcc.orig/gcc/testsuite/gcc.target/riscv/fminf-snan.c
+++ gcc/gcc/testsuite/gcc.target/riscv/fminf-snan.c
@@ -1,4 +1,5 @@
 /* { dg-do compile } */
+/* { dg-require-effective-target hard_float } */
 /* { dg-options "-fno-finite-math-only -fsigned-zeros -fsignaling-nans -dp" } 
*/
 
 float