Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
All done. Welcome Lehua. I have received the system notification email, thank you very much. Best, Lehua
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Hi all, On Tue, 2023-06-20 at 07:11 -0600, Jeff Law wrote: > On 6/20/23 04:56, Robin Dapp wrote: > > > Could you merge it ? > > > By the way, could Lehua get the write access? > > > > IMHO nothing stands in the way but I'll defer to Jeff to have > > the "official seal" :) > > Once he ACKs Lehua needs to go the usual way of requesting > > sourceware access via https://sourceware.org/cgi-bin/pdw/ps_form.cgi. > Lehua fills out that form. List me as the approver and the process will > run from there. Takes a day or two for everything to get into place. All done. Welcome Lehua. > ps. If Lehua has already filled out the form with Robin as the > approver, >that's fine too. Might take a bit longer as I suspect the > IT folks may not recognize Robin. Also Robin is right, you are on the hook as approver for the "official seal" :) Because the "IT folks" check that the approver is listed as a gcc maintainer and not just has write after approval status. Cheers, Mark
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Lehua fills out that form. List me as the approver and the process will run from there. Takes a day or two for everything to get into place. I just followed this step to submit the form, thanks to Robin, Jeff and Juzhe. Best, Lehua
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
On 6/20/23 04:56, Robin Dapp wrote: Could you merge it ? By the way, could Lehua get the write access? IMHO nothing stands in the way but I'll defer to Jeff to have the "official seal" :) Once he ACKs Lehua needs to go the usual way of requesting sourceware access via https://sourceware.org/cgi-bin/pdw/ps_form.cgi. Lehua fills out that form. List me as the approver and the process will run from there. Takes a day or two for everything to get into place. jeff ps. If Lehua has already filled out the form with Robin as the approver, that's fine too. Might take a bit longer as I suspect the IT folks may not recognize Robin.
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
> Could you merge it ? Committed. Regards Robin
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
> Could you merge it ? > By the way, could Lehua get the write access? IMHO nothing stands in the way but I'll defer to Jeff to have the "official seal" :) Once he ACKs Lehua needs to go the usual way of requesting sourceware access via https://sourceware.org/cgi-bin/pdw/ps_form.cgi. Regards Robin
Re: Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Could you merge it ? By the way, could Lehua get the write access? Thanks. juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-06-20 18:47 To: Lehua Ding; gcc-patches CC: rdapp.gcc; juzhe.zhong; kito.cheng; palmer; jeffreyalaw; pan2.li Subject: Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector > This little patch fixes a compile warning issue that my previous > patch introduced, sorry for introducing this issue. OK and obvious enough to push directly. Regards Robin
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
> This little patch fixes a compile warning issue that my previous > patch introduced, sorry for introducing this issue. OK and obvious enough to push directly. Regards Robin
Re: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Ok.
juzhe.zh...@rivai.ai
From: Lehua Ding
Date: 2023-06-20 17:45
To: gcc-patches
CC: juzhe.zhong; rdapp.gcc; kito.cheng; palmer; jeffreyalaw; pan2.li
Subject: [PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Hi,
This little patch fixes a compile warning issue that my previous patch
introduced, sorry for introducing this issue.
Best,
Lehua
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_arg_has_vector): Add default branch.
---
gcc/config/riscv/riscv.cc | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 6eb63a9d4de7..9558e28de3fc 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -3820,8 +3820,8 @@ riscv_arg_has_vector (const_tree type)
switch (TREE_CODE (type))
{
case RECORD_TYPE:
- /* If it is a record, it is further determined whether its fileds have
- vector type. */
+ /* If it is a record, it is further determined whether its fields have
+ vector type. */
for (tree f = TYPE_FIELDS (type); f; f = DECL_CHAIN (f))
if (TREE_CODE (f) == FIELD_DECL)
{
@@ -3835,6 +3835,8 @@ riscv_arg_has_vector (const_tree type)
break;
case ARRAY_TYPE:
return riscv_arg_has_vector (TREE_TYPE (type));
+default:
+ break;
}
return false;
--
2.36.3
[PATCH] RISC-V: Fix compiler warning of riscv_arg_has_vector
Hi,
This little patch fixes a compile warning issue that my previous patch
introduced, sorry for introducing this issue.
Best,
Lehua
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_arg_has_vector): Add default branch.
---
gcc/config/riscv/riscv.cc | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 6eb63a9d4de7..9558e28de3fc 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -3820,8 +3820,8 @@ riscv_arg_has_vector (const_tree type)
switch (TREE_CODE (type))
{
case RECORD_TYPE:
- /* If it is a record, it is further determined whether its fileds have
- vector type. */
+ /* If it is a record, it is further determined whether its fields have
+vector type. */
for (tree f = TYPE_FIELDS (type); f; f = DECL_CHAIN (f))
if (TREE_CODE (f) == FIELD_DECL)
{
@@ -3835,6 +3835,8 @@ riscv_arg_has_vector (const_tree type)
break;
case ARRAY_TYPE:
return riscv_arg_has_vector (TREE_TYPE (type));
+default:
+ break;
}
return false;
--
2.36.3
