Re: [PATCH] Update comment about the format of attribute name in attribute_spec handler

[Jeff Law]

On 05/28/2018 06:25 AM, Jozef Lawrynowicz wrote:
> With the changes in r250911 to canonicalize attribute names (i.e. remove
> leading and trailing underscores if present) a comment for "handler" in
> the attribute_spec struct needs to be updated to reflect that the NAME 
> argument
> 
> is now stripped of any underscores.
> 
> Patch is attached.
> 
> If the patch is acceptable, I would appreciate if someone would commit it for
> 
> me, as I don't have write access.
We should probably get you write access if you're going to continue to
submit patches.

https://sourceware.org/cgi-bin/pdw/ps_form.cgi

List me as approving your request.

> 
> 
> 0001-Update-comment-about-the-format-of-attribute-name-in.patch
> 
> 
> From 386f8e6aadf5627fcba0955a8dbb6abcec69b1a5 Mon Sep 17 00:00:00 2001
> From: Jozef Lawrynowicz 
> Date: Mon, 28 May 2018 13:04:12 +0100
> Subject: [PATCH] Update comment about the format of attribute name in
>  attribute_spec handler
> 
> 2018-05-28  Jozef Lawrynowicz  
> 
>   * gcc/tree-core.h: Update comment about the format of NAME string
>   passed to handler in attribute_spec.
Thanks.  Installed on the trunk.
jeff

[PATCH] Update comment about the format of attribute name in attribute_spec handler

[Jozef Lawrynowicz]

With the changes in r250911 to canonicalize attribute names (i.e. remove
leading and trailing underscores if present) a comment for "handler" in
the attribute_spec struct needs to be updated to reflect that the NAME argument
is now stripped of any underscores.

Patch is attached.

If the patch is acceptable, I would appreciate if someone would commit it for
me, as I don't have write access.

>From 386f8e6aadf5627fcba0955a8dbb6abcec69b1a5 Mon Sep 17 00:00:00 2001
From: Jozef Lawrynowicz 
Date: Mon, 28 May 2018 13:04:12 +0100
Subject: [PATCH] Update comment about the format of attribute name in
 attribute_spec handler

2018-05-28  Jozef Lawrynowicz  

	* gcc/tree-core.h: Update comment about the format of NAME string
	passed to handler in attribute_spec.

---
 gcc/tree-core.h | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gcc/tree-core.h b/gcc/tree-core.h
index 478c631..f7be51f 100644
--- a/gcc/tree-core.h
+++ b/gcc/tree-core.h
@@ -1942,14 +1942,14 @@ struct attribute_spec {
   bool affects_type_identity;
   /* Function to handle this attribute.  NODE points to the node to which
  the attribute is to be applied.  If a DECL, it should be modified in
- place; if a TYPE, a copy should be created.  NAME is the name of the
- attribute (possibly with leading or trailing __).  ARGS is the TREE_LIST
- of the arguments (which may be NULL).  FLAGS gives further information
- about the context of the attribute.  Afterwards, the attributes will
- be added to the DECL_ATTRIBUTES or TYPE_ATTRIBUTES, as appropriate,
- unless *NO_ADD_ATTRS is set to true (which should be done on error,
- as well as in any other cases when the attributes should not be added
- to the DECL or TYPE).  Depending on FLAGS, any attributes to be
+ place; if a TYPE, a copy should be created.  NAME is the canonicalized
+ name of the attribute i.e. without any leading or trailing underscores.
+ ARGS is the TREE_LIST of the arguments (which may be NULL).  FLAGS gives
+ further information about the context of the attribute.  Afterwards, the
+ attributes will be added to the DECL_ATTRIBUTES or TYPE_ATTRIBUTES, as
+ appropriate, unless *NO_ADD_ATTRS is set to true (which should be done on
+ error, as well as in any other cases when the attributes should not be
+ added to the DECL or TYPE).  Depending on FLAGS, any attributes to be
  applied to another type or DECL later may be returned;
  otherwise the return value should be NULL_TREE.  This pointer may be
  NULL if no special handling is required beyond the checks implied
-- 
2.7.4