Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac
On Tue, 30 Apr 2024 at 17:47, Simon Marchi wrote: > > On 4/30/24 4:54 AM, Christophe Lyon wrote: > > On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: > >> > >> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same > >> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. > >> > >> This makes it possible to re-generate aclocal.m4 using "autoreconf". > > > > Thanks, this LGTM, although like in your other patch, we need a > > ChangeLog entry in the commit message. > > > > Christophe > > Here is the ChangeLog entry: > > fixincludes/ChangeLog: > > * configure.ac: Add AC_CONFIG_MACRO_DIRS. > * configure: Re-generate. > > I don't have access to the gcc repo, so if/when this patch gets > approved, can you push it on my behalf? Sure! > > Thanks, > > Simon
Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac
On 4/30/24 4:54 AM, Christophe Lyon wrote: > On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: >> >> Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same >> directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. >> >> This makes it possible to re-generate aclocal.m4 using "autoreconf". > > Thanks, this LGTM, although like in your other patch, we need a > ChangeLog entry in the commit message. > > Christophe Here is the ChangeLog entry: fixincludes/ChangeLog: * configure.ac: Add AC_CONFIG_MACRO_DIRS. * configure: Re-generate. I don't have access to the gcc repo, so if/when this patch gets approved, can you push it on my behalf? Thanks, Simon
Re: [PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac
On Tue, 30 Apr 2024 at 04:25, Simon Marchi wrote: > > Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same > directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. > > This makes it possible to re-generate aclocal.m4 using "autoreconf". Thanks, this LGTM, although like in your other patch, we need a ChangeLog entry in the commit message. Christophe > --- > fixincludes/configure| 1 + > fixincludes/configure.ac | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/fixincludes/configure b/fixincludes/configure > index 662c94dc1120..7147c9a618aa 100755 > --- a/fixincludes/configure > +++ b/fixincludes/configure > @@ -4627,6 +4627,7 @@ $as_echo "$ac_cv_path_SED" >&6; } >rm -f conftest.sed > > > + > # Figure out what compiler warnings we can enable. > # See config/warnings.m4 for details. > > diff --git a/fixincludes/configure.ac b/fixincludes/configure.ac > index 4e78511d20fc..3d177699ebfa 100644 > --- a/fixincludes/configure.ac > +++ b/fixincludes/configure.ac > @@ -7,6 +7,7 @@ AC_CANONICAL_SYSTEM > AC_PROG_CC > AC_USE_SYSTEM_EXTENSIONS > AC_PROG_SED > +AC_CONFIG_MACRO_DIRS([.. ../config]) > > # Figure out what compiler warnings we can enable. > # See config/warnings.m4 for details. > > base-commit: 22b20ac6c6aead2d3f36c413a77dd0b80adfec39 > -- > 2.44.0 >
[PATCH] fixincludes: add AC_CONFIG_MACRO_DIRS to configure.ac
Add an "AC_CONFIG_MACRO_DIRS" call in configure.ac, with the same directories as specified in "ACLOCAL_AMFLAGS", in Makefile.in. This makes it possible to re-generate aclocal.m4 using "autoreconf". --- fixincludes/configure| 1 + fixincludes/configure.ac | 1 + 2 files changed, 2 insertions(+) diff --git a/fixincludes/configure b/fixincludes/configure index 662c94dc1120..7147c9a618aa 100755 --- a/fixincludes/configure +++ b/fixincludes/configure @@ -4627,6 +4627,7 @@ $as_echo "$ac_cv_path_SED" >&6; } rm -f conftest.sed + # Figure out what compiler warnings we can enable. # See config/warnings.m4 for details. diff --git a/fixincludes/configure.ac b/fixincludes/configure.ac index 4e78511d20fc..3d177699ebfa 100644 --- a/fixincludes/configure.ac +++ b/fixincludes/configure.ac @@ -7,6 +7,7 @@ AC_CANONICAL_SYSTEM AC_PROG_CC AC_USE_SYSTEM_EXTENSIONS AC_PROG_SED +AC_CONFIG_MACRO_DIRS([.. ../config]) # Figure out what compiler warnings we can enable. # See config/warnings.m4 for details. base-commit: 22b20ac6c6aead2d3f36c413a77dd0b80adfec39 -- 2.44.0
