Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
On Wed, Apr 17, 2024 at 01:16:43PM -0400, Eric Gallager wrote: > > --- a/libcpp/configure > > +++ b/libcpp/configure > > @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu > > > > > > > > + > > + > > + > > So, this is kind of a minor style nitpick, but personally, it kind of > bothers me when autotools goes and inserts a bunch of unnecessary > blank newlines in the generated output scripts. Does anyone else think > it'd be worth it to scatter around some of m4's "dnl" comments in the > configure.ac scripts, to get autoconf to eat the unnecessary newlines? In stage1 maybe, but certainly not in stage4. Jakub
Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
On Wed, Apr 17, 2024 at 10:03 AM Christophe Lyon wrote: > > As discussed in the PR, aclocal.m4 and configure were incorrectly > regenerated at some point. > > 2024-04-17 Christophe Lyon > > PR preprocessor/114748 > libcpp/ > * aclocal.m4: Regenerate. > * configure: Regenerate. > --- > libcpp/aclocal.m4 | 1 + > libcpp/configure | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/libcpp/aclocal.m4 b/libcpp/aclocal.m4 > index 4fc81709622..4d898ea2c97 100644 > --- a/libcpp/aclocal.m4 > +++ b/libcpp/aclocal.m4 > @@ -26,6 +26,7 @@ m4_include([../config/lib-ld.m4]) > m4_include([../config/lib-link.m4]) > m4_include([../config/lib-prefix.m4]) > m4_include([../config/nls.m4]) > +m4_include([../config/override.m4]) > m4_include([../config/po.m4]) > m4_include([../config/progtest.m4]) > m4_include([../config/warnings.m4]) > diff --git a/libcpp/configure b/libcpp/configure > index 8a38c0546e3..32d6aaa3069 100755 > --- a/libcpp/configure > +++ b/libcpp/configure > @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu > > > > + > + > + So, this is kind of a minor style nitpick, but personally, it kind of bothers me when autotools goes and inserts a bunch of unnecessary blank newlines in the generated output scripts. Does anyone else think it'd be worth it to scatter around some of m4's "dnl" comments in the configure.ac scripts, to get autoconf to eat the unnecessary newlines? Just an idea, Eric Gallager > ac_aux_dir= > for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do >if test -f "$ac_dir/install-sh"; then > -- > 2.34.1 >
Re: [PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
On Wed, Apr 17, 2024 at 02:01:55PM +, Christophe Lyon wrote: > As discussed in the PR, aclocal.m4 and configure were incorrectly > regenerated at some point. > > 2024-04-17 Christophe Lyon > > PR preprocessor/114748 > libcpp/ > * aclocal.m4: Regenerate. > * configure: Regenerate. Ok, thanks. Jakub
[PATCH] libcpp: Regenerate aclocal.m4 and configure [PR 114748]
As discussed in the PR, aclocal.m4 and configure were incorrectly regenerated at some point. 2024-04-17 Christophe Lyon PR preprocessor/114748 libcpp/ * aclocal.m4: Regenerate. * configure: Regenerate. --- libcpp/aclocal.m4 | 1 + libcpp/configure | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libcpp/aclocal.m4 b/libcpp/aclocal.m4 index 4fc81709622..4d898ea2c97 100644 --- a/libcpp/aclocal.m4 +++ b/libcpp/aclocal.m4 @@ -26,6 +26,7 @@ m4_include([../config/lib-ld.m4]) m4_include([../config/lib-link.m4]) m4_include([../config/lib-prefix.m4]) m4_include([../config/nls.m4]) +m4_include([../config/override.m4]) m4_include([../config/po.m4]) m4_include([../config/progtest.m4]) m4_include([../config/warnings.m4]) diff --git a/libcpp/configure b/libcpp/configure index 8a38c0546e3..32d6aaa3069 100755 --- a/libcpp/configure +++ b/libcpp/configure @@ -2670,6 +2670,9 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu + + + ac_aux_dir= for ac_dir in "$srcdir" "$srcdir/.." "$srcdir/../.."; do if test -f "$ac_dir/install-sh"; then -- 2.34.1
