Re: [PATCH] libgccjit: update some comments in libgccjit.c

[Andrea Corallo]

David Malcolm  writes:

> On Wed, 2020-08-19 at 09:24 +0200, Andrea Corallo wrote:
>> Hi all,
>> 
>> just a small patch updating some comments that apparently went out of
>> sync a while ago adding gcc_jit_context_new_rvalue_from_long.
>
>> Okay for trunk?
>
> Yes
>
> Thanks for fixing these
> Dave

Pushed as fc34d04b075.

Thanks

  Andrea

Re: [PATCH] libgccjit: update some comments in libgccjit.c

[David Malcolm via Gcc-patches]

On Wed, 2020-08-19 at 09:24 +0200, Andrea Corallo wrote:
> Hi all,
> 
> just a small patch updating some comments that apparently went out of
> sync a while ago adding gcc_jit_context_new_rvalue_from_long.

> Okay for trunk?

Yes

Thanks for fixing these
Dave

[PATCH] libgccjit: update some comments in libgccjit.c

[Andrea Corallo]

Hi all,

just a small patch updating some comments that apparently went out of
sync a while ago adding gcc_jit_context_new_rvalue_from_long.

Okay for trunk?

Thanks

  Andrea

>From 84b94a039d164878bdbf8bfd1a2038960f813c76 Mon Sep 17 00:00:00 2001
From: Andrea Corallo 
Date: Thu, 6 Aug 2020 10:25:40 +0200
Subject: [PATCH] libgccjit: Update comments for
 gcc_jit_context_new_rvalue_from* functions

2020-08-06  Andrea Corallo  

* libgccjit.c:
(gcc_jit_context_new_rvalue_from_int)
(gcc_jit_context_new_rvalue_from_long)
(gcc_jit_context_new_rvalue_from_double)
(gcc_jit_context_new_rvalue_from_ptr): Update function heading
comments.
---
 gcc/jit/libgccjit.c | 14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/gcc/jit/libgccjit.c b/gcc/jit/libgccjit.c
index 3d04f6db3af..50130fbbe00 100644
--- a/gcc/jit/libgccjit.c
+++ b/gcc/jit/libgccjit.c
@@ -1188,7 +1188,7 @@ gcc_jit_rvalue_get_type (gcc_jit_rvalue *rvalue)
 /* Public entrypoint.  See description in libgccjit.h.
 
After error-checking, the real work is done by the
-   gcc::jit::recording::context::new_rvalue_from_int method in
+   gcc::jit::recording::context::new_rvalue_from_const  method in
jit-recording.c.  */
 
 gcc_jit_rvalue *
@@ -1204,7 +1204,11 @@ gcc_jit_context_new_rvalue_from_int (gcc_jit_context 
*ctxt,
  ->new_rvalue_from_const  (numeric_type, value));
 }
 
-/* FIXME. */
+/* Public entrypoint.  See description in libgccjit.h.
+
+   After error-checking, the real work is done by the
+   gcc::jit::recording::context::new_rvalue_from_const  method
+   in jit-recording.c.  */
 
 gcc_jit_rvalue *
 gcc_jit_context_new_rvalue_from_long (gcc_jit_context *ctxt,
@@ -1256,7 +1260,7 @@ gcc_jit_context_one (gcc_jit_context *ctxt,
 /* Public entrypoint.  See description in libgccjit.h.
 
After error-checking, the real work is done by the
-   gcc::jit::recording::context::new_rvalue_from_double method in
+   gcc::jit::recording::context::new_rvalue_from_const  method in
jit-recording.c.  */
 
 gcc_jit_rvalue *
@@ -1275,8 +1279,8 @@ gcc_jit_context_new_rvalue_from_double (gcc_jit_context 
*ctxt,
 /* Public entrypoint.  See description in libgccjit.h.
 
After error-checking, the real work is done by the
-   gcc::jit::recording::context::new_rvalue_from_ptr method in
-   jit-recording.c.  */
+   gcc::jit::recording::context::new_rvalue_from_const  method
+   in jit-recording.c.  */
 
 gcc_jit_rvalue *
 gcc_jit_context_new_rvalue_from_ptr (gcc_jit_context *ctxt,
-- 
2.17.1