Re: [PATCH] testsuite: Add -fchecking to dg-ice tests
On Wed, Apr 21, 2021 at 12:52:39PM +0200, Jakub Jelinek wrote: > Hi! > > In --enable-checking=release builds (which is the default on release > branches), I'm getting various extra FAILs that don't appear in > --enable-checking=yes builds. > > XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (internal compiler error) > FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (test for excess errors) > XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (internal compiler error) > FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (test for excess errors) > XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (internal compiler error) > FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (test for excess errors) > FAIL: g++.dg/cpp0x/vt-88982.C -std=c++14 (test for excess errors) > FAIL: g++.dg/cpp0x/vt-88982.C -std=c++17 (test for excess errors) > FAIL: g++.dg/cpp0x/vt-88982.C -std=c++2a (test for excess errors) > FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++14 (test for excess errors) > FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++17 (test for excess errors) > FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++2a (test for excess errors) > FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++17 (test for excess errors) > FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++2a (test for excess errors) > FAIL: g++.dg/cpp2a/nontype-class39.C -std=c++2a (test for excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++14 (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++17 (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++2a (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++98 (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++14 (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++17 (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++2a (test for > excess errors) > FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++98 (test for > excess errors) > > These are tests that have dg-ice and most of those ICEs are checking ICEs > which go away in release checking when -fno-checking is the default. Ha, I hadn't considered this. Perhaps we should be adding -fchecking along with dg-ice... Thanks for fixing this. Marek
Re: [PATCH] testsuite: Add -fchecking to dg-ice tests
On Wed, Apr 21, 2021 at 2:10 PM Jakub Jelinek via Gcc-patches
wrote:
>
> Hi!
>
> In --enable-checking=release builds (which is the default on release
> branches), I'm getting various extra FAILs that don't appear in
> --enable-checking=yes builds.
>
> XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (internal compiler error)
> FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (test for excess errors)
> XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (internal compiler error)
> FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (test for excess errors)
> XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (internal compiler error)
> FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (test for excess errors)
> FAIL: g++.dg/cpp0x/vt-88982.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp0x/vt-88982.C -std=c++17 (test for excess errors)
> FAIL: g++.dg/cpp0x/vt-88982.C -std=c++2a (test for excess errors)
> FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++14 (test for excess errors)
> FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++17 (test for excess errors)
> FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++2a (test for excess errors)
> FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++17 (test for excess errors)
> FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++2a (test for excess errors)
> FAIL: g++.dg/cpp2a/nontype-class39.C -std=c++2a (test for excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++14 (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++17 (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++2a (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++98 (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++14 (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++17 (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++2a (test for
> excess errors)
> FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++98 (test for
> excess errors)
>
> These are tests that have dg-ice and most of those ICEs are checking ICEs
> which go away in release checking when -fno-checking is the default.
>
> The following patch adds -fchecking option to those.
> Tested on x86_64-linux --enable-checking=release build.
> Ok for trunk/10.2?
OK.
Richard.
> 2021-04-21 Jakub Jelinek
>
> * g++.dg/cpp1z/constexpr-lambda26.C: Add dg-additional-options
> -fchecking.
> * g++.dg/cpp1y/auto-fn61.C: Likewise.
> * g++.dg/cpp2a/nontype-class39.C: Likewise.
> * g++.dg/cpp0x/constexpr-52830.C: Likewise.
> * g++.dg/cpp0x/vt-88982.C: Likewise.
> * c-c++-common/goacc/kernels-decompose-ice-1.c: Add -fchecking to
> dg-additional-options.
> * c-c++-common/goacc/kernels-decompose-ice-2.c: Likewise.
>
> --- gcc/testsuite/g++.dg/cpp1z/constexpr-lambda26.C.jj 2020-11-10
> 23:29:45.646246177 +0100
> +++ gcc/testsuite/g++.dg/cpp1z/constexpr-lambda26.C 2021-04-21
> 12:24:53.515946657 +0200
> @@ -1,5 +1,6 @@
> // PR c++/87765
> // { dg-do compile { target c++17 } }
> +// { dg-additional-options "-fchecking" }
> // { dg-ice "cxx_eval_constant_expression" }
>
> template
> --- gcc/testsuite/g++.dg/cpp1y/auto-fn61.C.jj 2020-08-11 13:44:01.233003025
> +0200
> +++ gcc/testsuite/g++.dg/cpp1y/auto-fn61.C 2021-04-21 12:24:22.079298420
> +0200
> @@ -1,5 +1,6 @@
> // PR c++/88003
> // { dg-do compile { target c++14 } }
> +// { dg-additional-options "-fchecking" }
> // { dg-ice "poplevel_class" }
>
> auto test() {
> --- gcc/testsuite/g++.dg/cpp2a/nontype-class39.C.jj 2020-11-10
> 23:29:45.646246177 +0100
> +++ gcc/testsuite/g++.dg/cpp2a/nontype-class39.C2021-04-21
> 12:25:16.427690283 +0200
> @@ -1,5 +1,6 @@
> // PR c++/89565
> // { dg-do compile { target c++20 } }
> +// { dg-additional-options "-fchecking" }
> // { dg-ice "resolve_args" }
>
> template
> --- gcc/testsuite/g++.dg/cpp0x/constexpr-52830.C.jj 2021-01-14
> 20:00:52.868105693 +0100
> +++ gcc/testsuite/g++.dg/cpp0x/constexpr-52830.C2021-04-21
> 12:22:27.474581330 +0200
> @@ -1,5 +1,6 @@
> // PR c++/52830
> // { dg-do compile { target c++11 } }
> +// { dg-additional-options "-fchecking" }
> // { dg-ice "comptypes" }
>
> template struct eif { typedef void type; };
> --- gcc/testsuite/g++.dg/cpp0x/vt-88982.C.jj2020-11-10 23:29:45.646246177
> +0100
> +++ gcc/testsuite/g++.dg/cpp0x/vt-88982.C 2021-04-21 12:23:46.824692964
> +0200
> @@ -1,5 +1,6 @@
> // PR c++/88982
> // { dg-do compile { target c++11 } }
> +// { dg-additional-options "-fchecking" }
> // { dg-ice "tsubst_pack_expansion" }
>
> template struct A {
> --- gcc/testsuite/c-c++-common/goacc/kernels-decompose-ice-1.c.jj
> 2021-04-20 23:46:09.179190182 +0200
> +++ gcc/testsuite/c-c++-common/goacc/kernels-decompose-ice-1.c 2021-04-21
> 12:25:57.966225475 +0200
>
Re: [PATCH] testsuite: Add -fchecking to dg-ice tests
On 4/21/2021 4:52 AM, Jakub Jelinek via Gcc-patches wrote: Hi! In --enable-checking=release builds (which is the default on release branches), I'm getting various extra FAILs that don't appear in --enable-checking=yes builds. XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (internal compiler error) FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (test for excess errors) XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (internal compiler error) FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (test for excess errors) XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (internal compiler error) FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (test for excess errors) FAIL: g++.dg/cpp0x/vt-88982.C -std=c++14 (test for excess errors) FAIL: g++.dg/cpp0x/vt-88982.C -std=c++17 (test for excess errors) FAIL: g++.dg/cpp0x/vt-88982.C -std=c++2a (test for excess errors) FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++14 (test for excess errors) FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++17 (test for excess errors) FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++2a (test for excess errors) FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++17 (test for excess errors) FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++2a (test for excess errors) FAIL: g++.dg/cpp2a/nontype-class39.C -std=c++2a (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++14 (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++17 (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++2a (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++98 (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++14 (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++17 (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++2a (test for excess errors) FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++98 (test for excess errors) These are tests that have dg-ice and most of those ICEs are checking ICEs which go away in release checking when -fno-checking is the default. The following patch adds -fchecking option to those. Tested on x86_64-linux --enable-checking=release build. Ok for trunk/10.2? 2021-04-21 Jakub Jelinek * g++.dg/cpp1z/constexpr-lambda26.C: Add dg-additional-options -fchecking. * g++.dg/cpp1y/auto-fn61.C: Likewise. * g++.dg/cpp2a/nontype-class39.C: Likewise. * g++.dg/cpp0x/constexpr-52830.C: Likewise. * g++.dg/cpp0x/vt-88982.C: Likewise. * c-c++-common/goacc/kernels-decompose-ice-1.c: Add -fchecking to dg-additional-options. * c-c++-common/goacc/kernels-decompose-ice-2.c: Likewise. OK. One could argue this should fall under the obvious rule in the future. Jeff
[PATCH] testsuite: Add -fchecking to dg-ice tests
Hi!
In --enable-checking=release builds (which is the default on release
branches), I'm getting various extra FAILs that don't appear in
--enable-checking=yes builds.
XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (internal compiler error)
FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++14 (test for excess errors)
XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (internal compiler error)
FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++17 (test for excess errors)
XPASS: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (internal compiler error)
FAIL: g++.dg/cpp0x/constexpr-52830.C -std=c++2a (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++14 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++2a (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++14 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++2a (test for excess errors)
FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp1z/constexpr-lambda26.C -std=c++2a (test for excess errors)
FAIL: g++.dg/cpp2a/nontype-class39.C -std=c++2a (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++14 (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++17 (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++2a (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-1.c -std=c++98 (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++14 (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++17 (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++2a (test for excess
errors)
FAIL: c-c++-common/goacc/kernels-decompose-ice-2.c -std=c++98 (test for excess
errors)
These are tests that have dg-ice and most of those ICEs are checking ICEs
which go away in release checking when -fno-checking is the default.
The following patch adds -fchecking option to those.
Tested on x86_64-linux --enable-checking=release build.
Ok for trunk/10.2?
2021-04-21 Jakub Jelinek
* g++.dg/cpp1z/constexpr-lambda26.C: Add dg-additional-options
-fchecking.
* g++.dg/cpp1y/auto-fn61.C: Likewise.
* g++.dg/cpp2a/nontype-class39.C: Likewise.
* g++.dg/cpp0x/constexpr-52830.C: Likewise.
* g++.dg/cpp0x/vt-88982.C: Likewise.
* c-c++-common/goacc/kernels-decompose-ice-1.c: Add -fchecking to
dg-additional-options.
* c-c++-common/goacc/kernels-decompose-ice-2.c: Likewise.
--- gcc/testsuite/g++.dg/cpp1z/constexpr-lambda26.C.jj 2020-11-10
23:29:45.646246177 +0100
+++ gcc/testsuite/g++.dg/cpp1z/constexpr-lambda26.C 2021-04-21
12:24:53.515946657 +0200
@@ -1,5 +1,6 @@
// PR c++/87765
// { dg-do compile { target c++17 } }
+// { dg-additional-options "-fchecking" }
// { dg-ice "cxx_eval_constant_expression" }
template
--- gcc/testsuite/g++.dg/cpp1y/auto-fn61.C.jj 2020-08-11 13:44:01.233003025
+0200
+++ gcc/testsuite/g++.dg/cpp1y/auto-fn61.C 2021-04-21 12:24:22.079298420
+0200
@@ -1,5 +1,6 @@
// PR c++/88003
// { dg-do compile { target c++14 } }
+// { dg-additional-options "-fchecking" }
// { dg-ice "poplevel_class" }
auto test() {
--- gcc/testsuite/g++.dg/cpp2a/nontype-class39.C.jj 2020-11-10
23:29:45.646246177 +0100
+++ gcc/testsuite/g++.dg/cpp2a/nontype-class39.C2021-04-21
12:25:16.427690283 +0200
@@ -1,5 +1,6 @@
// PR c++/89565
// { dg-do compile { target c++20 } }
+// { dg-additional-options "-fchecking" }
// { dg-ice "resolve_args" }
template
--- gcc/testsuite/g++.dg/cpp0x/constexpr-52830.C.jj 2021-01-14
20:00:52.868105693 +0100
+++ gcc/testsuite/g++.dg/cpp0x/constexpr-52830.C2021-04-21
12:22:27.474581330 +0200
@@ -1,5 +1,6 @@
// PR c++/52830
// { dg-do compile { target c++11 } }
+// { dg-additional-options "-fchecking" }
// { dg-ice "comptypes" }
template struct eif { typedef void type; };
--- gcc/testsuite/g++.dg/cpp0x/vt-88982.C.jj2020-11-10 23:29:45.646246177
+0100
+++ gcc/testsuite/g++.dg/cpp0x/vt-88982.C 2021-04-21 12:23:46.824692964
+0200
@@ -1,5 +1,6 @@
// PR c++/88982
// { dg-do compile { target c++11 } }
+// { dg-additional-options "-fchecking" }
// { dg-ice "tsubst_pack_expansion" }
template struct A {
--- gcc/testsuite/c-c++-common/goacc/kernels-decompose-ice-1.c.jj
2021-04-20 23:46:09.179190182 +0200
+++ gcc/testsuite/c-c++-common/goacc/kernels-decompose-ice-1.c 2021-04-21
12:25:57.966225475 +0200
@@ -1,7 +1,7 @@
/* Test OpenACC 'kernels' construct decomposition. */
/* { dg-additional-options "-fopt-info-omp-all" } */
-/* { dg-additional-options "--param=openacc-kernels=decompose" } */
+/* { dg-additional-options "-fchecking --param=openacc-kernels=decompose" } */
/* { dg-ice "TODO" }
