Re: [PATCH 0/2] Future warnings not treated as errors
On Tue, Mar 19, 2019 at 10:09 PM Alex Henrie wrote: > > On Tue, Mar 19, 2019 at 11:03 AM Martin Liška wrote: > > > > What's Joseph telling is that right now the patch can't be approved (and > > installed). > > It's due to fact that we are close to the release in stage4: > > https://www.gnu.org/software/gcc/develop.html#stage4 > > > > So that a proper review will happen in couple of weeks. > > > > Thanks for understanding, > > Sure. I look forward to hearing back from you guys in a couple of weeks. Now that GCC 9.1 has been released, would you please merge these two patches? -Alex
Re: [PATCH 0/2] Future warnings not treated as errors
On Tue, Mar 19, 2019 at 11:03 AM Martin Liška wrote: > > What's Joseph telling is that right now the patch can't be approved (and > installed). > It's due to fact that we are close to the release in stage4: > https://www.gnu.org/software/gcc/develop.html#stage4 > > So that a proper review will happen in couple of weeks. > > Thanks for understanding, Sure. I look forward to hearing back from you guys in a couple of weeks. -Alex
Re: [PATCH 0/2] Future warnings not treated as errors
On 3/19/19 5:35 PM, Alex Henrie wrote: > On Tue, Mar 19, 2019 at 3:19 AM Martin Liška wrote: >> >> On 3/19/19 3:46 AM, Alex Henrie wrote: >>> Hello, >>> >>> I have received permission to contribute to GCC, but I do not have >>> commit access. Could one of you please merge these patches for me? >> >> Hi. >> >> I can do it for you. But if I see correctly, Joseph M. had some concerns >> and he should probably make final patch approval. > > If I understand correctly, Joseph wanted an error message to still be > printed if other diagnostics are also printed, the same as how > -Wno- works. The patches that I sent yesterday do > exactly that. > > -Alex > Hi. What's Joseph telling is that right now the patch can't be approved (and installed). It's due to fact that we are close to the release in stage4: https://www.gnu.org/software/gcc/develop.html#stage4 So that a proper review will happen in couple of weeks. Thanks for understanding, Martin
Re: [PATCH 0/2] Future warnings not treated as errors
On Tue, Mar 19, 2019 at 3:19 AM Martin Liška wrote: > > On 3/19/19 3:46 AM, Alex Henrie wrote: > > Hello, > > > > I have received permission to contribute to GCC, but I do not have > > commit access. Could one of you please merge these patches for me? > > Hi. > > I can do it for you. But if I see correctly, Joseph M. had some concerns > and he should probably make final patch approval. If I understand correctly, Joseph wanted an error message to still be printed if other diagnostics are also printed, the same as how -Wno- works. The patches that I sent yesterday do exactly that. -Alex
Re: [PATCH 0/2] Future warnings not treated as errors
On Tue, 19 Mar 2019, Martin Liška wrote: > On 3/19/19 3:46 AM, Alex Henrie wrote: > > Hello, > > > > I have received permission to contribute to GCC, but I do not have > > commit access. Could one of you please merge these patches for me? > > Hi. > > I can do it for you. But if I see correctly, Joseph M. had some concerns > and he should probably make final patch approval. I've noted to look at this patch during development stage 1. -- Joseph S. Myers jos...@codesourcery.com
Re: [PATCH 0/2] Future warnings not treated as errors
On 3/19/19 3:46 AM, Alex Henrie wrote: > Hello, > > I have received permission to contribute to GCC, but I do not have > commit access. Could one of you please merge these patches for me? Hi. I can do it for you. But if I see correctly, Joseph M. had some concerns and he should probably make final patch approval. Martin > > -Alex > > Alex Henrie (1): > PR c/65403 - Add tests for -Wno-error= > > Manuel López-Ibáñez (1): > PR c/65403 - Ignore -Wno-error= > > gcc/opts-common.c | 2 ++ > gcc/opts-global.c | 10 +++--- > gcc/opts.c | 5 - > gcc/opts.h | 2 ++ > gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++ > gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++ > 6 files changed, 40 insertions(+), 4 deletions(-) > create mode 100644 gcc/testsuite/c-c++-common/pr65403-1.c > create mode 100644 gcc/testsuite/c-c++-common/pr65403-2.c >
[PATCH 0/2] Future warnings not treated as errors
Hello, I have received permission to contribute to GCC, but I do not have commit access. Could one of you please merge these patches for me? -Alex Alex Henrie (1): PR c/65403 - Add tests for -Wno-error= Manuel López-Ibáñez (1): PR c/65403 - Ignore -Wno-error= gcc/opts-common.c | 2 ++ gcc/opts-global.c | 10 +++--- gcc/opts.c | 5 - gcc/opts.h | 2 ++ gcc/testsuite/c-c++-common/pr65403-1.c | 10 ++ gcc/testsuite/c-c++-common/pr65403-2.c | 15 +++ 6 files changed, 40 insertions(+), 4 deletions(-) create mode 100644 gcc/testsuite/c-c++-common/pr65403-1.c create mode 100644 gcc/testsuite/c-c++-common/pr65403-2.c -- 2.21.0
