Re: [PATCH 0/3] mklog improvements

2019-09-04 Thread Jeff Law
On 9/4/19 2:05 AM, Martin Liška wrote:
> On 9/3/19 6:37 PM, Jeff Law wrote:
>> On 8/30/19 2:55 AM, Martin Liška wrote:
>>> PING^1
>>>
>>> On 8/13/19 9:49 AM, Martin Liska wrote:
 Hi.

 I'm sending format independent changes to mklog that should
 improve the script. It addresses couple of improvement
 mentioned here:
 https://gcc.gnu.org/ml/gcc-patches/2019-08/msg00031.html

 Martin

 Martin Liska (3):
    Use argparse.ArgumentParser for mklog.
    mklog: parse PR references from new test files
    mklog: Do not print changed functions in testsuite
>> So there's a ton of follow-ups (primarily between Jakub and yourself).
> 
> Yes, the follow up is about possible change to ChangeLog format. I first
> provided a patch, but later I realized that I would rather stick with
> the current format.
I'd rather drop ChangeLogs and generate them from the VCS, but that's
another discussion entirely :-)

> 
>>
>> What's the state of the changes Jakub has requested?  Can we go forward
>> with the patch as-is and iterate on further improvements?
> 
> Yes, I'm going to install these 3 patches which do not change the format.
THat works for me.

jeff



Re: [PATCH 0/3] mklog improvements

2019-09-04 Thread Martin Liška

On 9/3/19 6:37 PM, Jeff Law wrote:

On 8/30/19 2:55 AM, Martin Liška wrote:

PING^1

On 8/13/19 9:49 AM, Martin Liska wrote:

Hi.

I'm sending format independent changes to mklog that should
improve the script. It addresses couple of improvement
mentioned here:
https://gcc.gnu.org/ml/gcc-patches/2019-08/msg00031.html

Martin

Martin Liska (3):
   Use argparse.ArgumentParser for mklog.
   mklog: parse PR references from new test files
   mklog: Do not print changed functions in testsuite

So there's a ton of follow-ups (primarily between Jakub and yourself).


Yes, the follow up is about possible change to ChangeLog format. I first
provided a patch, but later I realized that I would rather stick with
the current format.



What's the state of the changes Jakub has requested?  Can we go forward
with the patch as-is and iterate on further improvements?


Yes, I'm going to install these 3 patches which do not change the format.

Martin



Jeff





Re: [PATCH 0/3] mklog improvements

2019-09-03 Thread Jeff Law
On 8/30/19 2:55 AM, Martin Liška wrote:
> PING^1
> 
> On 8/13/19 9:49 AM, Martin Liska wrote:
>> Hi.
>>
>> I'm sending format independent changes to mklog that should
>> improve the script. It addresses couple of improvement
>> mentioned here:
>> https://gcc.gnu.org/ml/gcc-patches/2019-08/msg00031.html
>>
>> Martin
>>
>> Martin Liska (3):
>>   Use argparse.ArgumentParser for mklog.
>>   mklog: parse PR references from new test files
>>   mklog: Do not print changed functions in testsuite
So there's a ton of follow-ups (primarily between Jakub and yourself).

What's the state of the changes Jakub has requested?  Can we go forward
with the patch as-is and iterate on further improvements?

Jeff



Re: [PATCH 0/3] mklog improvements

2019-08-30 Thread Martin Liška
PING^1

On 8/13/19 9:49 AM, Martin Liska wrote:
> Hi.
> 
> I'm sending format independent changes to mklog that should
> improve the script. It addresses couple of improvement
> mentioned here:
> https://gcc.gnu.org/ml/gcc-patches/2019-08/msg00031.html
> 
> Martin
> 
> Martin Liska (3):
>   Use argparse.ArgumentParser for mklog.
>   mklog: parse PR references from new test files
>   mklog: Do not print changed functions in testsuite
> 
>  contrib/mklog | 98 ---
>  1 file changed, 47 insertions(+), 51 deletions(-)
> 



[PATCH 0/3] mklog improvements

2019-08-13 Thread Martin Liska
Hi.

I'm sending format independent changes to mklog that should
improve the script. It addresses couple of improvement
mentioned here:
https://gcc.gnu.org/ml/gcc-patches/2019-08/msg00031.html

Martin

Martin Liska (3):
  Use argparse.ArgumentParser for mklog.
  mklog: parse PR references from new test files
  mklog: Do not print changed functions in testsuite

 contrib/mklog | 98 ---
 1 file changed, 47 insertions(+), 51 deletions(-)

-- 
2.22.0