Re: [PATCH 041/236] Debug hooks: use rtx_insn and rtx_code_label

2014-08-21 Thread David Malcolm
On Wed, 2014-08-13 at 12:05 -0600, Jeff Law wrote:
 On 08/06/14 11:20, David Malcolm wrote:
  gcc/
  * debug.h (struct gcc_debug_hooks): Strengthen param 1 of hook
  label from rtx to rtx_code_label *.  Strengthen param 1 o
  var_location hook from rtx to rtx_insn *.
  (debug_nothing_rtx): Delete in favor of...
  (debug_nothing_rtx_code_label): New prototype.
  (debug_nothing_rtx_rtx): Delete unused prototype.
  (debug_nothing_rtx_insn): New prototype.
 
  * final.c (final_scan_insn): Add checked cast to rtx_insn * when
  invoking debug_hooks-var_location (in two places, one in a NOTE
  case of a switch statement, the other guarded by a CALL_P
  conditional.  Add checked cast to rtx_code_label * when invoking
  debug_hooks-label (within CODE_LABEL case of switch statement).
 
  * dbxout.c (dbx_debug_hooks): Update label hook from
  debug_nothing_rtx to debug_nothing_rtx_code_label.  Update
  var_location from debug_nothing_rtx to debug_nothing_rtx_insn.
  (xcoff_debug_hooks): Likewise.
  * debug.c (do_nothing_debug_hooks): Likewise.
  (debug_nothing_rtx): Delete in favor of...
  (debug_nothing_rtx_insn): New function.
  (debug_nothing_rtx_rtx): Delete unused function.
  (debug_nothing_rtx_code_label): New function.
  * dwarf2out.c (dwarf2_debug_hooks): Update label hook from
  debug_nothing_rtx to debug_nothing_rtx_code_label.
  (dwarf2out_var_location): Strengthen param loc_note from rtx
  to rtx_insn *.
  * sdbout.c (sdb_debug_hooks): Update var_location hook from
  debug_nothing_rtx to debug_nothing_rtx_insn.
  (sdbout_label): Strengthen param insn from rtx to
  rtx_code_label *.
  * vmsdbgout.c (vmsdbg_debug_hooks): Update label hook from
  debug_nothing_rtx to debug_nothing_rtx_code_label.  Update
  var_location hook from debug_nothing_rtx to
  debug_nothing_rtx_insn.
 OK.  Note minor typo in changelog line #2.  o at EOL should probably 
 be of

Thanks.  Bootstrapped; committed to trunk as r214259, with the ChangeLog
typo fixed.





Re: [PATCH 041/236] Debug hooks: use rtx_insn and rtx_code_label

2014-08-13 Thread Jeff Law

On 08/06/14 11:20, David Malcolm wrote:

gcc/
* debug.h (struct gcc_debug_hooks): Strengthen param 1 of hook
label from rtx to rtx_code_label *.  Strengthen param 1 o
var_location hook from rtx to rtx_insn *.
(debug_nothing_rtx): Delete in favor of...
(debug_nothing_rtx_code_label): New prototype.
(debug_nothing_rtx_rtx): Delete unused prototype.
(debug_nothing_rtx_insn): New prototype.

* final.c (final_scan_insn): Add checked cast to rtx_insn * when
invoking debug_hooks-var_location (in two places, one in a NOTE
case of a switch statement, the other guarded by a CALL_P
conditional.  Add checked cast to rtx_code_label * when invoking
debug_hooks-label (within CODE_LABEL case of switch statement).

* dbxout.c (dbx_debug_hooks): Update label hook from
debug_nothing_rtx to debug_nothing_rtx_code_label.  Update
var_location from debug_nothing_rtx to debug_nothing_rtx_insn.
(xcoff_debug_hooks): Likewise.
* debug.c (do_nothing_debug_hooks): Likewise.
(debug_nothing_rtx): Delete in favor of...
(debug_nothing_rtx_insn): New function.
(debug_nothing_rtx_rtx): Delete unused function.
(debug_nothing_rtx_code_label): New function.
* dwarf2out.c (dwarf2_debug_hooks): Update label hook from
debug_nothing_rtx to debug_nothing_rtx_code_label.
(dwarf2out_var_location): Strengthen param loc_note from rtx
to rtx_insn *.
* sdbout.c (sdb_debug_hooks): Update var_location hook from
debug_nothing_rtx to debug_nothing_rtx_insn.
(sdbout_label): Strengthen param insn from rtx to
rtx_code_label *.
* vmsdbgout.c (vmsdbg_debug_hooks): Update label hook from
debug_nothing_rtx to debug_nothing_rtx_code_label.  Update
var_location hook from debug_nothing_rtx to
debug_nothing_rtx_insn.
OK.  Note minor typo in changelog line #2.  o at EOL should probably 
be of


jeff



[PATCH 041/236] Debug hooks: use rtx_insn and rtx_code_label

2014-08-06 Thread David Malcolm
gcc/
* debug.h (struct gcc_debug_hooks): Strengthen param 1 of hook
label from rtx to rtx_code_label *.  Strengthen param 1 o
var_location hook from rtx to rtx_insn *.
(debug_nothing_rtx): Delete in favor of...
(debug_nothing_rtx_code_label): New prototype.
(debug_nothing_rtx_rtx): Delete unused prototype.
(debug_nothing_rtx_insn): New prototype.

* final.c (final_scan_insn): Add checked cast to rtx_insn * when
invoking debug_hooks-var_location (in two places, one in a NOTE
case of a switch statement, the other guarded by a CALL_P
conditional.  Add checked cast to rtx_code_label * when invoking
debug_hooks-label (within CODE_LABEL case of switch statement).

* dbxout.c (dbx_debug_hooks): Update label hook from
debug_nothing_rtx to debug_nothing_rtx_code_label.  Update
var_location from debug_nothing_rtx to debug_nothing_rtx_insn.
(xcoff_debug_hooks): Likewise.
* debug.c (do_nothing_debug_hooks): Likewise.
(debug_nothing_rtx): Delete in favor of...
(debug_nothing_rtx_insn): New function.
(debug_nothing_rtx_rtx): Delete unused function.
(debug_nothing_rtx_code_label): New function.
* dwarf2out.c (dwarf2_debug_hooks): Update label hook from
debug_nothing_rtx to debug_nothing_rtx_code_label.
(dwarf2out_var_location): Strengthen param loc_note from rtx
to rtx_insn *.
* sdbout.c (sdb_debug_hooks): Update var_location hook from
debug_nothing_rtx to debug_nothing_rtx_insn.
(sdbout_label): Strengthen param insn from rtx to
rtx_code_label *.
* vmsdbgout.c (vmsdbg_debug_hooks): Update label hook from
debug_nothing_rtx to debug_nothing_rtx_code_label.  Update
var_location hook from debug_nothing_rtx to
debug_nothing_rtx_insn.
---
 gcc/dbxout.c| 8 
 gcc/debug.c | 9 -
 gcc/debug.h | 8 
 gcc/dwarf2out.c | 6 +++---
 gcc/final.c | 6 +++---
 gcc/sdbout.c| 6 +++---
 gcc/vmsdbgout.c | 4 ++--
 7 files changed, 23 insertions(+), 24 deletions(-)

diff --git a/gcc/dbxout.c b/gcc/dbxout.c
index 6cb4341..a41db37 100644
--- a/gcc/dbxout.c
+++ b/gcc/dbxout.c
@@ -371,9 +371,9 @@ const struct gcc_debug_hooks dbx_debug_hooks =
   debug_nothing_tree_tree_tree_bool,/* imported_module_or_decl */
   debug_nothing_tree,   /* deferred_inline_function */
   debug_nothing_tree,   /* outlining_inline_function */
-  debug_nothing_rtx,/* label */
+  debug_nothing_rtx_code_label, /* label */
   dbxout_handle_pch,/* handle_pch */
-  debug_nothing_rtx,/* var_location */
+  debug_nothing_rtx_insn,   /* var_location */
   debug_nothing_void,/* switch_text_section */
   debug_nothing_tree_tree,  /* set_name */
   0, /* start_end_main_source_file */
@@ -407,9 +407,9 @@ const struct gcc_debug_hooks xcoff_debug_hooks =
   debug_nothing_tree_tree_tree_bool,/* imported_module_or_decl */
   debug_nothing_tree,   /* deferred_inline_function */
   debug_nothing_tree,   /* outlining_inline_function */
-  debug_nothing_rtx,/* label */
+  debug_nothing_rtx_code_label, /* label */
   dbxout_handle_pch,/* handle_pch */
-  debug_nothing_rtx,/* var_location */
+  debug_nothing_rtx_insn,   /* var_location */
   debug_nothing_void,/* switch_text_section */
   debug_nothing_tree_tree,  /* set_name */
   0, /* start_end_main_source_file */
diff --git a/gcc/debug.c b/gcc/debug.c
index 1734540..dba068c 100644
--- a/gcc/debug.c
+++ b/gcc/debug.c
@@ -48,9 +48,9 @@ const struct gcc_debug_hooks do_nothing_debug_hooks =
   debug_nothing_tree_tree_tree_bool,/* imported_module_or_decl */
   debug_nothing_tree,   /* deferred_inline_function */
   debug_nothing_tree,   /* outlining_inline_function */
-  debug_nothing_rtx,/* label */
+  debug_nothing_rtx_code_label, /* label */
   debug_nothing_int,/* handle_pch */
-  debug_nothing_rtx,/* var_location */
+  debug_nothing_rtx_insn,   /* var_location */
   debug_nothing_void,/* switch_text_section */
   debug_nothing_tree_tree,  /* set_name */
   0, /* start_end_main_source_file */
@@ -91,13 +91,12 @@ debug_true_const_tree (const_tree block ATTRIBUTE_UNUSED)
 }
 
 void
-debug_nothing_rtx (rtx insn ATTRIBUTE_UNUSED)
+debug_nothing_rtx_insn (rtx_insn *insn ATTRIBUTE_UNUSED)
 {
 }
 
 void
-debug_nothing_rtx_rtx (rtx insn ATTRIBUTE_UNUSED,
-  rtx