Re: [PATCH 07/30] [build] Make sbitmap code available to the driver programs

[Richard Biener]

On Wed, Jun 14, 2017 at 4:35 PM, Richard Earnshaw (lists)
 wrote:
> On 09/06/17 13:53, Richard Earnshaw wrote:
>>
>> The ARM option parsing code uses sbitmap data structures to manage
>> features and upcoming patches will shortly need to use these bitmaps
>> within the driver.  This patch moves sbitmap.o from OBJS to
>> OBJS-libcommon to facilitate this.
>>
>> The patch has no impact on targets that don't need this functionality,
>> since the object is part of an archive and will only be extracted if
>> needed.
>>
>>   * Makefile.in (OBJS): Move sbitmap.o from here ...
>>   (OBJS-libcommon): ... to here.
>
> It may have been missed given that most of this patch series is
> ARM-specific, that this patch and
> https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00629.html (patch 20) need
> review from a global maintainer/component maintainer.

Ok.

Richard.

> R.
>
>> ---
>>  gcc/Makefile.in | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> 0007-build-Make-sbitmap-code-available-to-the-driver-prog.patch
>>
>>
>> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
>> index da98c8e..67d69c1 100644
>> --- a/gcc/Makefile.in
>> +++ b/gcc/Makefile.in
>> @@ -1441,7 +1441,6 @@ OBJS = \
>>   rtlanal.o \
>>   rtlhooks.o \
>>   run-rtl-passes.o \
>> - sbitmap.o \
>>   sched-deps.o \
>>   sched-ebb.o \
>>   sched-rgn.o \
>> @@ -1587,6 +1586,7 @@ OBJS = \
>>  OBJS-libcommon = diagnostic.o diagnostic-color.o diagnostic-show-locus.o \
>>   edit-context.o \
>>   pretty-print.o intl.o \
>> + sbitmap.o \
>>   vec.o input.o version.o hash-table.o ggc-none.o memory-block.o \
>>   selftest.o
>>
>>
>

Re: [PATCH 07/30] [build] Make sbitmap code available to the driver programs

[Richard Earnshaw (lists)]

On 09/06/17 13:53, Richard Earnshaw wrote:
> 
> The ARM option parsing code uses sbitmap data structures to manage
> features and upcoming patches will shortly need to use these bitmaps
> within the driver.  This patch moves sbitmap.o from OBJS to
> OBJS-libcommon to facilitate this.
> 
> The patch has no impact on targets that don't need this functionality,
> since the object is part of an archive and will only be extracted if
> needed.
> 
>   * Makefile.in (OBJS): Move sbitmap.o from here ...
>   (OBJS-libcommon): ... to here.

It may have been missed given that most of this patch series is
ARM-specific, that this patch and
https://gcc.gnu.org/ml/gcc-patches/2017-06/msg00629.html (patch 20) need
review from a global maintainer/component maintainer.

R.

> ---
>  gcc/Makefile.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> 0007-build-Make-sbitmap-code-available-to-the-driver-prog.patch
> 
> 
> diff --git a/gcc/Makefile.in b/gcc/Makefile.in
> index da98c8e..67d69c1 100644
> --- a/gcc/Makefile.in
> +++ b/gcc/Makefile.in
> @@ -1441,7 +1441,6 @@ OBJS = \
>   rtlanal.o \
>   rtlhooks.o \
>   run-rtl-passes.o \
> - sbitmap.o \
>   sched-deps.o \
>   sched-ebb.o \
>   sched-rgn.o \
> @@ -1587,6 +1586,7 @@ OBJS = \
>  OBJS-libcommon = diagnostic.o diagnostic-color.o diagnostic-show-locus.o \
>   edit-context.o \
>   pretty-print.o intl.o \
> + sbitmap.o \
>   vec.o input.o version.o hash-table.o ggc-none.o memory-block.o \
>   selftest.o
>  
> 

[PATCH 07/30] [build] Make sbitmap code available to the driver programs

[Richard Earnshaw]

The ARM option parsing code uses sbitmap data structures to manage
features and upcoming patches will shortly need to use these bitmaps
within the driver.  This patch moves sbitmap.o from OBJS to
OBJS-libcommon to facilitate this.

The patch has no impact on targets that don't need this functionality,
since the object is part of an archive and will only be extracted if
needed.

* Makefile.in (OBJS): Move sbitmap.o from here ...
(OBJS-libcommon): ... to here.
---
 gcc/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index da98c8e..67d69c1 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1441,7 +1441,6 @@ OBJS = \
 	rtlanal.o \
 	rtlhooks.o \
 	run-rtl-passes.o \
-	sbitmap.o \
 	sched-deps.o \
 	sched-ebb.o \
 	sched-rgn.o \
@@ -1587,6 +1586,7 @@ OBJS = \
 OBJS-libcommon = diagnostic.o diagnostic-color.o diagnostic-show-locus.o \
 	edit-context.o \
 	pretty-print.o intl.o \
+	sbitmap.o \
 	vec.o input.o version.o hash-table.o ggc-none.o memory-block.o \
 	selftest.o