Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places

2014-05-09 Thread Jeff Law 

On 04/21/14 10:56, David Malcolm wrote:

gcc/
* tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi.
(find_bivs): Convert local phi into a gimple_phi.
(mark_bivs): Likewise.

OK when prerequisites have gone in.

Actually that's true for #17  #18 as well.

jeff

Impact of gimple renamings on reviews (was Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places)

2014-05-09 Thread David Malcolm 
On Fri, 2014-05-09 at 12:34 -0600, Jeff Law wrote:
 On 04/21/14 10:56, David Malcolm wrote:
  gcc/
  * tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi.
  (find_bivs): Convert local phi into a gimple_phi.
  (mark_bivs): Likewise.
 OK when prerequisites have gone in.
 
 Actually that's true for #17  #18 as well.

Jeff: thanks.  Note that I'm currently working on a grand renaming, as
per the subthread here:
 http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00346.html
so that all of these will be gphi * rather than gimple_phi, with
analogous change to the other classnames in the rest of the patches.

So there's both
  (A) a shortening of:
gimple_phi
  to
gphi
and
  (B) a change in pointerness (eliminating the typedefs), to:
gphi *

and these obviously affect the entire patch series, so what I would
commit is beginning to look rather different from what I've posted,
albeit with largely mechanical changes.

Are these patches going to need re-review when the renaming is done, or
are the changes sufficiently mechanical so as to be grandfathered in
from these reviews that you're doing; I'm slightly nervous about the
pointerness change, but bootstrapregrtesting ought to catch typo issues
there when manually fixing up the later patches.

I hope that re-review isn't necessary, but I'm relatively new around
here so I wanted to doublecheck.

If re-review *is* required, maybe hold off on reviewing the rest of the
series until I've got the renaming done?

[In any case, this is all in a holding pattern for trunk until after
4.9.1]

Cheers
Dave

Re: Impact of gimple renamings on reviews (was Re: [PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places)

2014-05-09 Thread Jeff Law 

On 05/09/14 12:47, David Malcolm wrote:

Jeff: thanks.  Note that I'm currently working on a grand renaming, as
per the subthread here:
  http://gcc.gnu.org/ml/gcc-patches/2014-05/msg00346.html
so that all of these will be gphi * rather than gimple_phi, with
analogous change to the other classnames in the rest of the patches.

So there's both
   (A) a shortening of:
 gimple_phi
   to
 gphi
and
   (B) a change in pointerness (eliminating the typedefs), to:
 gphi *

and these obviously affect the entire patch series, so what I would
commit is beginning to look rather different from what I've posted,
albeit with largely mechanical changes.

Are these patches going to need re-review when the renaming is done, or
are the changes sufficiently mechanical so as to be grandfathered in
from these reviews that you're doing; I'm slightly nervous about the
pointerness change, but bootstrapregrtesting ought to catch typo issues
there when manually fixing up the later patches.
I think the renaming is mechanical enough that no additional reviews 
would be necessary.


The /89 patch series as a whole is pretty mechanical.  There's two or 
three types of patches I've seen as I go through them and for those 
kinds of patches, I looked at the first couple pretty closely, then less 
so for later ones.



[In any case, this is all in a holding pattern for trunk until after
4.9.1]
Right.  But I've got some time now and getting the kit as a whole 
approved so that you're good to go when 4.9.1 is done is valuable.  Who 
knows what kind of crazyness will interfere with my time next month!


jeff

[PATCH 16/89] tree-ssa-loop-ivopts.c: use gimple_phi in a few places

2014-04-21 Thread David Malcolm 
gcc/
* tree-ssa-loop-ivopts.c (determine_biv_step): Require a gimple_phi.
(find_bivs): Convert local phi into a gimple_phi.
(mark_bivs): Likewise.
---
 gcc/tree-ssa-loop-ivopts.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gcc/tree-ssa-loop-ivopts.c b/gcc/tree-ssa-loop-ivopts.c
index ea18311..24f296a 100644
--- a/gcc/tree-ssa-loop-ivopts.c
+++ b/gcc/tree-ssa-loop-ivopts.c
@@ -1009,7 +1009,7 @@ get_iv (struct ivopts_data *data, tree var)
not define a simple affine biv with nonzero step.  */
 
 static tree
-determine_biv_step (gimple phi)
+determine_biv_step (gimple_phi phi)
 {
   struct loop *loop = gimple_bb (phi)-loop_father;
   tree name = PHI_RESULT (phi);
@@ -1029,7 +1029,7 @@ determine_biv_step (gimple phi)
 static bool
 find_bivs (struct ivopts_data *data)
 {
-  gimple phi;
+  gimple_phi phi;
   tree step, type, base;
   bool found = false;
   struct loop *loop = data-current_loop;
@@ -1074,7 +1074,8 @@ find_bivs (struct ivopts_data *data)
 static void
 mark_bivs (struct ivopts_data *data)
 {
-  gimple phi, def;
+  gimple_phi phi;
+  gimple def;
   tree var;
   struct iv *iv, *incr_iv;
   struct loop *loop = data-current_loop;
-- 
1.8.5.3