On Fri, 2022-11-04 at 17:05 -0400, Lewis Hyatt wrote: > [PATCH 5a/6] diagnostics: Handle generated data locations in > edit_context > > Class edit_context handles outputting fixit hints in diff form that > could be > manually or automatically applied by the user. This will not make > sense for > generated data locations, such as the contents of a _Pragma string, > because > the text to be modified does not appear in the user's input files. We > do not > currently ever generate fixit hints in such a context, but for > future-proofing > purposes, ignore such locations in edit context now. > > gcc/ChangeLog: > > * edit-context.cc (edit_context::apply_fixit): Ignore > locations in > generated data. > > diff --git a/gcc/edit-context.cc b/gcc/edit-context.cc > index 6879ddd41b4..aa95bc0834f 100644 > --- a/gcc/edit-context.cc > +++ b/gcc/edit-context.cc > @@ -301,8 +301,12 @@ edit_context::apply_fixit (const fixit_hint > *hint) > return false; > if (start.column == 0) > return false; > + if (start.generated_data) > + return false; > if (next_loc.column == 0) > return false; > + if (next_loc.generated_data) > + return false; > > edited_file &file = get_or_insert_file (start.file); > if (!m_valid)
This patch is OK for trunk once the prerequisite patch is also approved. Thanks Dave
