RE: [PATCH PR94991] aarch64: ICE: Segmentation fault with option -mgeneral-regs-only

2020-05-11 Thread Yangfei (Felix) 
Hi,

> -Original Message-
> From: Richard Sandiford [mailto:richard.sandif...@arm.com]
> Sent: Monday, May 11, 2020 10:27 PM
> To: Yangfei (Felix) 
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH PR94991] aarch64: ICE: Segmentation fault with option -
> mgeneral-regs-only
> 
> LGTM.  Pushed with one minor formatting fix:
> 
> > @@ -1364,7 +1364,11 @@
> >  if (!TARGET_FLOAT)
> >{
> > aarch64_err_no_fpadvsimd (mode);
> > -   FAIL;
> > +   machine_mode intmode
> > +   = int_mode_for_size (GET_MODE_BITSIZE (mode),
> 0).require ();
> 
> The "=" should only be indented by two spaces relative to the first line.

Thanks for fixing the bad formatting  :- )
I was expecting issues like that to be reported by contrib/check_GNU_style.sh.
Will be more carefull.

Felix

Re: [PATCH PR94991] aarch64: ICE: Segmentation fault with option -mgeneral-regs-only

2020-05-11 Thread Richard Sandiford 
"Yangfei (Felix)"  writes:
> Hi,
>
>   Witnessed another ICE with option -mgeneral-regs-only. 
>   I have created a bug for that: 
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94991 
>
>   For the given testcase, we are doing FAIL for scalar floating move expand 
> pattern since TARGET_FLOAT
>   is false with option -mgeneral-regs-only. But move expand pattern cannot 
> fail. It would be better to 
>   replace the FAIL with code that bitcasts to the equivalent integer mode, 
> using gen_lowpart.
>
>   Bootstrap and tested on aarch64-linux-gnu.  Comments?

LGTM.  Pushed with one minor formatting fix:

> @@ -1364,7 +1364,11 @@
>  if (!TARGET_FLOAT)
>{
>   aarch64_err_no_fpadvsimd (mode);
> - FAIL;
> + machine_mode intmode
> + = int_mode_for_size (GET_MODE_BITSIZE (mode), 0).require ();

The "=" should only be indented by two spaces relative to the first line.

Thanks,
Richard

[PATCH PR94991] aarch64: ICE: Segmentation fault with option -mgeneral-regs-only

2020-05-07 Thread Yangfei (Felix) 
Hi,

  Witnessed another ICE with option -mgeneral-regs-only. 
  I have created a bug for that: 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94991 

  For the given testcase, we are doing FAIL for scalar floating move expand 
pattern since TARGET_FLOAT
  is false with option -mgeneral-regs-only. But move expand pattern cannot 
fail. It would be better to 
  replace the FAIL with code that bitcasts to the equivalent integer mode, 
using gen_lowpart.

  Bootstrap and tested on aarch64-linux-gnu.  Comments?

Thanks,
Felix


pr94991-v1.diff
Description: pr94991-v1.diff