Re: [PATCH rs6000] Fix for builtins-4-int128-runnable.c

[Segher Boessenkool]

Hi Carl,

On Wed, Feb 14, 2018 at 11:09:09AM -0800, Carl Love wrote:
> The following patch contains fixes an issue with the 128-bit test on
> Power 7.  Power 7 does not support int128 so the test must be
> restricted to run on Power 8 and later.

> 2018-02-14  Carl Love  

(blank line here)

> * gcc.target/powerpc/builtins-4-int128-runnable.c 
> (dg-require-effective-target):

Line too long.  You can put the ( at the start of a new line.

>   Change vsx_hw to p8vector_hw.
>   (dg-options): Change -maltivec -mvsx to -mpower8-vector.

Otherwise fine, thanks!  Okay for trunk.


Segher

Re: [PATCH rs6000] Fix for builtins-4-int128-runnable.c

[Peter Bergner]

On 2/14/18 1:09 PM, Carl Love wrote:
> The following patch contains fixes an issue with the 128-bit test on
> Power 7.  Power 7 does not support int128 so the test must be
> restricted to run on Power 8 and later.

To be pedantic, GCC POWER7 supports __int128_t just fine (in 64-bit mode).
It however does not support vector __int128_t which is what we're testing
here.

Peter

[PATCH rs6000] Fix for builtins-4-int128-runnable.c

[Carl Love]

GCC maintainers:

The following patch contains fixes an issue with the 128-bit test on
Power 7.  Power 7 does not support int128 so the test must be
restricted to run on Power 8 and later.

The change was tested by hand on a Power 8 machine with the command:

make -k check-gcc RUNTESTFLAGS="--target_board=unix'{-mcpu=power7}'
powerpc.exp=builtins-4-int128-runnable.c" 

to verify the test passes cleanly with the change in the dg directives.

Please let me know if the patch is OK for trunk.  Thanks.

   Carl Love




2018-02-14  Carl Love  
* gcc.target/powerpc/builtins-4-int128-runnable.c 
(dg-require-effective-target):
Change vsx_hw to p8vector_hw.
(dg-options): Change -maltivec -mvsx to -mpower8-vector.
---
 gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c 
b/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c
index 162e267..4f4e7a9 100644
--- a/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c
+++ b/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c
@@ -1,7 +1,7 @@
 /* { dg-do run } */
 /* { dg-require-effective-target int128 } */
-/* { dg-require-effective-target vsx_hw } */
-/* { dg-options "-maltivec -mvsx" } */
+/* { dg-require-effective-target p8vector_hw } */
+/* { dg-options "-mpower8-vector" } */
 
 #include 
 #include  // vector
-- 
2.7.4