Re: [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-04-18 Thread Sam James via Gcc-patches

Jeff Law  writes:

> On 4/2/23 15:33, Sam James wrote:
>> gcc/ChangeLog:
>>  * system.h: Drop unused INCLUDE_PTHREAD_H.
> THanks.  I've pushed this to the trunk.

Cheers Jeff!

> jeff

best,
sam


signature.asc
Description: PGP signature


Re: [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-04-18 Thread Jeff Law via Gcc-patches




On 4/2/23 15:33, Sam James wrote:

gcc/ChangeLog:
* system.h: Drop unused INCLUDE_PTHREAD_H.

THanks.  I've pushed this to the trunk.
jeff


[PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-04-02 Thread Sam James via Gcc-patches
INCLUDE_PTHREAD_H was added for r13-1350-g49d508065bdd36 for a calloc poisoning
issue like r13-6662-g0e6f87835ccabf.

When working on r13-6662-g0e6f87835ccabf, we realised that INCLUDE_PTHREAD_H
became unused as of r13-4164-g0a62889c7a155f (which was originally added
for r13-1350-g49d508065bdd36 for a similar musl issue).

I originally tried to use INCLUDE_PTHREAD_H in r13-6662-g0e6f87835ccabf even 
though
it was the wrong solution, so let's drop it given it's both:
1. now obsolete;
2. a bit confusing.

Nothing is using this to guard inclusion of pthread.h and it only ever had
one consumer in the tree which is now gone.

gcc/ChangeLog:
* system.h: Drop unused INCLUDE_PTHREAD_H.

Thanks-to: Andrew Pinski 
Signed-off-by: Sam James 
---
 gcc/system.h | 4 
 1 file changed, 4 deletions(-)

diff --git a/gcc/system.h b/gcc/system.h
index cf45db3f97e..3fdad7abf1e 100644
--- a/gcc/system.h
+++ b/gcc/system.h
@@ -761,10 +761,6 @@ extern int vsnprintf (char *, size_t, const char *, 
va_list);
 #endif
 #endif
 
-#ifdef INCLUDE_PTHREAD_H
-#include 
-#endif
-
 #ifdef INCLUDE_ISL
 #ifdef HAVE_isl
 #include 
-- 
2.40.0