Re: [Patch, libffi] libffi merge
On Wed, Dec 26, 2012 at 11:29:42AM -0500, Anthony Green wrote: I've committed this patch. Thanks, Anthony Green Anthony, Did you run make check in libffi on this merge? These changes appear to have broken the dejagnu testing in libffi... # make -k check Password: Making check in include make[1]: Nothing to be done for `check'. Making check in testsuite make check-DEJAGNU srcdir='../../../../gcc-4.8-20121226/libffi/testsuite'; export srcdir; \ EXPECT=`if [ -f ../../expect/expect ] ; then echo ../../expect/expect ; else echo expect ; fi`; export EXPECT; \ runtest=`if [ -f ../../../../gcc-4.8-20121226/libffi/../dejagnu/runtest ] ; then echo ../../../../gcc-4.8-20121226/libffi/../dejagnu/runtest ; else echo runtest; fi`; \ if /bin/sh -c $runtest --version /dev/null 21; then \ exit_status=0; l='libffi'; for tool in $l; do \ if $runtest --tool $tool --srcdir $srcdir ; \ then :; else exit_status=1; fi; \ done; \ else echo WARNING: could not find \`runtest' 12; :;\ fi; \ exit $exit_status WARNING: Couldn't find the global config file. Test Run By root on Thu Dec 27 09:48:42 2012 Native configuration is x86_64-apple-darwin12.2.0 === libffi tests === Schedule of variations: unix Running target unix Using /sw/share/dejagnu/baseboards/unix.exp as board description file for target. Using /sw/share/dejagnu/config/unix.exp as generic interface file for target. Using ../../../../gcc-4.8-20121226/libffi/testsuite/config/default.exp as tool-and-target-specific interface file. Running ../../../../gcc-4.8-20121226/libffi/testsuite/libffi.call/call.exp ... ERROR: (DejaGnu) proc set_ld_library_path_env_vars does not exist. The error code is NONE The info on the error is: invalid command name set_ld_library_path_env_vars while executing ::tcl_unknown set_ld_library_path_env_vars (uplevel body line 1) invoked from within uplevel 1 ::tcl_unknown $args === libffi Summary === make[2]: *** [check-DEJAGNU] Error 1 make[1]: *** [check-am] Error 2 make[1]: Target `check' not remade because of errors. This is showing up repeatedly in gcc-regressions. Jack On Sun, Dec 23, 2012 at 4:37 PM, Anthony Green gr...@moxielogic.com wrote: The attached patch is fairly complete merge of the libffi side-stream git repo. Highlights include aarch64 support, blackfin support, and additional windows ABI support. I will commit this in a day or two unless there are any objections. Thanks, Anthony Green 2012-10-30 Magnus Granberg zo...@gentoo.org Pavel Labushev pavel.labus...@runbox.ru * configure.ac: New options pax_emutramp * configure, fficonfig.h.in: Regenerated * src/closures.c: New function emutramp_enabled_check() and checks. 2012-10-30 Frederick Cheung frederick.che...@gmail.com * configure.ac: Enable FFI_MAP_EXEC_WRIT for Darwin 12 (mountain lion) and future version. * configure: Rebuild. 2012-10-30 James Greenhalgh james.greenhalgh at arm.com Marcus Shawcroft marcus.shawcroft at arm.com * README: Add details of aarch64 port. * src/aarch64/ffi.c: New. * src/aarch64/ffitarget.h: Likewise. * src/aarch64/sysv.S: Likewise. * Makefile.am: Support aarch64. * configure.ac: Support aarch64. * Makefile.in, configure: Rebuilt. 2012-10-30 James Greenhalgh james.greenhalgh at arm.com Marcus Shawcroft marcus.shawcroft at arm.com * testsuite/lib/libffi.exp: Add support for aarch64. * testsuite/libffi.call/cls_struct_va1.c: New. * testsuite/libffi.call/cls_uchar_va.c: Likewise. * testsuite/libffi.call/cls_uint_va.c: Likewise. * testsuite/libffi.call/cls_ulong_va.c: Likewise. * testsuite/libffi.call/cls_ushort_va.c: Likewise. * testsuite/libffi.call/nested_struct11.c: Likewise. * testsuite/libffi.call/uninitialized.c: Likewise. * testsuite/libffi.call/va_1.c: Likewise. * testsuite/libffi.call/va_struct1.c: Likewise. * testsuite/libffi.call/va_struct2.c: Likewise. * testsuite/libffi.call/va_struct3.c: Likewise. 2012-10-12 Walter Lee w...@tilera.com * Makefile.am: Add TILE-Gx/TILEPro support. * configure.ac: Likewise. * Makefile.in: Regenerate. * configure: Likewise. * src/prep_cif.c (ffi_prep_cif_core): Handle TILE-Gx/TILEPro. * src/tile: New directory. * src/tile/ffi.c: New file. * src/tile/ffitarget.h: Ditto. * src/tile/tile.S: Ditto. 2012-10-12 Matthias Klose d...@ubuntu.com * generate-osx-source-and-headers.py: Normalize whitespace. 2012-05-05 Nicolas Lelong *
Re: [Patch, libffi] libffi merge
Jack Howarth howa...@bromo.med.uc.edu writes: Did you run make check in libffi on this merge? These changes appear to have broken the dejagnu testing in libffi... The problem is the wrong definition of load_gcc_lib. @@ -16,7 +16,7 @@ proc load_gcc_lib { filename } { global srcdir -load_file $srcdir/../../gcc/testsuite/lib/$filename +load_file $srcdir/lib/$filename } load_lib dg.exp Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different.
Re: [Patch, libffi] libffi merge
On Thu, Dec 27, 2012 at 04:06:47PM +0100, Andreas Schwab wrote: Jack Howarth howa...@bromo.med.uc.edu writes: Did you run make check in libffi on this merge? These changes appear to have broken the dejagnu testing in libffi... The problem is the wrong definition of load_gcc_lib. @@ -16,7 +16,7 @@ proc load_gcc_lib { filename } { global srcdir -load_file $srcdir/../../gcc/testsuite/lib/$filename +load_file $srcdir/lib/$filename } load_lib dg.exp Andreas. Andreas, What do you get for the testsuite results with that change? On x86_64-apple-darwin12, every single test seems to fail the test for excess errors at -m32 (but not -m64) when using... make -k check RUNTESTFLAGS=--target_board=unix'{-m32,-m64}' === libffi Summary for unix/-m32 === # of unexpected failures663 # of unresolved testcases 663 # of unsupported tests 55 These show up at -m32 as... Executing on host: /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/xgcc -B/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/ ../../../../gcc-4.8-20121226/libffi/testsuite/libffi.call/closure_fn0.c -O0 -W -Wall -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/testsuite/../include -I../../../../gcc-4.8-20121226/libffi/testsuite/../include -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/testsuite/../include/.. -L/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/testsuite/../.libs -Wl,-allow_stack_execute -shared-libgcc -lffi -lm -m32 -o ./closure_fn0.exe (timeout = 300) ld: warning: ignoring file /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/.libs/libffi.dylib, file was built for unsupported file format ( 0xcf 0xfa 0xed 0xfe 0x 7 0x 0 0x 0 0x 1 0x 3 0x 0 0x 0 0x 0 0x 6 0x 0 0x 0 0x 0 ) which is not the architecture being linked (i386): /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/.libs/libffi.dylib^M Undefined symbols for architecture i386:^M _ffi_closure_alloc, referenced from:^M _main in ccIwL8dt.o^M _ffi_prep_cif, referenced from:^M _main in ccIwL8dt.o^M _ffi_prep_closure_loc, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_double, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_float, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_sint16, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_sint32, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_uint64, referenced from:^M _main in ccIwL8dt.o^M ld: symbol(s) not found for architecture i386^M collect2: error: ld returned 1 exit status^M So it appears that the merge also broke the multilib testing of libffi. Jack -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different.
Re: [Patch, libffi] libffi merge
On Thu, Dec 27, 2012 at 10:19:57AM -0500, Jack Howarth wrote: On Thu, Dec 27, 2012 at 04:06:47PM +0100, Andreas Schwab wrote: Jack Howarth howa...@bromo.med.uc.edu writes: Did you run make check in libffi on this merge? These changes appear to have broken the dejagnu testing in libffi... The problem is the wrong definition of load_gcc_lib. @@ -16,7 +16,7 @@ proc load_gcc_lib { filename } { global srcdir -load_file $srcdir/../../gcc/testsuite/lib/$filename +load_file $srcdir/lib/$filename } load_lib dg.exp Andreas. Andreas, What do you get for the testsuite results with that change? On x86_64-apple-darwin12, every single test seems to fail the test for excess errors at -m32 (but not -m64) when using... make -k check RUNTESTFLAGS=--target_board=unix'{-m32,-m64}' === libffi Summary for unix/-m32 === # of unexpected failures663 # of unresolved testcases 663 # of unsupported tests 55 These show up at -m32 as... Executing on host: /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/xgcc -B/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/gcc/ ../../../../gcc-4.8-20121226/libffi/testsuite/libffi.call/closure_fn0.c -O0 -W -Wall -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/testsuite/../include -I../../../../gcc-4.8-20121226/libffi/testsuite/../include -I/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/testsuite/../include/.. -L/sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/testsuite/../.libs -Wl,-allow_stack_execute -shared-libgcc -lffi -lm -m32 -o ./closure_fn0.exe(timeout = 300) ld: warning: ignoring file /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/.libs/libffi.dylib, file was built for unsupported file format ( 0xcf 0xfa 0xed 0xfe 0x 7 0x 0 0x 0 0x 1 0x 3 0x 0 0x 0 0x 0 0x 6 0x 0 0x 0 0x 0 ) which is not the architecture being linked (i386): /sw/src/fink.build/gcc48-4.8.0-1000/darwin_objdir/x86_64-apple-darwin12.2.0/libffi/.libs/libffi.dylib^M Undefined symbols for architecture i386:^M _ffi_closure_alloc, referenced from:^M _main in ccIwL8dt.o^M _ffi_prep_cif, referenced from:^M _main in ccIwL8dt.o^M _ffi_prep_closure_loc, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_double, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_float, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_sint16, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_sint32, referenced from:^M _main in ccIwL8dt.o^M _ffi_type_uint64, referenced from:^M _main in ccIwL8dt.o^M ld: symbol(s) not found for architecture i386^M collect2: error: ld returned 1 exit status^M So it appears that the merge also broke the multilib testing of libffi. Jack The m4's included in the Makefile.am of the libffi testsuite is wildly different (and misses multi.m4 completely) @@ -37,22 +54,32 @@ subdir = testsuite DIST_COMMON = $(srcdir)/Makefile.am $(srcdir)/Makefile.in ACLOCAL_M4 = $(top_srcdir)/aclocal.m4 -am__aclocal_m4_deps = $(top_srcdir)/../config/depstand.m4 \ - $(top_srcdir)/../config/lead-dot.m4 \ - $(top_srcdir)/../config/multi.m4 \ - $(top_srcdir)/../config/override.m4 \ - $(top_srcdir)/../libtool.m4 $(top_srcdir)/../ltoptions.m4 \ - $(top_srcdir)/../ltsugar.m4 $(top_srcdir)/../ltversion.m4 \ - $(top_srcdir)/../lt~obsolete.m4 $(top_srcdir)/acinclude.m4 \ +am__aclocal_m4_deps = $(top_srcdir)/m4/asmcfi.m4 \ + $(top_srcdir)/m4/ax_cc_maxopt.m4 \ + $(top_srcdir)/m4/ax_cflags_warn_all.m4 \ + $(top_srcdir)/m4/ax_check_compile_flag.m4 \ + $(top_srcdir)/m4/ax_compiler_vendor.m4 \ + $(top_srcdir)/m4/ax_configure_args.m4 \ + $(top_srcdir)/m4/ax_enable_builddir.m4 \ + $(top_srcdir)/m4/ax_gcc_archflag.m4 \ + $(top_srcdir)/m4/ax_gcc_x86_cpuid.m4 \ + $(top_srcdir)/m4/libtool.m4 $(top_srcdir)/m4/ltoptions.m4 \ + $(top_srcdir)/m4/ltsugar.m4 $(top_srcdir)/m4/ltversion.m4 \ + $(top_srcdir)/m4/lt~obsolete.m4 $(top_srcdir)/acinclude.m4 \ $(top_srcdir)/configure.ac am__configure_deps = $(am__aclocal_m4_deps) $(CONFIGURE_DEPENDENCIES) \ $(ACLOCAL_M4) -mkinstalldirs = $(SHELL) $(top_srcdir)/../mkinstalldirs +mkinstalldirs = $(install_sh) -d CONFIG_HEADER = $(top_builddir)/fficonfig.h CONFIG_CLEAN_FILES = CONFIG_CLEAN_VPATH_FILES = SOURCES = DIST_SOURCES = +am__can_run_installinfo = \ + case $$AM_UPDATE_INFO_DIR in \ +n|no|NO) false;; \ +*) (install-info --version) /dev/null 21;; \ + esac DEJATOOL = $(PACKAGE) RUNTESTDEFAULTFLAGS = --tool $$tool --srcdir $$srcdir DISTFILES = $(DIST_COMMON) $(DIST_SOURCES) $(TEXINFOS) $(EXTRA_DIST) -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint =
Re: [Patch, libffi] libffi merge
I've committed this patch. Thanks, Anthony Green On Sun, Dec 23, 2012 at 4:37 PM, Anthony Green gr...@moxielogic.com wrote: The attached patch is fairly complete merge of the libffi side-stream git repo. Highlights include aarch64 support, blackfin support, and additional windows ABI support. I will commit this in a day or two unless there are any objections. Thanks, Anthony Green 2012-10-30 Magnus Granberg zo...@gentoo.org Pavel Labushev pavel.labus...@runbox.ru * configure.ac: New options pax_emutramp * configure, fficonfig.h.in: Regenerated * src/closures.c: New function emutramp_enabled_check() and checks. 2012-10-30 Frederick Cheung frederick.che...@gmail.com * configure.ac: Enable FFI_MAP_EXEC_WRIT for Darwin 12 (mountain lion) and future version. * configure: Rebuild. 2012-10-30 James Greenhalgh james.greenhalgh at arm.com Marcus Shawcroft marcus.shawcroft at arm.com * README: Add details of aarch64 port. * src/aarch64/ffi.c: New. * src/aarch64/ffitarget.h: Likewise. * src/aarch64/sysv.S: Likewise. * Makefile.am: Support aarch64. * configure.ac: Support aarch64. * Makefile.in, configure: Rebuilt. 2012-10-30 James Greenhalgh james.greenhalgh at arm.com Marcus Shawcroft marcus.shawcroft at arm.com * testsuite/lib/libffi.exp: Add support for aarch64. * testsuite/libffi.call/cls_struct_va1.c: New. * testsuite/libffi.call/cls_uchar_va.c: Likewise. * testsuite/libffi.call/cls_uint_va.c: Likewise. * testsuite/libffi.call/cls_ulong_va.c: Likewise. * testsuite/libffi.call/cls_ushort_va.c: Likewise. * testsuite/libffi.call/nested_struct11.c: Likewise. * testsuite/libffi.call/uninitialized.c: Likewise. * testsuite/libffi.call/va_1.c: Likewise. * testsuite/libffi.call/va_struct1.c: Likewise. * testsuite/libffi.call/va_struct2.c: Likewise. * testsuite/libffi.call/va_struct3.c: Likewise. 2012-10-12 Walter Lee w...@tilera.com * Makefile.am: Add TILE-Gx/TILEPro support. * configure.ac: Likewise. * Makefile.in: Regenerate. * configure: Likewise. * src/prep_cif.c (ffi_prep_cif_core): Handle TILE-Gx/TILEPro. * src/tile: New directory. * src/tile/ffi.c: New file. * src/tile/ffitarget.h: Ditto. * src/tile/tile.S: Ditto. 2012-10-12 Matthias Klose d...@ubuntu.com * generate-osx-source-and-headers.py: Normalize whitespace. 2012-05-05 Nicolas Lelong * libffi.xcodeproj/project.pbxproj: Fixes. * README: Update for iOS builds. 2012-04-23 Alexandre Keunecke I. de Mendonca alexandre.keune...@gmail.com * configure.ac: Add Blackfin/sysv support * Makefile.am: Add Blackfin/sysv support * src/bfin/ffi.c: Add Blackfin/sysv support * src/bfin/ffitarget.h: Add Blackfin/sysv support 2012-04-11 Anthony Green gr...@moxielogic.com * Makefile.am (EXTRA_DIST): Add new script. * Makefile.in: Rebuilt. 2012-04-11 Zachary Waldowski zwaldow...@gmail.com * generate-ios-source-and-headers.py, libffi.xcodeproj/project.pbxproj: Support a Mac static library via Xcode. Set iOS compatibility to 4.0. Move iOS trampoline generation into an Xcode run script phase. Include both as Xcode build scripts. Don't always regenerate config files. 2012-04-10 Anthony Green gr...@moxielogic.com * src/powerpc/ffi_darwin.c (ffi_prep_args): Add missing semicolon. 2012-04-06 Anthony Green gr...@moxielogic.com * Makefile.am (EXTRA_DIST): Add new iOS/xcode files. * Makefile.in: Rebuilt. 2012-04-06 Mike Lewis mikelikes...@gmail.com * generate-ios-source-and-headers.py: New file. * libffi.xcodeproj/project.pbxproj: New file. * README: Update instructions on building iOS binary. * build-ios.sh: Delete. 2012-04-06 Anthony Green gr...@moxielogic.com * src/x86/ffi64.c (UINT128): Define differently for Intel and GNU compilers, then use it. 2012-04-06 H.J. Lu hongjiu...@intel.com * m4/libtool.m4 (_LT_ENABLE_LOCK): Support x32. 2012-04-06 Anthony Green gr...@moxielogic.com * testsuite/Makefile.am (EXTRA_DIST): Add missing test cases. * testsuite/Makefile.in: Rebuilt. 2012-04-05 Zachary Waldowski zwaldow...@gmail.com * include/ffi.h.in: Add missing trampoline table fields. * src/arm/sysv.S: Fix ENTRY definition, and wrap symbol references in CNAME. * src/x86/ffi.c: Wrap Windows specific code in ifdefs. 2012-03-29 Peter Rosin p...@lysator.liu.se * src/x86/win32.S (ffi_closure_raw_THISCALL): Unify the frame generation, fix the