Re: [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
On Tue, 29 Aug 2023, Tsukasa OI wrote:
> On 2023/08/29 8:09, Hans-Peter Nilsson wrote:
> > On Mon, 28 Aug 2023, Jeff Law via Gcc-patches wrote:
> >>
> >>
> >> On 8/9/23 00:11, Tsukasa OI via Gcc-patches wrote:
> >>> From: Tsukasa OI
> >>>
> >>> This built-in does not imply the 'Xgnuzihintpausestate' extension.
> >>> It does not change architectural state (because all HINTs are prohibited
> >>> from doing that).
> >>>
> >>> gcc/ChangeLog:
> >>>
> >>> * doc/extend.texi: Fix the description of __builtin_riscv_pause.
> >> I've pushed this to the trunk.
> >
> > I randomly noticed a typo: "hart", perhaps for "part"?
> > Not sure though.
> >
> > brgds, H-P
> >
>
> Hi H-P,
>
> As Jeff mentioned you, the word "hart" in the RISC-V world means a
> HARdware Thread and commonly used to represent a hardware-based unit of
> execution.
Thanks for the explanation. Perhaps it's worth telling general
readers of the document that it's a term, by simply decorating
"hart" like @samp{hart} or adding the text "(hardware thread)"?
It's the only grep-hit in the document at this time.
brgds, H-P
Re: [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
On 2023/08/29 8:09, Hans-Peter Nilsson wrote: > On Mon, 28 Aug 2023, Jeff Law via Gcc-patches wrote: >> >> >> On 8/9/23 00:11, Tsukasa OI via Gcc-patches wrote: >>> From: Tsukasa OI >>> >>> This built-in does not imply the 'Xgnuzihintpausestate' extension. >>> It does not change architectural state (because all HINTs are prohibited >>> from doing that). >>> >>> gcc/ChangeLog: >>> >>> * doc/extend.texi: Fix the description of __builtin_riscv_pause. >> I've pushed this to the trunk. > > I randomly noticed a typo: "hart", perhaps for "part"? > Not sure though. > > brgds, H-P > Hi H-P, As Jeff mentioned you, the word "hart" in the RISC-V world means a HARdware Thread and commonly used to represent a hardware-based unit of execution. Tsukasa
Re: [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
On 8/28/23 17:09, Hans-Peter Nilsson wrote: On Mon, 28 Aug 2023, Jeff Law via Gcc-patches wrote: On 8/9/23 00:11, Tsukasa OI via Gcc-patches wrote: From: Tsukasa OI This built-in does not imply the 'Xgnuzihintpausestate' extension. It does not change architectural state (because all HINTs are prohibited from doing that). gcc/ChangeLog: * doc/extend.texi: Fix the description of __builtin_riscv_pause. I've pushed this to the trunk. I randomly noticed a typo: "hart", perhaps for "part"? Not sure though. Not a typo. "hart" has a well defined meaning in the risc-v world. Thanks, jeff
Re: [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
On Mon, 28 Aug 2023, Jeff Law via Gcc-patches wrote: > > > On 8/9/23 00:11, Tsukasa OI via Gcc-patches wrote: > > From: Tsukasa OI > > > > This built-in does not imply the 'Xgnuzihintpausestate' extension. > > It does not change architectural state (because all HINTs are prohibited > > from doing that). > > > > gcc/ChangeLog: > > > > * doc/extend.texi: Fix the description of __builtin_riscv_pause. > I've pushed this to the trunk. I randomly noticed a typo: "hart", perhaps for "part"? Not sure though. brgds, H-P
Re: [RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
On 8/9/23 00:11, Tsukasa OI via Gcc-patches wrote: From: Tsukasa OI This built-in does not imply the 'Xgnuzihintpausestate' extension. It does not change architectural state (because all HINTs are prohibited from doing that). gcc/ChangeLog: * doc/extend.texi: Fix the description of __builtin_riscv_pause. I've pushed this to the trunk. jeff
[RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
From: Tsukasa OI
This built-in does not imply the 'Xgnuzihintpausestate' extension.
It does not change architectural state (because all HINTs are prohibited
from doing that).
gcc/ChangeLog:
* doc/extend.texi: Fix the description of __builtin_riscv_pause.
---
gcc/doc/extend.texi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index 89c5b4ea2b20..7be27430666a 100644
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -21570,9 +21570,9 @@ Returns the value that is currently set in the
@samp{tp} register.
@enddefbuiltin
@defbuiltin{void __builtin_riscv_pause (void)}
-Generates the @code{pause} (hint) machine instruction. This implies the
-Xgnuzihintpausestate extension, which redefines the @code{pause} instruction to
-change architectural state.
+Generates the @code{pause} (hint) machine instruction, indicating that the
+current hart should be temporarily paused or slowed down.
+Available if the Zihintpause extension is enabled.
@enddefbuiltin
@node RISC-V Vector Intrinsics
--
2.41.0
[RFC PATCH 2/2] RISC-V: Fix documentation of __builtin_riscv_pause
From: Tsukasa OI
This built-in does not imply the 'Xgnuzihintpausestate' extension.
It does not change architectural state (because all HINTs are prohibited
from doing that).
gcc/ChangeLog:
* doc/extend.texi: Fix the description of __builtin_riscv_pause.
---
gcc/doc/extend.texi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index 89c5b4ea2b20..7ebbe70c78d6 100644
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -21570,9 +21570,9 @@ Returns the value that is currently set in the
@samp{tp} register.
@enddefbuiltin
@defbuiltin{void __builtin_riscv_pause (void)}
-Generates the @code{pause} (hint) machine instruction. This implies the
-Xgnuzihintpausestate extension, which redefines the @code{pause} instruction to
-change architectural state.
+Generates the @code{pause} (hint) machine instruction. If the target
implements
+the Zihintpause extension, it indicates that the current hart should be
+temporarily paused or slowed down.
@enddefbuiltin
@node RISC-V Vector Intrinsics
--
2.41.0
