Re: [patch] mcore: Fix sprintf length warning
On 5/22/23 17:58, Jan-Benedict Glaw wrote: Hi! One of the supplied argument strings is unneccesarily long (c-sky, using basically the same code, fixed it to a shorter length) and this fixes overflow warnings, as GCC fails to deduce that the full 256 bytes for load_op[] are not used at all. make[1]: Entering directory '/var/lib/laminar/run/gcc-mcore-elf/38/toolchain-build/gcc' [...] /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o mcore.o -MT mcore.o -MMD -MP -MF ./.deps/mcore.TPo ../../gcc/gcc/config/mcore/mcore.cc ../../gcc/gcc/config/mcore/mcore.cc: In function 'const char* output_inline_const(machine_mode, rtx_def**)': ../../gcc/gcc/config/mcore/mcore.cc:1264:24: error: ' ixw ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); |^ ../../gcc/gcc/config/mcore/mcore.cc:1264:21: note: using the range [0, 18446744073709551615] for directive argument 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1264:15: note: 'sprintf' output between 21 and 310 bytes into a destination of size 256 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1261:24: error: ' ixh ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); |^ ../../gcc/gcc/config/mcore/mcore.cc:1261:21: note: using the range [0, 18446744073709551615] for directive argument 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1261:15: note: 'sprintf' output between 21 and 310 bytes into a destination of size 256 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1258:24: error: ' lsli' directive writing 7 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); |^~ ../../gcc/gcc/config/mcore/mcore.cc:1258:21: note: using the range [0, 18446744073709551615] for directive argument 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^~ ../../gcc/gcc/config/mcore/mcore.cc:1258:15: note: 'sprintf' output between 22 and 311 bytes into a destination of size 256 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^ ../../gcc/gcc/config/mcore/mcore.cc:1255:24: error: ' rotli ' directive writing 8 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); |^~~ ../../gcc/gcc/config/mcore/mcore.cc:1255:21: note: using the range [0, 18446744073709551615] for directive argument 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^~~ ../../gcc/gcc/config/mcore/mcore.cc:1255:15: note: 'sprintf' output between 23 and 312 bytes into a destination of size 256 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^~ ../../gcc/gcc/config/mcore/mcore.cc:1252:24: error: '
[patch] mcore: Fix sprintf length warning
Hi! One of the supplied argument strings is unneccesarily long (c-sky, using basically the same code, fixed it to a shorter length) and this fixes overflow warnings, as GCC fails to deduce that the full 256 bytes for load_op[] are not used at all. make[1]: Entering directory '/var/lib/laminar/run/gcc-mcore-elf/38/toolchain-build/gcc' [...] /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o mcore.o -MT mcore.o -MMD -MP -MF ./.deps/mcore.TPo ../../gcc/gcc/config/mcore/mcore.cc ../../gcc/gcc/config/mcore/mcore.cc: In function 'const char* output_inline_const(machine_mode, rtx_def**)': ../../gcc/gcc/config/mcore/mcore.cc:1264:24: error: ' ixw ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); |^ ../../gcc/gcc/config/mcore/mcore.cc:1264:21: note: using the range [0, 18446744073709551615] for directive argument 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1264:15: note: 'sprintf' output between 21 and 310 bytes into a destination of size 256 1264 | sprintf (buf, "%s\n\tixw\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1261:24: error: ' ixh ' directive writing 6 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); |^ ../../gcc/gcc/config/mcore/mcore.cc:1261:21: note: using the range [0, 18446744073709551615] for directive argument 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1261:15: note: 'sprintf' output between 21 and 310 bytes into a destination of size 256 1261 | sprintf (buf, "%s\n\tixh\t%s,%s\t// %ld 0x%lx", load_op, dst_fmt, dst_fmt, value, value); | ^~~~ ../../gcc/gcc/config/mcore/mcore.cc:1258:24: error: ' lsli' directive writing 7 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); |^~ ../../gcc/gcc/config/mcore/mcore.cc:1258:21: note: using the range [0, 18446744073709551615] for directive argument 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^~ ../../gcc/gcc/config/mcore/mcore.cc:1258:15: note: 'sprintf' output between 22 and 311 bytes into a destination of size 256 1258 | sprintf (buf, "%s\n\tlsli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^ ../../gcc/gcc/config/mcore/mcore.cc:1255:24: error: ' rotli ' directive writing 8 bytes into a region of size between 1 and 256 [-Werror=format-overflow=] 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); |^~~ ../../gcc/gcc/config/mcore/mcore.cc:1255:21: note: using the range [0, 18446744073709551615] for directive argument 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^~~ ../../gcc/gcc/config/mcore/mcore.cc:1255:15: note: 'sprintf' output between 23 and 312 bytes into a destination of size 256 1255 | sprintf (buf, "%s\n\trotli\t%s,%%2\t// %ld 0x%lx", load_op, dst_fmt, value, value); | ^~ ../../gcc/gcc/config/mcore/mcore.cc:1252:24: error: ' bclri ' directive writing 8 bytes into a region of size between 1 and
