Re: [patch mingw]: Enable optional thread-model posix for mingw-targets

2011-04-01 Thread Kai Tietz 
2011/3/31 Ralf Wildenhues ralf.wildenh...@gmx.de:
 * Kai Tietz wrote on Thu, Mar 31, 2011 at 12:19:51PM CEST:
 --- gcc.orig/gcc/config.gcc   2011-03-23 21:15:32.0 +0100
 +++ gcc/gcc/config.gcc        2011-03-31 10:50:05.559129000 +0200

 @@ -1420,6 +1420,10 @@ i[34567]86-*-mingw* | x86_64-*-mingw*)
               *)
                       ;;
       esac
 +     if test x$enable_threads = xposix ; then
 +             tm_file=${tm_file} i386/mingw-pthread.h
 +     fi
 +     tm_file=${tm_file} i386/mingw32.h
       # This makes the logic if mingw's or the w64 feature set has to be used
       case ${target} in
               *-w64-*)
 @@ -1486,10 +1490,14 @@ i[34567]86-*-mingw* | x86_64-*-mingw*)
       cxx_target_objs=${cxx_target_objs} winnt-cxx.o msformat-c.o
       default_use_cxa_atexit=yes
       use_gcc_stdint=wrap
 -     case ${enable_threads} in
 -        | yes | win32)       thread_file='win32'
 -       tmake_file=${tmake_file} i386/t-gthr-win32
 -       ;;
 +     case x${enable_threads} in
 +       x | xyes | xwin32)      thread_file='win32'
 +         tmake_file=${tmake_file} i386/t-gthr-win32
 +         ;;
 +       xposix)
 +         thread_file='posix'
 +         tmake_file=i386/t-mingw-pthread ${tmake_file}
 +         ;;
       esac

 For what it's worth, the 'x' escaping is not ever needed for case
 statements (unlike for some 'test' statements), so you can write

  case $enable_threads in
   | yes | win32) ...
  posix) ...
  esac

 Cheers,
 Ralf


Applied patch at revision 171833 with the adjustment Ralf suggested.

Regards,
Kai

Re: [patch mingw]: Enable optional thread-model posix for mingw-targets

2011-03-31 Thread Ralf Wildenhues 
* Kai Tietz wrote on Thu, Mar 31, 2011 at 12:19:51PM CEST:
 --- gcc.orig/gcc/config.gcc   2011-03-23 21:15:32.0 +0100
 +++ gcc/gcc/config.gcc2011-03-31 10:50:05.559129000 +0200

 @@ -1420,6 +1420,10 @@ i[34567]86-*-mingw* | x86_64-*-mingw*)
   *)
   ;;
   esac
 + if test x$enable_threads = xposix ; then
 + tm_file=${tm_file} i386/mingw-pthread.h
 + fi
 + tm_file=${tm_file} i386/mingw32.h
   # This makes the logic if mingw's or the w64 feature set has to be used
   case ${target} in
   *-w64-*)
 @@ -1486,10 +1490,14 @@ i[34567]86-*-mingw* | x86_64-*-mingw*)
   cxx_target_objs=${cxx_target_objs} winnt-cxx.o msformat-c.o
   default_use_cxa_atexit=yes
   use_gcc_stdint=wrap
 - case ${enable_threads} in
 -| yes | win32)   thread_file='win32'
 -   tmake_file=${tmake_file} i386/t-gthr-win32
 -   ;;
 + case x${enable_threads} in
 +   x | xyes | xwin32)  thread_file='win32'
 + tmake_file=${tmake_file} i386/t-gthr-win32
 + ;;
 +   xposix)
 + thread_file='posix'
 + tmake_file=i386/t-mingw-pthread ${tmake_file}
 + ;;
   esac

For what it's worth, the 'x' escaping is not ever needed for case
statements (unlike for some 'test' statements), so you can write

  case $enable_threads in
   | yes | win32) ...
  posix) ...
  esac

Cheers,
Ralf