Re: [testsuite, i386] Fix for PR50185
Hi, This is a ping. Is the patch ok for trunk? Thanks, K On Fri, Aug 26, 2011 at 5:52 PM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Aug 26, 2011 at 6:45 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi guys, Thanks for your objections. HJ, I scanned all AVX2 tests. So, every tests has at least tab which distinguishes it from filename: $ pwd /export/users/kyukhin/ws/gcc/gcc/testsuite/gcc.target/i386 $ grep scan-assembler avx2-* |grep -v \t |wc -l 0 Uros, you're right. Patch contains usless file. Updated one is attached. Thanks, K On Fri, Aug 26, 2011 at 5:04 PM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: According to Jakub's input, I've updated test to scan instruction, not pattern name. Is it ok? Thanks, K On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Thanks, K Please check ALL AVX2 tests to see if they have similar problems. Thanks. -- H.J.
Re: [testsuite, i386] Fix for PR50185
On Tue, Aug 30, 2011 at 8:39 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, This is a ping. Is the patch ok for trunk? OK. Thanks, Uros.
Re: [testsuite, i386] Fix for PR50185
Thank you! Guys who is able to write, could you please check-in my changes? K On Tue, Aug 30, 2011 at 12:12 PM, Uros Bizjak ubiz...@gmail.com wrote: On Tue, Aug 30, 2011 at 8:39 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, This is a ping. Is the patch ok for trunk? OK. Thanks, Uros.
[testsuite, i386] Fix for PR50185
Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Thanks, K pr50185.gcc.patch Description: Binary data
Re: [testsuite, i386] Fix for PR50185
According to Jakub's input, I've updated test to scan instruction, not pattern name. Is it ok? Thanks, K On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Thanks, K pr50185-2.gcc.patch Description: Binary data
Re: [testsuite, i386] Fix for PR50185
On Fri, Aug 26, 2011 at 2:04 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: According to Jakub's input, I've updated test to scan instruction, not pattern name. Is it ok? Thanks, K On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Is this correct ChangeLog? Looking into the patch, you are changing one test to look for insn name, while adding avx2-vpmovmskb-2.c which still looks for pattern name. Please update ChangeLog and/or attached patch. Uros.
Re: [testsuite, i386] Fix for PR50185
On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: According to Jakub's input, I've updated test to scan instruction, not pattern name. Is it ok? Thanks, K On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Thanks, K Please check ALL AVX2 tests to see if they have similar problems. -- H.J.
Re: [testsuite, i386] Fix for PR50185
Hi guys, Thanks for your objections. HJ, I scanned all AVX2 tests. So, every tests has at least tab which distinguishes it from filename: $ pwd /export/users/kyukhin/ws/gcc/gcc/testsuite/gcc.target/i386 $ grep scan-assembler avx2-* |grep -v \t |wc -l 0 Uros, you're right. Patch contains usless file. Updated one is attached. Thanks, K On Fri, Aug 26, 2011 at 5:04 PM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: According to Jakub's input, I've updated test to scan instruction, not pattern name. Is it ok? Thanks, K On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Thanks, K Please check ALL AVX2 tests to see if they have similar problems. -- H.J. pr50185-3.gcc.patch Description: Binary data
Re: [testsuite, i386] Fix for PR50185
On Fri, Aug 26, 2011 at 6:45 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi guys, Thanks for your objections. HJ, I scanned all AVX2 tests. So, every tests has at least tab which distinguishes it from filename: $ pwd /export/users/kyukhin/ws/gcc/gcc/testsuite/gcc.target/i386 $ grep scan-assembler avx2-* |grep -v \t |wc -l 0 Uros, you're right. Patch contains usless file. Updated one is attached. Thanks, K On Fri, Aug 26, 2011 at 5:04 PM, H.J. Lu hjl.to...@gmail.com wrote: On Fri, Aug 26, 2011 at 5:04 AM, Kirill Yukhin kirill.yuk...@gmail.com wrote: According to Jakub's input, I've updated test to scan instruction, not pattern name. Is it ok? Thanks, K On Fri, Aug 26, 2011 at 3:45 PM, Kirill Yukhin kirill.yuk...@gmail.com wrote: Hi, Here is a fix for http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50182 testsuite/ChangeLog entry: 2011-08-26 Kirill Yukhin kirill.yuk...@intel.com PR testsuite/50185 * gcc.target/i386/avx2-vmovmskb-2.c: Rename to ... * gcc.target/i386/avx2-vpmovmskb-2.c: ... this. Update. Test passes. Ok for trunk? Thanks, K Please check ALL AVX2 tests to see if they have similar problems. Thanks. -- H.J.
Re: [testsuite, i386] Fix for PR50185
Hi!
On Fri, Aug 26, 2011 at 06:04:20AM -0700, H.J. Lu wrote:
Please check ALL AVX2 tests to see if they have similar problems.
Checking all current i386 tests revealed another problematic testcase:
grep scan-assembler' [a-z0-9]*' testsuite/gcc.target/i386/*.c | grep
'\(.*\).*\1'
(minmax-*.c only match the path, which will show up only with -g and
I bet many other scan-assembler tests would fail with
RUNTESTFLAGS=--target_board=unix/-g
(matching various stuff in the debug info)).
2011-08-26 Jakub Jelinek ja...@redhat.com
* gcc.target/i386/cmpxchg16b-1.c: Match also space after the
instruction.
--- gcc/testsuite/gcc.target/i386/cmpxchg16b-1.c.jj 2011-07-11
10:39:29.0 +0200
+++ gcc/testsuite/gcc.target/i386/cmpxchg16b-1.c2011-08-26
16:20:46.0 +0200
@@ -10,4 +10,4 @@ void test(TItype x_128)
m_128 = __sync_val_compare_and_swap (m_128, x_128, m_128);
}
-/* { dg-final { scan-assembler cmpxchg16b } } */
+/* { dg-final { scan-assembler cmpxchg16b\[ \\t] } } */
Jakub
