Re: CI for "Option handling: add documentation URLs"
Hi YunQiang Su,
On Fri, Mar 15, 2024 at 03:33:28PM +0800, YunQiang Su wrote:
> Great work. The CI works well now: it blames me ;)
> https://builder.sourceware.org/buildbot/#/builders/269/builds/3846
>
> When I add '-mstrict-align' option to MIPS,
> the riscv.opt.urls, sysv4.opt.urls, xtensa.opt.urls are changed also.
> (why they are effected?
They are effected because they also have a '-mstrict-align' option and
each option with the same name gets an unique number.
> So what's the best practice for this cases?
> Should I push a new commit? Or in fact a single commit is preferred?
I don't know if there is a rule for this. But I hope this falls under
the obvious rule. What I would do is simply take that diff the CI
produced.
https://builder.sourceware.org/buildbot/api/v2/logs/7798308/raw
Apply it and commit that with:
Regenerate opt.urls
Fixes: acc38ff59976 ("MIPS: Add -m(no-)strict-align option")
gcc/ChangeLog:
* config/riscv/riscv.opt.urls: Regenerated.
* config/rs6000/sysv4.opt.urls: Likewise.
* config/xtensa/xtensa.opt.urls: Likewise.
Cheers,
Mark
Re: CI for "Option handling: add documentation URLs"
Great work. The CI works well now: it blames me ;) https://builder.sourceware.org/buildbot/#/builders/269/builds/3846 When I add '-mstrict-align' option to MIPS, the riscv.opt.urls, sysv4.opt.urls, xtensa.opt.urls are changed also. (why they are effected? So what's the best practice for this cases? Should I push a new commit? Or in fact a single commit is preferred? -- YunQiang Su
Re: CI for "Option handling: add documentation URLs"
On Tue, Mar 05, 2024 at 08:34:31AM -0500, David Malcolm wrote: > > I committed that patch, but was not fast enough actually enabling the > > buildbot and missed another fixlet needed first. > > > > OK, to push the attached regeneration patch? > > Yes Thanks, pushed. And now also pushed the builder patch (attached) to enable it in the CI autoregen checker. It already ran without finding any issues. https://builder.sourceware.org/buildbot/#/builders/gcc-autoregen
Re: CI for "Option handling: add documentation URLs"
On Tue, 2024-03-05 at 13:06 +0100, Mark Wielaard wrote: > Hi, > > On Mon, 2024-03-04 at 08:48 -0500, David Malcolm wrote: > > > I have now regenerated the patch to also include the new avr > > > mfuse- > > > add change. It would be nice to get this committed so we can turn > > > on the > > > automatic checker. > > > > Please go ahead with that. > > I committed that patch, but was not fast enough actually enabling the > buildbot and missed another fixlet needed first. > > OK, to push the attached regeneration patch? Yes Thanks Dave
Re: CI for "Option handling: add documentation URLs"
Hi,
On Mon, 2024-03-04 at 08:48 -0500, David Malcolm wrote:
> > I have now regenerated the patch to also include the new avr mfuse-
> > add change. It would be nice to get this committed so we can turn on the
> > automatic checker.
>
> Please go ahead with that.
I committed that patch, but was not fast enough actually enabling the
buildbot and missed another fixlet needed first.
OK, to push the attached regeneration patch?
Thanks,
Mark
From e5c2b9983d7c09e5a21fa587dc9cd03d53d67a23 Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Tue, 5 Mar 2024 13:01:08 +0100
Subject: [PATCH] Regenerate c.opt.urls
Fixes: 08edf85f747b ("c++/modules: relax diagnostic about GMF contents")
gcc/c-family/ChangeLog:
* c.opt.urls: Regenerate.
---
gcc/c-family/c.opt.urls | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls
index 9f97dc61a778..631719863a5e 100644
--- a/gcc/c-family/c.opt.urls
+++ b/gcc/c-family/c.opt.urls
@@ -403,6 +403,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wformat)
Wframe-address
UrlSuffix(gcc/Warning-Options.html#index-Wframe-address)
+Wglobal-module
+UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wglobal-module)
+
Wif-not-aligned
UrlSuffix(gcc/Warning-Options.html#index-Wif-not-aligned)
--
2.44.0
Re: CI for "Option handling: add documentation URLs"
On Sun, 2024-03-03 at 21:04 +0100, Mark Wielaard wrote:
> Hi,
>
> On Sat, Feb 24, 2024 at 06:42:58PM +0100, Mark Wielaard wrote:
> > On Thu, Feb 22, 2024 at 11:57:50AM +0800, YunQiang Su wrote:
> > > Mark Wielaard 于2024年2月19日周一 06:58写道：
> > > > So, I did try the regenerate-opt-urls locally, and it did
> > > > generate the
> > > > attached diff. Which seems to show we really need this
> > > > automated.
> > > >
> > > > Going over the diff. The -Winfinite-recursion in rust does
> > > > indeed seem
> > > > new. As do the -mapx-inline-asm-use-gpr32 and mevex512 for
> > > > i386. And
> > > > the avr options -mskip-bug, -mflmap and mrodata-in-ram. The
> > > > change in
> > > > common.opt.urls for -Wuse-after-free comes from it being moved
> > > > from
> > > > c++ to the c-family. The changes in mips.opt.urls seem to come
> > > > from
> > > > commit 46df1369 "doc/invoke: Remove duplicate explicit-relocs
> > > > entry of
> > > > MIPS".
> > >
> > > For MIPS, it's due to malformed patches to invoke.text.
> > > I will fix them.
> >
> > Thanks. So with your commit 00bc8c0998d8 ("invoke.texi: Fix some
> > skipping UrlSuffix problem for MIPS") pushed now, the attached
> > patch
> > fixes the remaining issues.
> >
> > Is this OK to push?
Thanks, looks good to me.
> Ping.
>
> I have now regenerated the patch to also include the new avr mfuse-
> add
> change. It would be nice to get this committed so we can turn on the
> automatic checker.
Please go ahead with that.
Thanks
Dave
Re: CI for "Option handling: add documentation URLs"
Hi,
On Sat, Feb 24, 2024 at 06:42:58PM +0100, Mark Wielaard wrote:
> On Thu, Feb 22, 2024 at 11:57:50AM +0800, YunQiang Su wrote:
> > Mark Wielaard 于2024年2月19日周一 06:58写道：
> > > So, I did try the regenerate-opt-urls locally, and it did generate the
> > > attached diff. Which seems to show we really need this automated.
> > >
> > > Going over the diff. The -Winfinite-recursion in rust does indeed seem
> > > new. As do the -mapx-inline-asm-use-gpr32 and mevex512 for i386. And
> > > the avr options -mskip-bug, -mflmap and mrodata-in-ram. The change in
> > > common.opt.urls for -Wuse-after-free comes from it being moved from
> > > c++ to the c-family. The changes in mips.opt.urls seem to come from
> > > commit 46df1369 "doc/invoke: Remove duplicate explicit-relocs entry of
> > > MIPS".
> >
> > For MIPS, it's due to malformed patches to invoke.text.
> > I will fix them.
>
> Thanks. So with your commit 00bc8c0998d8 ("invoke.texi: Fix some
> skipping UrlSuffix problem for MIPS") pushed now, the attached patch
> fixes the remaining issues.
>
> Is this OK to push?
Ping.
I have now regenerated the patch to also include the new avr mfuse-add
change. It would be nice to get this committed so we can turn on the
automatic checker.
Thanks,
Mark
>From 84373cd8045e67f0d1716dad899c3463b823ea97 Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Sun, 3 Mar 2024 20:50:32 +0100
Subject: [PATCH] Regenerate opt.urls
There were several commits that didn't regenerate the opt.urls files.
Fixes: 438ef143679e ("rs6000: Neuter option -mpower{8,9}-vector")
Fixes: 50c549ef3db6 ("gccrs: enable -Winfinite-recursion warnings by default")
Fixes: 25bb8a40abd9 ("Move docs for -Wuse-after-free and -Wuseless-cast")
Fixes: 48448055fb70 ("AVR: Support .rodata in Flash for AVR64* and AVR128*")
Fixes: 42503cc257fb ("AVR: Document option -mskip-bug")
Fixes: 7de5bb642c12 ("i386: [APX] Document inline asm behavior and new switch")
Fixes: 49a14ee488b8 ("Add -mevex512 into invoke.texi")
Fixes: 4666cbde5e6d ("Sort warning options in c-family/c.opt.")
Fixes: cda383616183 ("AVR: target/114100 - Better indirect accesses for reduced
Tiny")
gcc/config/
* rs6000/rs6000.opt.urls: Regenerate.
* avr/avr.opt.urls: Likewise.
* i386/i386.opt.urls: Likewise.
* pru/pru.opt.urls: Likewise.
* riscv/riscv.opt.urls: Likewise.
gcc/rust/
* lang.opt.urls: Regenerate.
gcc/
* common.opt.urls: Regenerate.
gcc/c-family/
* c.opt.urls: Regenerate.
---
gcc/c-family/c.opt.urls | 351 +++---
gcc/common.opt.urls | 4 +-
gcc/config/avr/avr.opt.urls | 15 ++
gcc/config/i386/i386.opt.urls | 8 +-
gcc/config/pru/pru.opt.urls | 2 +-
gcc/config/riscv/riscv.opt.urls | 2 +-
gcc/config/rs6000/rs6000.opt.urls | 3 -
gcc/rust/lang.opt.urls| 3 +
8 files changed, 206 insertions(+), 182 deletions(-)
diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls
index 5365c8e2bc54..9f97dc61a778 100644
--- a/gcc/c-family/c.opt.urls
+++ b/gcc/c-family/c.opt.urls
@@ -88,6 +88,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wabsolute-value)
Waddress
UrlSuffix(gcc/Warning-Options.html#index-Waddress)
+Waddress-of-packed-member
+UrlSuffix(gcc/Warning-Options.html#index-Waddress-of-packed-member)
+
Waligned-new
UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Waligned-new)
@@ -115,6 +118,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Walloc-zero)
Walloca-larger-than=
UrlSuffix(gcc/Warning-Options.html#index-Walloca-larger-than_003d)
LangUrlSuffix_D(gdc/Warnings.html#index-Walloca-larger-than)
+Warith-conversion
+UrlSuffix(gcc/Warning-Options.html#index-Warith-conversion)
+
Warray-bounds=
UrlSuffix(gcc/Warning-Options.html#index-Warray-bounds)
@@ -122,13 +128,10 @@ Warray-compare
UrlSuffix(gcc/Warning-Options.html#index-Warray-compare)
Warray-parameter
-UrlSuffix(gcc/Warning-Options.html#index-Wno-array-parameter)
+UrlSuffix(gcc/Warning-Options.html#index-Warray-parameter)
Warray-parameter=
-UrlSuffix(gcc/Warning-Options.html#index-Wno-array-parameter)
-
-Wzero-length-bounds
-UrlSuffix(gcc/Warning-Options.html#index-Wzero-length-bounds)
+UrlSuffix(gcc/Warning-Options.html#index-Warray-parameter)
Wassign-intercept
UrlSuffix(gcc/Objective-C-and-Objective-C_002b_002b-Dialect-Options.html#index-Wassign-intercept)
@@ -148,9 +151,6 @@ UrlSuffix(gcc/Warning-Options.html#index-Wbool-compare)
Wbool-operation
UrlSuffix(gcc/Warning-Options.html#index-Wbool-operation)
-Wframe-address
-UrlSuffix(gcc/Warning-Options.html#index-Wframe-address)
-
Wbuiltin-declaration-mismatch
UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-declaration-mismatch)
LangUrlSuffix_D(gdc/Warnings.html#index-Wbuiltin-declaration-mismatch)
@@ -217,6 +217,12 @@
UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wcatch-value)
Wchar-subscripts
UrlSuffix(gcc/Warning-Options.html#index-Wchar-subscripts)
+Wclass-conversion
+UrlSuffi
Re: CI for "Option handling: add documentation URLs"
Hi,
On Thu, Feb 22, 2024 at 11:57:50AM +0800, YunQiang Su wrote:
> Mark Wielaard 于2024年2月19日周一 06:58写道：
> > So, I did try the regenerate-opt-urls locally, and it did generate the
> > attached diff. Which seems to show we really need this automated.
> >
> > Going over the diff. The -Winfinite-recursion in rust does indeed seem
> > new. As do the -mapx-inline-asm-use-gpr32 and mevex512 for i386. And
> > the avr options -mskip-bug, -mflmap and mrodata-in-ram. The change in
> > common.opt.urls for -Wuse-after-free comes from it being moved from
> > c++ to the c-family. The changes in mips.opt.urls seem to come from
> > commit 46df1369 "doc/invoke: Remove duplicate explicit-relocs entry of
> > MIPS".
> >
>
> For MIPS, it's due to malformed patches to invoke.text.
> I will fix them.
Thanks. So with your commit 00bc8c0998d8 ("invoke.texi: Fix some
skipping UrlSuffix problem for MIPS") pushed now, the attached patch
fixes the remaining issues.
Is this OK to push?
> > The changes in c.opt.urls seem mostly reordering. The sorting makes
> > more sense after the diff imho. And must have come from commit
> > 4666cbde5 "Sort warning options in c-family/c.opt".
> >
> > Also the documentation for -Warray-parameter was fixed.
> >
> > So I think the regenerate-opt-urls check does work as intended. So
> > lets automate it, because it looks like nobody regenerated the
> > url.opts after updating the documentation.
> >
> > But we should first apply this diff. Could you double check it is
> > sane/correct?
> >
> > Thanks,
> >
> > Mark
>
>
>
> --
> YunQiang Su
>From c019327e919fff87ffa94799e8f521bda707a883 Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Sat, 24 Feb 2024 17:34:05 +0100
Subject: [PATCH] Regenerate opt.urls
There were several commits that didn't regenerate the opt.urls files.
Fixes: 438ef143679e ("rs6000: Neuter option -mpower{8,9}-vector")
Fixes: 50c549ef3db6 ("gccrs: enable -Winfinite-recursion warnings by default")
Fixes: 25bb8a40abd9 ("Move docs for -Wuse-after-free and -Wuseless-cast")
Fixes: 48448055fb70 ("AVR: Support .rodata in Flash for AVR64* and AVR128*")
Fixes: 42503cc257fb ("AVR: Document option -mskip-bug")
Fixes: 7de5bb642c12 ("i386: [APX] Document inline asm behavior and new switch")
Fixes: 49a14ee488b8 ("Add -mevex512 into invoke.texi")
Fixes: 4666cbde5e6d ("Sort warning options in c-family/c.opt.")
gcc/config/
* rs6000/rs6000.opt.urls: Regenerate.
* avr/avr.opt.urls: Likewise.
* i386/i386.opt.urls: Likewise.
* pru/pru.opt.urls: Likewise.
* riscv/riscv.opt.urls: Likewise.
gcc/rust/
* lang.opt.urls: Regenerate.
gcc/
* common.opt.urls: Regenerate.
gcc/c-family/
* c.opt.urls: Regenerate.
---
gcc/c-family/c.opt.urls | 351 +++---
gcc/common.opt.urls | 4 +-
gcc/config/avr/avr.opt.urls | 9 +
gcc/config/i386/i386.opt.urls | 8 +-
gcc/config/pru/pru.opt.urls | 2 +-
gcc/config/riscv/riscv.opt.urls | 2 +-
gcc/config/rs6000/rs6000.opt.urls | 3 -
gcc/rust/lang.opt.urls| 3 +
8 files changed, 200 insertions(+), 182 deletions(-)
diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls
index 5365c8e2bc54..9f97dc61a778 100644
--- a/gcc/c-family/c.opt.urls
+++ b/gcc/c-family/c.opt.urls
@@ -88,6 +88,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wabsolute-value)
Waddress
UrlSuffix(gcc/Warning-Options.html#index-Waddress)
+Waddress-of-packed-member
+UrlSuffix(gcc/Warning-Options.html#index-Waddress-of-packed-member)
+
Waligned-new
UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Waligned-new)
@@ -115,6 +118,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Walloc-zero)
Walloca-larger-than=
UrlSuffix(gcc/Warning-Options.html#index-Walloca-larger-than_003d)
LangUrlSuffix_D(gdc/Warnings.html#index-Walloca-larger-than)
+Warith-conversion
+UrlSuffix(gcc/Warning-Options.html#index-Warith-conversion)
+
Warray-bounds=
UrlSuffix(gcc/Warning-Options.html#index-Warray-bounds)
@@ -122,13 +128,10 @@ Warray-compare
UrlSuffix(gcc/Warning-Options.html#index-Warray-compare)
Warray-parameter
-UrlSuffix(gcc/Warning-Options.html#index-Wno-array-parameter)
+UrlSuffix(gcc/Warning-Options.html#index-Warray-parameter)
Warray-parameter=
-UrlSuffix(gcc/Warning-Options.html#index-Wno-array-parameter)
-
-Wzero-length-bounds
-UrlSuffix(gcc/Warning-Options.html#index-Wzero-length-bounds)
+UrlSuffix(gcc/Warning-Options.html#index-Warray-parameter)
Wassign-intercept
UrlSuffix(gcc/Objective-C-and-Objective-C_002b_002b-Dialect-Options.html#index-Wassign-intercept)
@@ -148,9 +151,6 @@ UrlSuffix(gcc/Warning-Options.html#index-Wbool-compare)
Wbool-operation
UrlSuffix(gcc/Warning-Options.html#index-Wbool-operation)
-Wframe-address
-UrlSuffix(gcc/Warning-Options.html#index-Wframe-address)
-
Wbuiltin-declaration-mismatch
UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-declaration-mismatch)
LangUrlSuffix_D(gdc/Warnings.html#index-Wb
Re: CI for "Option handling: add documentation URLs"
Mark Wielaard 于2024年2月19日周一 06:58写道： > > Hi David, > > On Thu, Jan 04, 2024 at 09:57:09AM -0500, David Malcolm wrote: > > I've pushed the .opt.urls patch kit to gcc trunk [1], so hopefully the > > CI check you wrote can go live now. > > And then I was on vacation myself and forgot. I am sorry. > > So, I did try the regenerate-opt-urls locally, and it did generate the > attached diff. Which seems to show we really need this automated. > > Going over the diff. The -Winfinite-recursion in rust does indeed seem > new. As do the -mapx-inline-asm-use-gpr32 and mevex512 for i386. And > the avr options -mskip-bug, -mflmap and mrodata-in-ram. The change in > common.opt.urls for -Wuse-after-free comes from it being moved from > c++ to the c-family. The changes in mips.opt.urls seem to come from > commit 46df1369 "doc/invoke: Remove duplicate explicit-relocs entry of > MIPS". > For MIPS, it's due to malformed patches to invoke.text. I will fix them. > The changes in c.opt.urls seem mostly reordering. The sorting makes > more sense after the diff imho. And must have come from commit > 4666cbde5 "Sort warning options in c-family/c.opt". > > Also the documentation for -Warray-parameter was fixed. > > So I think the regenerate-opt-urls check does work as intended. So > lets automate it, because it looks like nobody regenerated the > url.opts after updating the documentation. > > But we should first apply this diff. Could you double check it is > sane/correct? > > Thanks, > > Mark -- YunQiang Su
Re: CI for "Option handling: add documentation URLs"
On Sun, 2024-02-18 at 23:58 +0100, Mark Wielaard wrote: > So I think the regenerate-opt-urls check does work as intended. So > lets automate it, because it looks like nobody regenerated the > url.opts after updating the documentation. > > But we should first apply this diff. Could you double check it is > sane/correct? And then I forgot to attach the diff. Attached now. Hopefully it is identical for you after doing make html && cd gcc && make regenerate-opt-urls (It is for me having now done it on a debian and fedora x86_64 setup.) Cheers, Mark diff --git a/gcc/c-family/c.opt.urls b/gcc/c-family/c.opt.urls index 5365c8e2bc5..9f97dc61a77 100644 --- a/gcc/c-family/c.opt.urls +++ b/gcc/c-family/c.opt.urls @@ -88,6 +88,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wabsolute-value) Waddress UrlSuffix(gcc/Warning-Options.html#index-Waddress) +Waddress-of-packed-member +UrlSuffix(gcc/Warning-Options.html#index-Waddress-of-packed-member) + Waligned-new UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Waligned-new) @@ -115,6 +118,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Walloc-zero) Walloca-larger-than= UrlSuffix(gcc/Warning-Options.html#index-Walloca-larger-than_003d) LangUrlSuffix_D(gdc/Warnings.html#index-Walloca-larger-than) +Warith-conversion +UrlSuffix(gcc/Warning-Options.html#index-Warith-conversion) + Warray-bounds= UrlSuffix(gcc/Warning-Options.html#index-Warray-bounds) @@ -122,13 +128,10 @@ Warray-compare UrlSuffix(gcc/Warning-Options.html#index-Warray-compare) Warray-parameter -UrlSuffix(gcc/Warning-Options.html#index-Wno-array-parameter) +UrlSuffix(gcc/Warning-Options.html#index-Warray-parameter) Warray-parameter= -UrlSuffix(gcc/Warning-Options.html#index-Wno-array-parameter) - -Wzero-length-bounds -UrlSuffix(gcc/Warning-Options.html#index-Wzero-length-bounds) +UrlSuffix(gcc/Warning-Options.html#index-Warray-parameter) Wassign-intercept UrlSuffix(gcc/Objective-C-and-Objective-C_002b_002b-Dialect-Options.html#index-Wassign-intercept) @@ -148,9 +151,6 @@ UrlSuffix(gcc/Warning-Options.html#index-Wbool-compare) Wbool-operation UrlSuffix(gcc/Warning-Options.html#index-Wbool-operation) -Wframe-address -UrlSuffix(gcc/Warning-Options.html#index-Wframe-address) - Wbuiltin-declaration-mismatch UrlSuffix(gcc/Warning-Options.html#index-Wbuiltin-declaration-mismatch) LangUrlSuffix_D(gdc/Warnings.html#index-Wbuiltin-declaration-mismatch) @@ -217,6 +217,12 @@ UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wcatch-value) Wchar-subscripts UrlSuffix(gcc/Warning-Options.html#index-Wchar-subscripts) +Wclass-conversion +UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wclass-conversion) + +Wclass-memaccess +UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wclass-memaccess) + Wclobbered UrlSuffix(gcc/Warning-Options.html#index-Wclobbered) @@ -298,6 +304,12 @@ UrlSuffix(gcc/Warning-Options.html#index-Wdiscarded-qualifiers) Wdiv-by-zero UrlSuffix(gcc/Warning-Options.html#index-Wdiv-by-zero) +Wdouble-promotion +UrlSuffix(gcc/Warning-Options.html#index-Wdouble-promotion) + +Wduplicate-decl-specifier +UrlSuffix(gcc/Warning-Options.html#index-Wduplicate-decl-specifier) + Wduplicated-branches UrlSuffix(gcc/Warning-Options.html#index-Wduplicated-branches) @@ -307,6 +319,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wduplicated-cond) Weffc++ UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Weffc_002b_002b) +Welaborated-enum-base +UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Welaborated-enum-base) + Wempty-body UrlSuffix(gcc/Warning-Options.html#index-Wempty-body) @@ -328,12 +343,18 @@ UrlSuffix(gcc/Warning-Options.html#index-Werror) LangUrlSuffix_D(gdc/Warnings.ht Wexceptions UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wexceptions) +Wexpansion-to-defined +UrlSuffix(gcc/Warning-Options.html#index-Wexpansion-to-defined) + Wextra UrlSuffix(gcc/Warning-Options.html#index-Wextra) LangUrlSuffix_D(gdc/Warnings.html#index-Wextra) Wextra-semi UrlSuffix(gcc/C_002b_002b-Dialect-Options.html#index-Wextra-semi) +Wflex-array-member-not-at-end +UrlSuffix(gcc/Warning-Options.html#index-Wflex-array-member-not-at-end) + Wfloat-conversion UrlSuffix(gcc/Warning-Options.html#index-Wfloat-conversion) @@ -355,6 +376,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wformat-nonliteral) Wformat-overflow UrlSuffix(gcc/Warning-Options.html#index-Wformat-overflow) +Wformat-overflow= +UrlSuffix(gcc/Warning-Options.html#index-Wformat-overflow) + Wformat-security UrlSuffix(gcc/Warning-Options.html#index-Wformat-security) @@ -364,6 +388,9 @@ UrlSuffix(gcc/Warning-Options.html#index-Wformat-signedness) Wformat-truncation UrlSuffix(gcc/Warning-Options.html#index-Wformat-truncation) +Wformat-truncation= +UrlSuffix(gcc/Warning-Options.html#index-Wformat-truncation) + Wformat-y2k UrlSuffix(gcc/Warning-Options.html#index-Wformat-y2k) @@ -373,14 +400,8 @@ UrlSuffix(gcc/Warning-Options.html#index-Wformat-zero-length) Wformat= UrlSuffix(g
Re: CI for "Option handling: add documentation URLs"
Hi David, On Thu, Jan 04, 2024 at 09:57:09AM -0500, David Malcolm wrote: > I've pushed the .opt.urls patch kit to gcc trunk [1], so hopefully the > CI check you wrote can go live now. And then I was on vacation myself and forgot. I am sorry. So, I did try the regenerate-opt-urls locally, and it did generate the attached diff. Which seems to show we really need this automated. Going over the diff. The -Winfinite-recursion in rust does indeed seem new. As do the -mapx-inline-asm-use-gpr32 and mevex512 for i386. And the avr options -mskip-bug, -mflmap and mrodata-in-ram. The change in common.opt.urls for -Wuse-after-free comes from it being moved from c++ to the c-family. The changes in mips.opt.urls seem to come from commit 46df1369 "doc/invoke: Remove duplicate explicit-relocs entry of MIPS". The changes in c.opt.urls seem mostly reordering. The sorting makes more sense after the diff imho. And must have come from commit 4666cbde5 "Sort warning options in c-family/c.opt". Also the documentation for -Warray-parameter was fixed. So I think the regenerate-opt-urls check does work as intended. So lets automate it, because it looks like nobody regenerated the url.opts after updating the documentation. But we should first apply this diff. Could you double check it is sane/correct? Thanks, Mark
CI for "Option handling: add documentation URLs"
On Fri, 2023-12-15 at 01:59 +0100, Mark Wielaard wrote: > Hi David, > > On Thu, Dec 14, 2023 at 10:01:39AM -0500, David Malcolm wrote: > > > Once your patch is in please feel free to sent an email to > > > build...@sourceware.org > > > https://sourceware.org/mailman/listinfo/buildbot > > > And we'll add the above build steps and update the autotools > > > Containerfile to include the fortran (gfortran?) and d (gdc?) > > > build > > > dependencies. > > > > Joseph: it seems that we have a way to add CI for this. > > > > I refreshed the patches and successfully bootstrapped & regrtested > > them > > on x86_64-pc-linux-gnu; here's the v3 version of them. > > > > Are these OK for trunk, assuming I followup with adding CI for > > this? > > (that said, I disappear for the rest of 2023 at the end of this > > week, so > > I'd work on the CI in early January) > > I will be around next week to fixup any CI issues. > But once you commit this we can immediate activate the check. > > I have attached a patch for the gcc-autoregen builder to also do > regenerate-opt-urls. Since it is a --disable-bootstrap build and uses > ccache it should take just a few minutes. So can be done on every > commit. > > Note that with you patch applied to master it does flag and generate > the attached diff (I assume that is expected). Hi Mark I've pushed the .opt.urls patch kit to gcc trunk [1], so hopefully the CI check you wrote can go live now. Dave [1], specifically, as these four commits: options: add gcc/regenerate-opt-urls.py: r14-6920-g9e49746da303b8 Add generated .opt.urls files: r14-6921-g5bb18475a10d05 opts: add logic to generate options-urls.cc: r14-6922-g6ecc1e32353e33 options: wire up options-urls.cc into gcc_urlifier: r14-6923-g4ded42c2c5a5c9
