Re: Fortran : Fortran translation issues PR52279
Mark,
A full bootstrap is successful with the translation markers restored
and declaring hint as "const char *".
const char *hint = _(" [see %<-fno-allow-invalid-boz%>]");
I assume that the translation system works correctly for that style.
Do you want to apply the patch or do you want me to?
Thanks, David
On Thu, Jul 2, 2020 at 11:47 AM David Edelsohn wrote:
>
> Mark,
>
> A quick test with
>
> const char hint [] = _(" [see %<-fno-allow-invalid-boz%>]");
>
> reproduces the failure.
>
> const char *hint = _(" [see %<-fno-allow-invalid-boz%>]");
>
> seems to work. I will do a full bootstrap test with that change later today.
>
> Do you want me to commit it if it works or do you want me to report it to you?
>
> Thanks, David
>
> On Thu, Jul 2, 2020 at 9:38 AM David Edelsohn wrote:
> >
> > On Thu, Jul 2, 2020 at 8:56 AM Mark Eggleston
> > wrote:
> > >
> > > On 02/07/2020 13:25, David Edelsohn wrote:
> > > > On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston
> > > > wrote:
> > > >> I've committed the change from array to pointer. Does this fix your
> > > >> builds?
> > > >>
> > > >> On 02/07/2020 08:18, Mark Eggleston wrote:
> > > >>> On 01/07/2020 20:07, David Edelsohn wrote:
> > > This patch breaks bootstrap.
> > > >>> Apologies. I didn't see this when I built the compiler the with
> > > >>> bootstrap on x86_64. I'll endevour to get it fixed as soon as
> > > >>> possible.
> > > > Mark,
> > > >
> > > > Your change did nothing because I previously had removed the
> > > > translation markers to restore bootstrap. You were not sufficiently
> > > > observant to check the ChangeLog or notice that the line already was
> > > > changed.
> > > >
> > > > Please stop making random, untested changes. This is inappropriate
> > > > for GCC development.
> > > OK. I had no way of confirming as the bootstrap worked for me. I naively
> > > thought that it was covered as an "obvious" fix.
> > >
> > > I was concerned that I caused a breakage and wanted to fix it.
> > >
> > > Regarding the ChangeLog I was unfamiliar with this situation and will
> > > check them if this ever happens again (I hope not). I'll also keep
> > > portability issues in mind.
> > >
> > > I see the issue of the incorrect hint text has been addressed. As I
> > > understand it the string as is will not make it to the pot file so will
> > > not be translated, is that acceptable? I would like to be able to close
> > > the PR.
> >
> > Mark,
> >
> > I reverted your change for that one line to restore bootstrap for
> > everyone because Trunk should not be broken for 6 hours and it was
> > trivial to revert that one, localized change without affecting the
> > rest of your patch.
> >
> > The translation message for hint should be in the pot file
> > translation. This needs to be fixed correctly.
> >
> > I would suggest that you restore your original change and work to
> > reproduce the failure. I don't know if you were not building with NLS
> > or had some other local configuration. It seems that
> >
> > hint[] = _("...")
> >
> > cannot be valid C syntax unless _( ... ) is a no-op in your build and
> > the compiler sees a constant string. The failure occurred for many
> > other developers.
> >
> > Thanks, David
Re: Fortran : Fortran translation issues PR52279
Mark,
A quick test with
const char hint [] = _(" [see %<-fno-allow-invalid-boz%>]");
reproduces the failure.
const char *hint = _(" [see %<-fno-allow-invalid-boz%>]");
seems to work. I will do a full bootstrap test with that change later today.
Do you want me to commit it if it works or do you want me to report it to you?
Thanks, David
On Thu, Jul 2, 2020 at 9:38 AM David Edelsohn wrote:
>
> On Thu, Jul 2, 2020 at 8:56 AM Mark Eggleston
> wrote:
> >
> > On 02/07/2020 13:25, David Edelsohn wrote:
> > > On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston
> > > wrote:
> > >> I've committed the change from array to pointer. Does this fix your
> > >> builds?
> > >>
> > >> On 02/07/2020 08:18, Mark Eggleston wrote:
> > >>> On 01/07/2020 20:07, David Edelsohn wrote:
> > This patch breaks bootstrap.
> > >>> Apologies. I didn't see this when I built the compiler the with
> > >>> bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
> > > Mark,
> > >
> > > Your change did nothing because I previously had removed the
> > > translation markers to restore bootstrap. You were not sufficiently
> > > observant to check the ChangeLog or notice that the line already was
> > > changed.
> > >
> > > Please stop making random, untested changes. This is inappropriate
> > > for GCC development.
> > OK. I had no way of confirming as the bootstrap worked for me. I naively
> > thought that it was covered as an "obvious" fix.
> >
> > I was concerned that I caused a breakage and wanted to fix it.
> >
> > Regarding the ChangeLog I was unfamiliar with this situation and will
> > check them if this ever happens again (I hope not). I'll also keep
> > portability issues in mind.
> >
> > I see the issue of the incorrect hint text has been addressed. As I
> > understand it the string as is will not make it to the pot file so will
> > not be translated, is that acceptable? I would like to be able to close
> > the PR.
>
> Mark,
>
> I reverted your change for that one line to restore bootstrap for
> everyone because Trunk should not be broken for 6 hours and it was
> trivial to revert that one, localized change without affecting the
> rest of your patch.
>
> The translation message for hint should be in the pot file
> translation. This needs to be fixed correctly.
>
> I would suggest that you restore your original change and work to
> reproduce the failure. I don't know if you were not building with NLS
> or had some other local configuration. It seems that
>
> hint[] = _("...")
>
> cannot be valid C syntax unless _( ... ) is a no-op in your build and
> the compiler sees a constant string. The failure occurred for many
> other developers.
>
> Thanks, David
Re: Fortran : Fortran translation issues PR52279
On Thu, Jul 2, 2020 at 8:56 AM Mark Eggleston
wrote:
>
> On 02/07/2020 13:25, David Edelsohn wrote:
> > On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston
> > wrote:
> >> I've committed the change from array to pointer. Does this fix your builds?
> >>
> >> On 02/07/2020 08:18, Mark Eggleston wrote:
> >>> On 01/07/2020 20:07, David Edelsohn wrote:
> This patch breaks bootstrap.
> >>> Apologies. I didn't see this when I built the compiler the with
> >>> bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
> > Mark,
> >
> > Your change did nothing because I previously had removed the
> > translation markers to restore bootstrap. You were not sufficiently
> > observant to check the ChangeLog or notice that the line already was
> > changed.
> >
> > Please stop making random, untested changes. This is inappropriate
> > for GCC development.
> OK. I had no way of confirming as the bootstrap worked for me. I naively
> thought that it was covered as an "obvious" fix.
>
> I was concerned that I caused a breakage and wanted to fix it.
>
> Regarding the ChangeLog I was unfamiliar with this situation and will
> check them if this ever happens again (I hope not). I'll also keep
> portability issues in mind.
>
> I see the issue of the incorrect hint text has been addressed. As I
> understand it the string as is will not make it to the pot file so will
> not be translated, is that acceptable? I would like to be able to close
> the PR.
Mark,
I reverted your change for that one line to restore bootstrap for
everyone because Trunk should not be broken for 6 hours and it was
trivial to revert that one, localized change without affecting the
rest of your patch.
The translation message for hint should be in the pot file
translation. This needs to be fixed correctly.
I would suggest that you restore your original change and work to
reproduce the failure. I don't know if you were not building with NLS
or had some other local configuration. It seems that
hint[] = _("...")
cannot be valid C syntax unless _( ... ) is a no-op in your build and
the compiler sees a constant string. The failure occurred for many
other developers.
Thanks, David
Re: Fortran : Fortran translation issues PR52279
On 02/07/2020 13:56, Mark Eggleston wrote: On 02/07/2020 13:25, David Edelsohn wrote: On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston wrote: I've committed the change from array to pointer. Does this fix your builds? On 02/07/2020 08:18, Mark Eggleston wrote: On 01/07/2020 20:07, David Edelsohn wrote: This patch breaks bootstrap. Apologies. I didn't see this when I built the compiler the with bootstrap on x86_64. I'll endevour to get it fixed as soon as possible. Mark, Your change did nothing because I previously had removed the translation markers to restore bootstrap. You were not sufficiently observant to check the ChangeLog or notice that the line already was changed. Please stop making random, untested changes. This is inappropriate for GCC development. OK. I had no way of confirming as the bootstrap worked for me. I naively thought that it was covered as an "obvious" fix. I was concerned that I caused a breakage and wanted to fix it. Regarding the ChangeLog I was unfamiliar with this situation and will check them if this ever happens again (I hope not). I'll also keep portability issues in mind. I see the issue of the incorrect hint text has been addressed. whoops that's not true. As I understand it the string as is will not make it to the pot file so will not be translated, is that acceptable? I would like to be able to close the PR. regards, Mark Thanks, David -- https://www.codethink.co.uk/privacy.html
Re: Fortran : Fortran translation issues PR52279
On 02/07/2020 13:25, David Edelsohn wrote: On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston wrote: I've committed the change from array to pointer. Does this fix your builds? On 02/07/2020 08:18, Mark Eggleston wrote: On 01/07/2020 20:07, David Edelsohn wrote: This patch breaks bootstrap. Apologies. I didn't see this when I built the compiler the with bootstrap on x86_64. I'll endevour to get it fixed as soon as possible. Mark, Your change did nothing because I previously had removed the translation markers to restore bootstrap. You were not sufficiently observant to check the ChangeLog or notice that the line already was changed. Please stop making random, untested changes. This is inappropriate for GCC development. OK. I had no way of confirming as the bootstrap worked for me. I naively thought that it was covered as an "obvious" fix. I was concerned that I caused a breakage and wanted to fix it. Regarding the ChangeLog I was unfamiliar with this situation and will check them if this ever happens again (I hope not). I'll also keep portability issues in mind. I see the issue of the incorrect hint text has been addressed. As I understand it the string as is will not make it to the pot file so will not be translated, is that acceptable? I would like to be able to close the PR. regards, Mark Thanks, David -- https://www.codethink.co.uk/privacy.html
Re: Fortran : Fortran translation issues PR52279
On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston wrote: > > I've committed the change from array to pointer. Does this fix your builds? > > On 02/07/2020 08:18, Mark Eggleston wrote: > > On 01/07/2020 20:07, David Edelsohn wrote: > >> This patch breaks bootstrap. > > > > Apologies. I didn't see this when I built the compiler the with > > bootstrap on x86_64. I'll endevour to get it fixed as soon as possible. Mark, Your change did nothing because I previously had removed the translation markers to restore bootstrap. You were not sufficiently observant to check the ChangeLog or notice that the line already was changed. Please stop making random, untested changes. This is inappropriate for GCC development. Thanks, David
Re: Fortran : Fortran translation issues PR52279
I already had removed your change. I hope that you did not re-break bootstrap.
You should be re-producing the breakage and then confirming the fix,
not randomly applying patches and asking others if you didn't break it
again. That is not appropriate for GCC development.
Thanks David
On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston
wrote:
>
> I've committed the change from array to pointer. Does this fix your builds?
>
> On 02/07/2020 08:18, Mark Eggleston wrote:
> > On 01/07/2020 20:07, David Edelsohn wrote:
> >> This patch breaks bootstrap.
> >
> > Apologies. I didn't see this when I built the compiler the with
> > bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
> >
> > regards,
> >
> > Mark
> >
> >> It is not portable to use _( ... ) to initialize an array.
> >>
> >> In file included from
> >> /nasfarm/edelsohn/src/src/gcc/fortran/gfortran.h:52,
> >> from /nasfarm/edelsohn/src/src/gcc/fortran/check.c:32:
> >> /nasfarm/edelsohn/src/src/gcc/fortran/check.c: In function 'bool
> >> gfc_invalid_boz
> >> (const char*, locus*)':
> >> /nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: initializer fails
> >> to determine size of 'hint'
> >> 51 | # define _(msgid) gettext (msgid)
> >>| ^~~
> >> /nasfarm/edelsohn/src/src/gcc/fortran/check.c:70:23: note: in
> >> expansion of macro
> >> '_'
> >> 70 | const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");
> >>| ^
> >> /nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: array must be
> >> initialized with a brace-enclosed initializer
> >>
> --
> https://www.codethink.co.uk/privacy.html
>
Re: Fortran : Fortran translation issues PR52279
I've committed the change from array to pointer. Does this fix your builds?
On 02/07/2020 08:18, Mark Eggleston wrote:
On 01/07/2020 20:07, David Edelsohn wrote:
This patch breaks bootstrap.
Apologies. I didn't see this when I built the compiler the with
bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
regards,
Mark
It is not portable to use _( ... ) to initialize an array.
In file included from
/nasfarm/edelsohn/src/src/gcc/fortran/gfortran.h:52,
from /nasfarm/edelsohn/src/src/gcc/fortran/check.c:32:
/nasfarm/edelsohn/src/src/gcc/fortran/check.c: In function 'bool
gfc_invalid_boz
(const char*, locus*)':
/nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: initializer fails
to determine size of 'hint'
51 | # define _(msgid) gettext (msgid)
| ^~~
/nasfarm/edelsohn/src/src/gcc/fortran/check.c:70:23: note: in
expansion of macro
'_'
70 | const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");
| ^
/nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: array must be
initialized with a brace-enclosed initializer
--
https://www.codethink.co.uk/privacy.html
Re: Fortran : Fortran translation issues PR52279
On 01/07/2020 20:07, David Edelsohn wrote:
This patch breaks bootstrap.
Apologies. I didn't see this when I built the compiler the with
bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
regards,
Mark
It is not portable to use _( ... ) to initialize an array.
In file included from /nasfarm/edelsohn/src/src/gcc/fortran/gfortran.h:52,
from /nasfarm/edelsohn/src/src/gcc/fortran/check.c:32:
/nasfarm/edelsohn/src/src/gcc/fortran/check.c: In function 'bool gfc_invalid_boz
(const char*, locus*)':
/nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: initializer fails
to determine size of 'hint'
51 | # define _(msgid) gettext (msgid)
| ^~~
/nasfarm/edelsohn/src/src/gcc/fortran/check.c:70:23: note: in expansion of macro
'_'
70 | const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");
| ^
/nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: array must be
initialized with a brace-enclosed initializer
--
https://www.codethink.co.uk/privacy.html
Re: Fortran : Fortran translation issues PR52279
This patch breaks bootstrap.
It is not portable to use _( ... ) to initialize an array.
In file included from /nasfarm/edelsohn/src/src/gcc/fortran/gfortran.h:52,
from /nasfarm/edelsohn/src/src/gcc/fortran/check.c:32:
/nasfarm/edelsohn/src/src/gcc/fortran/check.c: In function 'bool gfc_invalid_boz
(const char*, locus*)':
/nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: initializer fails
to determine size of 'hint'
51 | # define _(msgid) gettext (msgid)
| ^~~
/nasfarm/edelsohn/src/src/gcc/fortran/check.c:70:23: note: in expansion of macro
'_'
70 | const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");
| ^
/nasfarm/edelsohn/src/src/gcc/intl.h:51:27: error: array must be
initialized with a brace-enclosed initializer
Re: Fortran : Fortran translation issues PR52279
Hi Mark,
I suspect this change may be behind a bootstrap failure I'm seeing.
My guess is that the hint needs to be a pointer rather than an array.
Thanks
Martin
In file included from /ssd/test/src/gcc/trunk/gcc/fortran/gfortran.h:52,
from /ssd/test/src/gcc/trunk/gcc/fortran/check.c:32:
/ssd/test/src/gcc/trunk/gcc/fortran/check.c: In function ‘bool
gfc_invalid_boz(const char*, locus*)’:
/ssd/test/src/gcc/trunk/gcc/intl.h:51:27: error: initializer fails to
determine size of ‘hint’
51 | # define _(msgid) gettext (msgid)
| ^~~
/ssd/test/src/gcc/trunk/gcc/fortran/check.c:70:23: note: in expansion of
macro ‘_’
70 | const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");
| ^
/ssd/test/src/gcc/trunk/gcc/intl.h:51:27: error: array must be
initialized with a brace-enclosed initializer
51 | # define _(msgid) gettext (msgid)
| ^~~
/ssd/test/src/gcc/trunk/gcc/fortran/check.c:70:23: note: in expansion of
macro ‘_’
70 | const char hint[] = _(" [see %<-fno-allow-invalid-boz%>]");
| ^
On 6/30/20 6:59 AM, Mark Eggleston wrote:
ping!
On 25/06/2020 07:28, Mark Eggleston wrote:
Patch to fix PR52279. Marked strings that are indirectly used in
error and warning messages so that they are marked for translation.
OK to commit?
Commit message:
Fortran : Fortran translation issues PR52279
Mark strings for translation by enclosing in G_() and _().
2020-06-24 Mark Eggleston
gcc/fortran/
PR fortran/52279
* arith.c (reduce_binary_aa): Mark for translation the string
parameter to gfc_check_conformance with G_().
* check.c (gfc_invalid_boz): Mark hint for translation using
_(). (gfc_check_achar): Mark for translation the message
parameter to gfc_invalid_boz using G_(). (gfc_check_char):
Mark for translation the message parameter to gfc_invalid_boz
using G_(). (gfc_check_complex): Mark for translation the
message parameter to gfc_invalid_boz using G_().
(gfc_check_float): Mark for translation the message
parameter to gfc_invalid_boz using G_(). (check_rest): Mark
for translation the string parameter to gfc_check_conformance
with _(). (gfc_check_minloc_maxloc): Mark for translation
the string parameter to gfc_check_conformance with _().
(gfc_check_findloc): Mark for translation the string parameter
to gfc_check_conformance with _(). (check_reduction): Mark
for translation the string parameter to gfc_check_conformance
with _(). (gfc_check_pack): Mark for translation the string
parameter to gfc_check_conformance with _().
* decl.c (match_old_style_init): Mark for translation the
message parameter to gfc_invalid_boz using G_().
* decl.c (gfc_check_assign): Mark for translation the string
parameter to gfc_check_conformance with _().
* intrinsic.c (check_specific): Mark for translation the string
parameter to gfc_check_conformance with _().
(gfc_check_intrinsic_standard): Mark symstd_msg strings for
translation using G_(). No need to mark symstd_msg for
translation in call to gfc_warning or when setting symstd.
* io.c (check_open_constraints): Mark strings for translation
using G_() in all calls to warn_or_error. (match_io_element):
Mark for translation the message parameter to gfc_invalid_boz
using G_().
* primary.c (match_boz_constant): Mark for translation the
message parameter to gfc_invalid_boz using G_().
* resolve.c (resolve_elemental_actual): Mark for translation
the string parameter to gfc_check_conformance with _().
(resolve_operator): Mark for translation the string parameter
to gfc_check_conformance with _(). Mark translation strings
assigned to msg using G_() for use in a call to cfg_warning.
Re: Fortran : Fortran translation issues PR52279
Hi Mark, that one is OK for master. Thanks! Regards Thomas
Re: Fortran : Fortran translation issues PR52279
ping! On 25/06/2020 07:28, Mark Eggleston wrote: Patch to fix PR52279. Marked strings that are indirectly used in error and warning messages so that they are marked for translation. OK to commit? Commit message: Fortran : Fortran translation issues PR52279 Mark strings for translation by enclosing in G_() and _(). 2020-06-24 Mark Eggleston gcc/fortran/ PR fortran/52279 * arith.c (reduce_binary_aa): Mark for translation the string parameter to gfc_check_conformance with G_(). * check.c (gfc_invalid_boz): Mark hint for translation using _(). (gfc_check_achar): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_char): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_complex): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_float): Mark for translation the message parameter to gfc_invalid_boz using G_(). (check_rest): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_minloc_maxloc): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_findloc): Mark for translation the string parameter to gfc_check_conformance with _(). (check_reduction): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_pack): Mark for translation the string parameter to gfc_check_conformance with _(). * decl.c (match_old_style_init): Mark for translation the message parameter to gfc_invalid_boz using G_(). * decl.c (gfc_check_assign): Mark for translation the string parameter to gfc_check_conformance with _(). * intrinsic.c (check_specific): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_intrinsic_standard): Mark symstd_msg strings for translation using G_(). No need to mark symstd_msg for translation in call to gfc_warning or when setting symstd. * io.c (check_open_constraints): Mark strings for translation using G_() in all calls to warn_or_error. (match_io_element): Mark for translation the message parameter to gfc_invalid_boz using G_(). * primary.c (match_boz_constant): Mark for translation the message parameter to gfc_invalid_boz using G_(). * resolve.c (resolve_elemental_actual): Mark for translation the string parameter to gfc_check_conformance with _(). (resolve_operator): Mark for translation the string parameter to gfc_check_conformance with _(). Mark translation strings assigned to msg using G_() for use in a call to cfg_warning. -- https://www.codethink.co.uk/privacy.html
Fortran : Fortran translation issues PR52279
Patch to fix PR52279. Marked strings that are indirectly used in error and warning messages so that they are marked for translation. OK to commit? Commit message: Fortran : Fortran translation issues PR52279 Mark strings for translation by enclosing in G_() and _(). 2020-06-24 Mark Eggleston gcc/fortran/ PR fortran/52279 * arith.c (reduce_binary_aa): Mark for translation the string parameter to gfc_check_conformance with G_(). * check.c (gfc_invalid_boz): Mark hint for translation using _(). (gfc_check_achar): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_char): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_complex): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_float): Mark for translation the message parameter to gfc_invalid_boz using G_(). (check_rest): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_minloc_maxloc): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_findloc): Mark for translation the string parameter to gfc_check_conformance with _(). (check_reduction): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_pack): Mark for translation the string parameter to gfc_check_conformance with _(). * decl.c (match_old_style_init): Mark for translation the message parameter to gfc_invalid_boz using G_(). * decl.c (gfc_check_assign): Mark for translation the string parameter to gfc_check_conformance with _(). * intrinsic.c (check_specific): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_intrinsic_standard): Mark symstd_msg strings for translation using G_(). No need to mark symstd_msg for translation in call to gfc_warning or when setting symstd. * io.c (check_open_constraints): Mark strings for translation using G_() in all calls to warn_or_error. (match_io_element): Mark for translation the message parameter to gfc_invalid_boz using G_(). * primary.c (match_boz_constant): Mark for translation the message parameter to gfc_invalid_boz using G_(). * resolve.c (resolve_elemental_actual): Mark for translation the string parameter to gfc_check_conformance with _(). (resolve_operator): Mark for translation the string parameter to gfc_check_conformance with _(). Mark translation strings assigned to msg using G_() for use in a call to cfg_warning. -- https://www.codethink.co.uk/privacy.html >From ecd9fd13dcc6479b14072e6a0c8b186d33e5992b Mon Sep 17 00:00:00 2001 From: Mark Eggleston Date: Tue, 2 Jun 2020 08:38:01 +0100 Subject: [PATCH] Fortran : Fortran translation issues PR52279 Mark strings for translation by enclosing in G_() and _(). 2020-06-24 Mark Eggleston gcc/fortran/ PR fortran/52279 * arith.c (reduce_binary_aa): Mark for translation the string parameter to gfc_check_conformance with G_(). * check.c (gfc_invalid_boz): Mark hint for translation using _(). (gfc_check_achar): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_char): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_complex): Mark for translation the message parameter to gfc_invalid_boz using G_(). (gfc_check_float): Mark for translation the message parameter to gfc_invalid_boz using G_(). (check_rest): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_minloc_maxloc): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_findloc): Mark for translation the string parameter to gfc_check_conformance with _(). (check_reduction): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_pack): Mark for translation the string parameter to gfc_check_conformance with _(). * decl.c (match_old_style_init): Mark for translation the message parameter to gfc_invalid_boz using G_(). * decl.c (gfc_check_assign): Mark for translation the string parameter to gfc_check_conformance with _(). * intrinsic.c (check_specific): Mark for translation the string parameter to gfc_check_conformance with _(). (gfc_check_intrinsic_standard): Mark symstd_msg strings for translation using G_(). No need to mark symstd_msg for translation in call to gfc_warning or when setting symstd. * io.c (check_open_constraints): Mark strings for translation using G_() in all calls to warn_or_error. (match_io_element): Mark for translation the message parameter to gfc_invalid_boz using G_(). * primary.c (match_boz_constant): Mark for translation the message parameter to gfc_invalid_boz using G_(). * resolve.c (resolve_elemental_actual): Mark for translation the str
