Re: Missing pointer dereference in tree-affine.c

[Richard Biener]

On Thu, May 5, 2016 at 4:19 PM, Richard Sandiford
<richard.sandif...@arm.com> wrote:
> wide_int_constant_multiple_p used:
>
>   if (*mult_set && mult != 0)
> return false;
>
> to check whether we had previously seen a nonzero multiple, but "mult" is
> a pointer to the previous value rather than the previous value itself.
>
> Noticed by inspection while working on another patch, so I don't have a
> testcase.  I tried adding an assert for combinations that were wrongly
> rejected before but it didn't trigger during a bootstrap and regtest.
>
> Tested on x86_64-linux-gnu.  OK to install?

Ok.

Richard.

> Thanks,
> Richard
>
>
> gcc/
>     * tree-affine.c (wide_int_constant_multiple_p): Add missing
> pointer dereference.
>
> diff --git a/gcc/tree-affine.c b/gcc/tree-affine.c
> index 32f2301..4884241 100644
> --- a/gcc/tree-affine.c
> +++ b/gcc/tree-affine.c
> @@ -769,7 +769,7 @@ wide_int_constant_multiple_p (const widest_int , 
> const widest_int ,
>
>if (val == 0)
>  {
> -  if (*mult_set && mult != 0)
> +  if (*mult_set && *mult != 0)
> return false;
>*mult_set = true;
>*mult = 0;
>

Missing pointer dereference in tree-affine.c

[Richard Sandiford]

wide_int_constant_multiple_p used:

  if (*mult_set && mult != 0)
return false;

to check whether we had previously seen a nonzero multiple, but "mult" is
a pointer to the previous value rather than the previous value itself.

Noticed by inspection while working on another patch, so I don't have a
testcase.  I tried adding an assert for combinations that were wrongly
rejected before but it didn't trigger during a bootstrap and regtest.

Tested on x86_64-linux-gnu.  OK to install?

Thanks,
Richard


gcc/
    * tree-affine.c (wide_int_constant_multiple_p): Add missing
pointer dereference.

diff --git a/gcc/tree-affine.c b/gcc/tree-affine.c
index 32f2301..4884241 100644
--- a/gcc/tree-affine.c
+++ b/gcc/tree-affine.c
@@ -769,7 +769,7 @@ wide_int_constant_multiple_p (const widest_int , const 
widest_int ,
 
   if (val == 0)
 {
-  if (*mult_set && mult != 0)
+  if (*mult_set && *mult != 0)
return false;
   *mult_set = true;
   *mult = 0;