Re: PING: [RS6000] rotate and mask constants [PR94393]

[Bill Schmidt via Gcc-patches]

On 8/10/21 11:02 AM, Bill Schmidt wrote:

Hm, is this code ever executed?  How does this not result in assignment
through null pointers?

It would be good to figure out whether this code is reachable at all,
and just yank it out if not.  Otherwise we need a test case that hits it.

I seem to have been completely blind when I was looking at this. Please 
ignore this comment.


Thanks,
Bill

Re: PING: [RS6000] rotate and mask constants [PR94393]

[will schmidt via Gcc-patches]

On Fri, 2021-07-23 at 15:23 -0500, Pat Haugen via Gcc-patches wrote:
> Ping 
> https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555760.html
> 
> I've done a current bootstrap/regtest on powerpc64/powerpc64le with
> no regressions.
> 
> -Pat

That patch was previously posted by Alan Modra.
Given the time lapse this may need to be re-posted entirely, pending
what the maintainers suggest.. :-)


> gcc/
>   * config/rs6000/rs6000.c (rotate_and_mask_constant): New function.
>   (num_insns_constant_multi, rs6000_emit_set_long_const): Use it here.
>   * config/rs6000/rs6000.md (*movdi_internal64+1 splitter): Delete.

> gcc/testsuite/
>   * gcc.target/powerpc/rot_cst.h,
>   * gcc.target/powerpc/rot_cst1.c,
>   * gcc.target/powerpc/rot_cst2.c: New tests.
> 

I did a brief look-over at the time, and things looked OK to me then.


Thanks, 
-Will

PING: [RS6000] rotate and mask constants [PR94393]

[Pat Haugen via Gcc-patches]

Ping https://gcc.gnu.org/pipermail/gcc-patches/2020-October/555760.html

I've done a current bootstrap/regtest on powerpc64/powerpc64le with no 
regressions.

-Pat