Re: PR translation/80280
On 05/09/2017 09:33 AM, Nick Clifton wrote: Hi Martin, Rats! I ran into this when building for sparcv9-solaris2.11 but didn't look at the cause of the error carefully enough to recognize it was caused by my change so I just raised 80673 for it. It didn't occur to me that targets defined their own format extensions like this. What a tangled mess. Oh go on - if it was easy you would be bored... The fix should be trivial. My change added just a single member: format_flag_spec::quoting. I can take care of it today, along with bug 80673. Thanks very much! I just committed the Cygwin fix. It bootstraps for me but I didn't/couldn't run any tests so please give it a try and and let me know if there's anything else. Martin
Re: PR translation/80280
Hi Martin, > Rats! I ran into this when building for sparcv9-solaris2.11 but > didn't look at the cause of the error carefully enough to recognize > it was caused by my change so I just raised 80673 for it. It didn't > occur to me that targets defined their own format extensions like > this. What a tangled mess. Oh go on - if it was easy you would be bored... > The fix should be trivial. My change added just a single member: > format_flag_spec::quoting. I can take care of it today, along > with bug 80673. Thanks very much! Cheers Nick
Re: PR translation/80280
On 05/09/2017 09:08 AM, Nick Clifton wrote: Hi Martin, I am currently unable to build gcc for the x86_64-pc-cygwin target because gcc/config/i386/msformat-c.c uses the format_flag_spec struct but it has not been updated with the new field. :-( For example: gcc/config/i386/msformat-c.c gcc/config/i386/msformat-c.c:52:1: error: cannot convert 'format_std_version' to 'const char*' in initialization gcc/config/i386/msformat-c.c:52:1: warning: missing initializer for member 'format_flag_spec::std' gcc/current/gcc/config/i386/msformat-c.c:52:1: error: cannot convert 'format_std_version' to 'const char*' in initial Do you have time to fix this ? If not, please could you tell me which of the fields in the struct is new, and how it ought to be initialised. Rats! I ran into this when building for sparcv9-solaris2.11 but didn't look at the cause of the error carefully enough to recognize it was caused by my change so I just raised 80673 for it. It didn't occur to me that targets defined their own format extensions like this. What a tangled mess. The fix should be trivial. My change added just a single member: format_flag_spec::quoting. I can take care of it today, along with bug 80673. Sorry about that! Things are never as simple as they seem. Martin
Re: PR translation/80280
Hi Martin, I am currently unable to build gcc for the x86_64-pc-cygwin target because gcc/config/i386/msformat-c.c uses the format_flag_spec struct but it has not been updated with the new field. :-( For example: gcc/config/i386/msformat-c.c gcc/config/i386/msformat-c.c:52:1: error: cannot convert 'format_std_version' to 'const char*' in initialization gcc/config/i386/msformat-c.c:52:1: warning: missing initializer for member 'format_flag_spec::std' gcc/current/gcc/config/i386/msformat-c.c:52:1: error: cannot convert 'format_std_version' to 'const char*' in initial Do you have time to fix this ? If not, please could you tell me which of the fields in the struct is new, and how it ought to be initialised. Cheers Nick
