Re: Patch ping: Re: [PATCH] c, c++, v2: Accept __builtin_classify_type (typename)

2023-09-18 Thread Joseph Myers
On Mon, 18 Sep 2023, Jakub Jelinek via Gcc-patches wrote:

> Hi!
> 
> I'd like to ping this patch.
> The C++ FE part has been approved by Jason already with a minor change
> I've made in my copy.
> Are the remaining parts ok for trunk?

In the C front-end changes, since you end up discarding any side effects 
from the type, I'd expect use of in_alignof to be more appropriate than 
in_typeof (and thus not needing to use pop_maybe_used).

-- 
Joseph S. Myers
jos...@codesourcery.com


Patch ping: Re: [PATCH] c, c++, v2: Accept __builtin_classify_type (typename)

2023-09-18 Thread Jakub Jelinek via Gcc-patches
Hi!

I'd like to ping this patch.
The C++ FE part has been approved by Jason already with a minor change
I've made in my copy.
Are the remaining parts ok for trunk?

On Fri, Aug 11, 2023 at 10:48:19AM +0200, Jakub Jelinek via Gcc-patches wrote:
> 2023-08-11  Jakub Jelinek  
> 
> gcc/
>   * builtins.h (type_to_class): Declare.
>   * builtins.cc (type_to_class): No longer static.  Return
>   int rather than enum.
>   * doc/extend.texi (__builtin_classify_type): Document.
> gcc/c/
>   * c-parser.cc (c_parser_postfix_expression_after_primary): Parse
>   __builtin_classify_type call with typename as argument.
> gcc/cp/
>   * parser.cc (cp_parser_postfix_expression): Parse
>   __builtin_classify_type call with typename as argument.
>   * pt.cc (tsubst_copy_and_build): Handle __builtin_classify_type
>   with dependent typename as argument.
> gcc/testsuite/
>   * c-c++-common/builtin-classify-type-1.c: New test.
>   * g++.dg/ext/builtin-classify-type-1.C: New test.
>   * g++.dg/ext/builtin-classify-type-2.C: New test.
>   * gcc.dg/builtin-classify-type-1.c: New test.

Thanks

Jakub