Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-26 Thread Cary Coutant 
  This patch is OK, with or without the testsuite additions Jakub
  mentions.
 
  Thanks, I added the new tests, and tweaked the clone suffix parsing to
  allow the leading _.
 
  Committed as r179132.
 
  Should I backport this patch to gcc-4_6-branch?

 Since you offer, that would be nice.

OK, committed to gcc-4_6-branch as r179209.

-cary

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Jakub Jelinek 
On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote:
  Ping?
 
  http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html

It looks good to me, but I'd prefer if Ian with his demangler author
and libiberty maintainer hats looked at it too.

  include/ChangeLog:
 
         PR 40831
         * demangle.h (enum demangle_component_type): Add
         DEMANGLE_COMPONENT_CLONE.
 
  libiberty/ChangeLog:
 
         PR 40831
         * cp-demangle.c (d_make_comp): Add new component type.
         (cplus_demangle_mangled_name): Check for clone suffixes.
         (d_parmlist): Don't error out if we see '.'.
         (d_clone_suffix): New function.
         (d_print_comp): Print info for clone suffixes.
         * testsuite/demangle-expected: Add new testcases.

Maybe the testcase should test also
_Z2f1IiEvT_S0_S0_._omp_fn.2
_Z3fooi._omp_cpyfn.6
as examples of OpenMP suffixing - the former is an example of name
used for outlined #pragma omp {parallel,task} region from a function
and the latter is for copy constructors needed for #pragma omp task.

Jakub

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Ian Lance Taylor 
Jakub Jelinek ja...@redhat.com writes:

 On Thu, Sep 22, 2011 at 05:40:15PM -0700, Cary Coutant wrote:
  Ping?
 
  http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html

 It looks good to me, but I'd prefer if Ian with his demangler author
 and libiberty maintainer hats looked at it too.

This patch is OK, with or without the testsuite additions Jakub
mentions.

Thanks.

Ian

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Cary Coutant 
 This patch is OK, with or without the testsuite additions Jakub
 mentions.

Thanks, I added the new tests, and tweaked the clone suffix parsing to
allow the leading _.

Committed as r179132.

-cary

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Cary Coutant 
 This patch is OK, with or without the testsuite additions Jakub
 mentions.

 Thanks, I added the new tests, and tweaked the clone suffix parsing to
 allow the leading _.

 Committed as r179132.

Should I backport this patch to gcc-4_6-branch?

-cary

Re: Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-23 Thread Ian Lance Taylor 
Cary Coutant ccout...@google.com writes:

 This patch is OK, with or without the testsuite additions Jakub
 mentions.

 Thanks, I added the new tests, and tweaked the clone suffix parsing to
 allow the leading _.

 Committed as r179132.

 Should I backport this patch to gcc-4_6-branch?

Since you offer, that would be nice.

Ian

Ping: [libiberty patch] Add demangler support for cloned function symbols (PR 40831)

2011-09-22 Thread Cary Coutant 
 Ping?

 http://gcc.gnu.org/ml/gcc-patches/2011-08/msg01626.html

 -cary


 include/ChangeLog:

        PR 40831
        * demangle.h (enum demangle_component_type): Add
        DEMANGLE_COMPONENT_CLONE.

 libiberty/ChangeLog:

        PR 40831
        * cp-demangle.c (d_make_comp): Add new component type.
        (cplus_demangle_mangled_name): Check for clone suffixes.
        (d_parmlist): Don't error out if we see '.'.
        (d_clone_suffix): New function.
        (d_print_comp): Print info for clone suffixes.
        * testsuite/demangle-expected: Add new testcases.