Re: Ping^2: 2 libcpp patches
On Tue, Aug 16, 2022 at 9:50 AM Lewis Hyatt wrote: > > On Wed, Jul 20, 2022 at 8:56 PM Lewis Hyatt wrote: > > > > Hello- > > > > May I please ping these two preprocessor patches? > > > > For PR103902: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596704.html > > > > For PR55971: > > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596820.html > > > > Thanks! > > Hello- > > I would very much appreciate feedback on these two patches please? > > For the first patch, I think it is a worthwhile goal to fix all the > places where libcpp fails to support UTF-8 correctly, and this is one > of two remaining ones that I'm aware of. I can fix the other case > (handling of #pragma push_macro) once this one is in place. > > The second patch is about libcpp not allowing raw strings containing > newlines in preprocessor directives, which is a nearly decade-old > glitch that I think is also worth addressing. > > Thanks! > > -Lewis Hello- I CCed Joseph on this ping last week, but he suggested asking other maintainers to take a look, so I hope it's OK I am doing that now? Jakub, I thought it could make sense to ask you please, since I saw you working on lex.cc recently as well, and also since you commented on PR55971 nine years ago :). With an uptick in development of libcpp to support new C++23 features, I think the chances that my patches will eventually conflict with those are increasing, so it would be great to get them reviewed. As of current master branch, they still apply and regtest fine. Thanks very much. -Lewis
Re: Ping^2: 2 libcpp patches
On Tue, 16 Aug 2022, Lewis Hyatt via Gcc-patches wrote: > For the first patch, I think it is a worthwhile goal to fix all the > places where libcpp fails to support UTF-8 correctly, and this is one > of two remaining ones that I'm aware of. I can fix the other case > (handling of #pragma push_macro) once this one is in place. > > The second patch is about libcpp not allowing raw strings containing > newlines in preprocessor directives, which is a nearly decade-old > glitch that I think is also worth addressing. As these are both about C++ features, C++ maintainers might be best placed to look at them. -- Joseph S. Myers jos...@codesourcery.com
Ping^2: 2 libcpp patches
On Wed, Jul 20, 2022 at 8:56 PM Lewis Hyatt wrote: > > Hello- > > May I please ping these two preprocessor patches? > > For PR103902: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596704.html > > For PR55971: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596820.html > > Thanks! Hello- I would very much appreciate feedback on these two patches please? For the first patch, I think it is a worthwhile goal to fix all the places where libcpp fails to support UTF-8 correctly, and this is one of two remaining ones that I'm aware of. I can fix the other case (handling of #pragma push_macro) once this one is in place. The second patch is about libcpp not allowing raw strings containing newlines in preprocessor directives, which is a nearly decade-old glitch that I think is also worth addressing. Thanks! -Lewis
