Thank you for installing my patch Jeff! Yes, I intend to contribute regularly. I'm working on getting copyright assignment/disclaimer paperwork approved by my employer. I'll apply for commit privs after that.
Eugene -----Original Message----- From: Jeff Law <l...@redhat.com> Sent: Wednesday, November 18, 2020 11:33 AM To: Richard Biener <richard.guent...@gmail.com>; Eugene Rozenfeld <eugene.rozenf...@microsoft.com> Cc: gcc-patches@gcc.gnu.org Subject: [EXTERNAL] Re: [PATCH] [tree-optimization] Optimize two patterns with three xors. On 11/17/20 12:57 AM, Richard Biener via Gcc-patches wrote: > On Tue, Nov 17, 2020 at 3:19 AM Eugene Rozenfeld > <eugene.rozenf...@microsoft.com> wrote: >> Thank you for the review Richard! >> >> I re-worked the patch based on your suggestions (attached). >> I made the change to reuse the first bit_xor in both patterns and I added :s >> to the last xor in the first pattern. >> For the second pattern I didn't add :s because I think the simplification is >> beneficial even if the second or third bit_xor has more than one use since >> we are simplifying them to just a single operand (@2). If that is incorrect, >> please explain why. > Ah, true, that's correct. > > The patch is OK. I've installed this on the trunk. Eugene, if you're going to contribute regularly you should probably go ahead and get commit privs so that you can commit ACK's patches yourself. There should be a link to a form from this page: https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc.gnu.org%2Fgitwrite.html&data=04%7C01%7Ceugene.rozenfeld%40microsoft.com%7Ca31f5335968749cdfe1708d88bf8bfb2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637413247775369684%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=BfQGAtU%2F8IJ8%2BRcvuNI8qKWgnC9oPFtWQhXo1RzlBTU%3D&reserved=0 Jeff
