RE: [PATCH, testsuite] MIPS: Remove redundant dg-skip-if from mips16-attributes.c.
Committed as r243649. Regards, Toma > Toma Tabacu writes: > > In the case of mips16-attributes.c, even though the (-mips16) option ensures > > that -mmicromips will be overriden, there still is a dg-skip-if for > > -mmicromips. > > > > I think that it is not necessary and it actually decreases test coverage, > > because it will cause the testsuite to skip this test instead of letting > > (-mips16) do its job of overriding the global options. > > > > This patch removes the dg-skip-if for -mmicromips. > > > > Tested with mips-mti-elf. > > > > Regards, > > Toma > > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/mips/mips16-attributes.c: Remove dg-skip-if for > > -mmicromips. > > OK, thanks. > > Matthew
RE: [PATCH, testsuite] MIPS: Remove redundant dg-skip-if from mips16-attributes.c.
Toma Tabacu writes: > In the case of mips16-attributes.c, even though the (-mips16) option ensures > that -mmicromips will be overriden, there still is a dg-skip-if for > -mmicromips. > > I think that it is not necessary and it actually decreases test coverage, > because it will cause the testsuite to skip this test instead of letting > (-mips16) do its job of overriding the global options. > > This patch removes the dg-skip-if for -mmicromips. > > Tested with mips-mti-elf. > > Regards, > Toma > > gcc/testsuite/ChangeLog: > > * gcc.target/mips/mips16-attributes.c: Remove dg-skip-if for > -mmicromips. OK, thanks. Matthew