RE: [PATCH] vect: Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS consistently
Hi, > -Original Message- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: Monday, June 15, 2020 5:12 PM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] vect: Use LOOP_VINFO_DATAREFS and > LOOP_VINFO_DDRS consistently > > > > > Thanks for reviewing this. Could you please help install it? > > Pushed. Please remember to verify the ChangeLog - I needed to replace > leading 8 spaces with tabs. Thanks for the effort. Looks like the issue was caused by copy-and-paste, will pay attention next time. Felix
Re: [PATCH] vect: Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS consistently
On Mon, Jun 15, 2020 at 9:34 AM Yangfei (Felix) wrote: > > Hi Richard, > > > -Original Message- > > From: Richard Biener [mailto:richard.guent...@gmail.com] > > Sent: Monday, June 15, 2020 3:25 PM > > To: Yangfei (Felix) > > Cc: gcc-patches@gcc.gnu.org > > Subject: Re: [PATCH] vect: Use LOOP_VINFO_DATAREFS and > > LOOP_VINFO_DDRS consistently > > > > On Sat, Jun 13, 2020 at 4:46 AM Yangfei (Felix) > > wrote: > > > > > > Hi, > > > > > > This is minor code refactorings in tree-vect-data-refs.c and > > > tree-vect-loop.c. > > > Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS when possible and > > rename > > > several parameters to make code more consistent. > > > > > > Bootstrapped and tested on aarch64-linux-gnu. OK? > > > > OK. > > Thanks for reviewing this. Could you please help install it? Pushed. Please remember to verify the ChangeLog - I needed to replace leading 8 spaces with tabs. Richard. > Regards, > Felix
RE: [PATCH] vect: Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS consistently
Hi Richard, > -Original Message- > From: Richard Biener [mailto:richard.guent...@gmail.com] > Sent: Monday, June 15, 2020 3:25 PM > To: Yangfei (Felix) > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] vect: Use LOOP_VINFO_DATAREFS and > LOOP_VINFO_DDRS consistently > > On Sat, Jun 13, 2020 at 4:46 AM Yangfei (Felix) > wrote: > > > > Hi, > > > > This is minor code refactorings in tree-vect-data-refs.c and > > tree-vect-loop.c. > > Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS when possible and > rename > > several parameters to make code more consistent. > > > > Bootstrapped and tested on aarch64-linux-gnu. OK? > > OK. Thanks for reviewing this. Could you please help install it? Regards, Felix
Re: [PATCH] vect: Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS consistently
On Sat, Jun 13, 2020 at 4:46 AM Yangfei (Felix) wrote: > > Hi, > > This is minor code refactorings in tree-vect-data-refs.c and tree-vect-loop.c. > Use LOOP_VINFO_DATAREFS and LOOP_VINFO_DDRS when possible and rename > several parameters to make code more consistent. > > Bootstrapped and tested on aarch64-linux-gnu. OK? OK. Richard. > Thanks, > Felix > > gcc/ > > +2020-06-13 Felix Yang > + > + * tree-vect-data-refs.c (vect_verify_datarefs_alignment): Rename > + parameter to loop_vinfo and update uses. Use LOOP_VINFO_DATAREFS > + when possible. > + (vect_analyze_data_refs_alignment): Likewise, and use LOOP_VINFO_DDRS > + when possible. > + * tree-vect-loop.c (vect_dissolve_slp_only_groups): Use > + LOOP_VINFO_DATAREFS when possible. > + (update_epilogue_loop_vinfo): Likewise.
