RE: [PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at config/aarch64/aarch64.c:16803

[Yangfei (Felix)]

Hi Richard,

> -Original Message-
> From: Richard Sandiford [mailto:richard.sandif...@arm.com]
> Sent: Wednesday, June 3, 2020 1:19 AM
> To: Yangfei (Felix) 
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at
> config/aarch64/aarch64.c:16803
> 
> "Yangfei (Felix)"  writes:
> > Hi,
> >
> > Please review this trivial patch fixing an ICE in 
> > aarch64_short_vector_p.
> > Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95459
> >
> > In aarch64_short_vector_p, we are simply checking whether a type (and
> a mode)
> > is a 64/128-bit short vector or not.  This should not be affected by the
> value
> > of TARGET_SVE.  Simply leave later code to report an error if SVE is
> disabled.
> > Bootstrapped and tested on aarch64-linux-gnu.  OK?
> 
> OK, thanks.  Pushed to master.

Thanks for reviewing and installing the patch : - )

Felix

Re: [PATCH PR95459] aarch64: ICE in aarch64_short_vector_p, at config/aarch64/aarch64.c:16803

[Richard Sandiford]

"Yangfei (Felix)"  writes:
> Hi,
>
> Please review this trivial patch fixing an ICE in aarch64_short_vector_p.
> Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95459 
>
> In aarch64_short_vector_p, we are simply checking whether a type (and a 
> mode)
> is a 64/128-bit short vector or not.  This should not be affected by the 
> value
> of TARGET_SVE.  Simply leave later code to report an error if SVE is 
> disabled.
> Bootstrapped and tested on aarch64-linux-gnu.  OK?

OK, thanks.  Pushed to master.

Richard

>
> gcc/ChangeLog
> @@ -1,3 +1,9 @@
> +2020-06-02  Felix Yang  
> +
> +   PR target/95459
> +   * config/aarch64/aarch64.c (aarch64_short_vector_p):
> +   Leave later code to report an error if SVE is disabled.
>
> gcc/testsuite/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-06-02  Felix Yang  
> +
> +   PR target/95459
> +   * gcc.target/aarch64/mgeneral-regs_6.c: New test.
>
> Thanks,
> Felix