Re: [patch, x86] Improve memcpy/memset strategy for Skylake.

2018-07-19 Thread Uros Bizjak 
On Thu, Jul 19, 2018 at 8:20 AM, Koval, Julia  wrote:
> Yes, it gives small improvements(~2%) on 557.xz on O2 and on 
> 548.exchange(~2.5%) and 500.perlbench(~1%) on Ofast in rate mode.
>
>> -Original Message-
>> From: Uros Bizjak [mailto:ubiz...@gmail.com]
>> Sent: Thursday, July 19, 2018 8:12 AM
>> To: Koval, Julia 
>> Cc: GCC Patches 
>> Subject: Re: [patch, x86] Improve memcpy/memset strategy for Skylake.
>>
>> On Thu, Jul 19, 2018 at 7:00 AM, Koval, Julia  wrote:
>> > Hi,
>> > This patch improves memset/memcpy strategy for Skylake. Ok for trunk?
>>
>> Is this patch based on some benchmark data?
>>
>> Uros.
>>
>> > * gcc/config/i386/x86-tune-costs.h (skylake_memcpy,
>> > skylake_memcpy): Replace rep_prefix with unrolling on 512.

OK for mainline with a fixed ChangeLog entry, something like:

...: Replace rep_prefix with unrolling for size 512.

Thanks,
Uros.

RE: [patch, x86] Improve memcpy/memset strategy for Skylake.

2018-07-19 Thread Koval, Julia 
Yes, it gives small improvements(~2%) on 557.xz on O2 and on 
548.exchange(~2.5%) and 500.perlbench(~1%) on Ofast in rate mode. 

> -Original Message-
> From: Uros Bizjak [mailto:ubiz...@gmail.com]
> Sent: Thursday, July 19, 2018 8:12 AM
> To: Koval, Julia 
> Cc: GCC Patches 
> Subject: Re: [patch, x86] Improve memcpy/memset strategy for Skylake.
> 
> On Thu, Jul 19, 2018 at 7:00 AM, Koval, Julia  wrote:
> > Hi,
> > This patch improves memset/memcpy strategy for Skylake. Ok for trunk?
> 
> Is this patch based on some benchmark data?
> 
> Uros.
> 
> > * gcc/config/i386/x86-tune-costs.h (skylake_memcpy,
> > skylake_memcpy): Replace rep_prefix with unrolling on 512.
> >
> > Thanks,
> > Julia
> >

Re: [patch, x86] Improve memcpy/memset strategy for Skylake.

2018-07-19 Thread Uros Bizjak 
On Thu, Jul 19, 2018 at 7:00 AM, Koval, Julia  wrote:
> Hi,
> This patch improves memset/memcpy strategy for Skylake. Ok for trunk?

Is this patch based on some benchmark data?

Uros.

> * gcc/config/i386/x86-tune-costs.h (skylake_memcpy,
> skylake_memcpy): Replace rep_prefix with unrolling on 512.
>
> Thanks,
> Julia
>