Re: RFA: Remove ADDRESS handling from gen*.c

2012-04-16 Thread Richard Guenther
On Sun, Apr 15, 2012 at 5:09 PM, Richard Sandiford
rdsandif...@googlemail.com wrote:
 ADDRESS has long had no meaning in .md files.  This patch removes
 the associated gen* support.

 Borders on the obvious, but just to be sure: bootstrapped  regression
 tested on x86_64-linux-gnu.  OK to install?

Ok.

Thanks,
Richard.

 Richard


 gcc/
        * genemit.c (gen_exp): Remove ADDRESS handling.
        * genoutput.c (scan_operands): Likewise.
        * genpeep.c (match_rtx): Likewise.
        * genrecog.c (add_to_sequence): Likewise.

 Index: gcc/genemit.c
 ===
 --- gcc/genemit.c       2012-03-06 19:20:53.0 +
 +++ gcc/genemit.c       2012-04-15 10:35:29.615548775 +0100
 @@ -160,9 +160,6 @@ gen_exp (rtx x, enum rtx_code subroutine
       gen_rtx_scratch (x, subroutine_type);
       return;

 -    case ADDRESS:
 -      fatal (ADDRESS expression code used in named instruction pattern);
 -
     case PC:
       printf (pc_rtx);
       return;
 Index: gcc/genoutput.c
 ===
 --- gcc/genoutput.c     2011-08-27 09:54:07.0 +0100
 +++ gcc/genoutput.c     2012-04-15 10:35:29.617548777 +0100
 @@ -510,10 +510,6 @@ scan_operands (struct data *d, rtx part,
        scan_operands (d, XVECEXP (part, 2, i), 0, 0);
       return;

 -    case ADDRESS:
 -      scan_operands (d, XEXP (part, 0), 1, 0);
 -      return;
 -
     case STRICT_LOW_PART:
       scan_operands (d, XEXP (part, 0), 0, 1);
       return;
 Index: gcc/genpeep.c
 ===
 --- gcc/genpeep.c       2011-08-27 09:54:07.0 +0100
 +++ gcc/genpeep.c       2012-04-15 10:35:29.617548777 +0100
 @@ -231,10 +231,6 @@ match_rtx (rtx x, struct link *path, int
        }
       return;

 -    case ADDRESS:
 -      match_rtx (XEXP (x, 0), path, fail_label);
 -      return;
 -
     default:
       break;
     }
 Index: gcc/genrecog.c
 ===
 --- gcc/genrecog.c      2011-08-27 09:54:07.0 +0100
 +++ gcc/genrecog.c      2012-04-15 11:14:58.661416813 +0100
 @@ -687,7 +687,6 @@ add_to_sequence (rtx pattern, struct dec
   sub = this_decision = new_decision (pos, last);
   place = this_decision-tests;

 - restart:
   mode = GET_MODE (pattern);
   code = GET_CODE (pattern);

 @@ -854,10 +853,6 @@ add_to_sequence (rtx pattern, struct dec
       test-u.dup = XINT (pattern, 0);
       goto fini;

 -    case ADDRESS:
 -      pattern = XEXP (pattern, 0);
 -      goto restart;
 -
     default:
       break;
     }


RFA: Remove ADDRESS handling from gen*.c

2012-04-15 Thread Richard Sandiford
ADDRESS has long had no meaning in .md files.  This patch removes
the associated gen* support.

Borders on the obvious, but just to be sure: bootstrapped  regression
tested on x86_64-linux-gnu.  OK to install?

Richard


gcc/
* genemit.c (gen_exp): Remove ADDRESS handling.
* genoutput.c (scan_operands): Likewise.
* genpeep.c (match_rtx): Likewise.
* genrecog.c (add_to_sequence): Likewise.

Index: gcc/genemit.c
===
--- gcc/genemit.c   2012-03-06 19:20:53.0 +
+++ gcc/genemit.c   2012-04-15 10:35:29.615548775 +0100
@@ -160,9 +160,6 @@ gen_exp (rtx x, enum rtx_code subroutine
   gen_rtx_scratch (x, subroutine_type);
   return;
 
-case ADDRESS:
-  fatal (ADDRESS expression code used in named instruction pattern);
-
 case PC:
   printf (pc_rtx);
   return;
Index: gcc/genoutput.c
===
--- gcc/genoutput.c 2011-08-27 09:54:07.0 +0100
+++ gcc/genoutput.c 2012-04-15 10:35:29.617548777 +0100
@@ -510,10 +510,6 @@ scan_operands (struct data *d, rtx part,
scan_operands (d, XVECEXP (part, 2, i), 0, 0);
   return;
 
-case ADDRESS:
-  scan_operands (d, XEXP (part, 0), 1, 0);
-  return;
-
 case STRICT_LOW_PART:
   scan_operands (d, XEXP (part, 0), 0, 1);
   return;
Index: gcc/genpeep.c
===
--- gcc/genpeep.c   2011-08-27 09:54:07.0 +0100
+++ gcc/genpeep.c   2012-04-15 10:35:29.617548777 +0100
@@ -231,10 +231,6 @@ match_rtx (rtx x, struct link *path, int
}
   return;
 
-case ADDRESS:
-  match_rtx (XEXP (x, 0), path, fail_label);
-  return;
-
 default:
   break;
 }
Index: gcc/genrecog.c
===
--- gcc/genrecog.c  2011-08-27 09:54:07.0 +0100
+++ gcc/genrecog.c  2012-04-15 11:14:58.661416813 +0100
@@ -687,7 +687,6 @@ add_to_sequence (rtx pattern, struct dec
   sub = this_decision = new_decision (pos, last);
   place = this_decision-tests;
 
- restart:
   mode = GET_MODE (pattern);
   code = GET_CODE (pattern);
 
@@ -854,10 +853,6 @@ add_to_sequence (rtx pattern, struct dec
   test-u.dup = XINT (pattern, 0);
   goto fini;
 
-case ADDRESS:
-  pattern = XEXP (pattern, 0);
-  goto restart;
-
 default:
   break;
 }